From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWU4E-0007yI-D7 for qemu-devel@nongnu.org; Thu, 18 Feb 2016 14:16:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWU4B-0008NB-5r for qemu-devel@nongnu.org; Thu, 18 Feb 2016 14:16:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWU4A-0008Mv-UH for qemu-devel@nongnu.org; Thu, 18 Feb 2016 14:16:43 -0500 References: <1455818725-7647-1-git-send-email-peter.maydell@linaro.org> <1455818725-7647-8-git-send-email-peter.maydell@linaro.org> From: Eric Blake Message-ID: <56C61898.4050302@redhat.com> Date: Thu, 18 Feb 2016 12:16:40 -0700 MIME-Version: 1.0 In-Reply-To: <1455818725-7647-8-git-send-email-peter.maydell@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Wodn0Dr5JlcAnBomADGsdrvckRu9ehrcc" Subject: Re: [Qemu-devel] [PATCH 7/8] all: Clean up includes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Wodn0Dr5JlcAnBomADGsdrvckRu9ehrcc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/18/2016 11:05 AM, Peter Maydell wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. >=20 > This commit was created with scripts/clean-includes. >=20 > Signed-off-by: Peter Maydell > --- > 56 files changed, 2 insertions(+), 100 deletions(-) >=20 > +++ b/io/channel-util.c > @@ -18,6 +18,7 @@ > * > */ > =20 > +#include "qemu/osdep.h" > #include "io/channel-util.h" > #include "io/channel-file.h" > #include "io/channel-socket.h" Ah, so the 2 insertions are due to recent file additions, after your last round of cleanups. Any way to automate this into checkpatch.pl for new file creation? Then again, not all developers have Coccinelle installed. But even checking whether the string 'include.*qemu/osdep.h' is present in a new file may help, even if it doesn't detect it being included out-of-order. > +++ b/slirp/slirp.h > @@ -1,11 +1,9 @@ > #ifndef __COMMON_H__ > #define __COMMON_H__ > =20 > -#include "config-host.h" > #include "slirp_config.h" > =20 > #ifdef _WIN32 > -# include > =20 > typedef char *caddr_t; > =20 > @@ -23,43 +21,31 @@ typedef char *caddr_t; > # endif > #endif > =20 > -#include > #ifdef HAVE_SYS_BITYPES_H > # include > #endif > =20 > -#include > =20 > #ifdef HAVE_UNISTD_H > -# include > #endif > =20 > #ifdef HAVE_STDLIB_H > -# include > #endif Leftover dead checks of HAVE_UNISTD_H and so forth; this file could use further manual cleanups. For that matter, do we even need HAVE_UNISTD_H in slirp/slirp_config.h any more? There's probably quite a bit of pruning of cruft we could do. But as this patch was completely automated, I'm fine if that cleanup is done as followups. Therefore, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Wodn0Dr5JlcAnBomADGsdrvckRu9ehrcc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWxhiYAAoJEKeha0olJ0NqlNgH/2Gc9PszKoD+1s1AtD1AogQ+ vR/XEcMwgru2P0ZbM5pEX5ZD5LKJKDtU4Cuhfvsmj7MX9S8qs9OhmjPEL6T4h4eF 7kmmcQimLi7P/9rWMAoqhfuosaLzT7m5jjhQustBCsjSnbwOlGkqzBKh8uTuoA4B gy0LlMcBD4j8TQRPDI1NU9cp1YDswl5Fsbf8F+yFqz5KJRhTwYk+0Zv8yrG5IHZf 41Kx8PiEtjresFa214U68xjM9vhTfblaETK+NpxSZobW0uphzFEj8YpAqUqa0I+X q78oE3t82kXKf47e5EvAWHETzeLpgqmC7TL2qqkn3Rtp9cIefO5YqtzfcKOmWn8= =lmrL -----END PGP SIGNATURE----- --Wodn0Dr5JlcAnBomADGsdrvckRu9ehrcc--