From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWUTV-0000Mg-3P for qemu-devel@nongnu.org; Thu, 18 Feb 2016 14:42:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWUTR-00050t-TO for qemu-devel@nongnu.org; Thu, 18 Feb 2016 14:42:53 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:21169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWUTR-0004zA-1A for qemu-devel@nongnu.org; Thu, 18 Feb 2016 14:42:49 -0500 References: <1453743649-31581-1-git-send-email-peter.maydell@linaro.org> <56B089D2.2030508@imgtec.com> From: Leon Alrae Message-ID: <56C61E8D.2010406@imgtec.com> Date: Thu, 18 Feb 2016 19:42:05 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-mips: Stop using uint_fast*_t types in r4k_tlb_t struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "qemu-devel@nongnu.org" , Aurelien Jarno , "patches@linaro.org" On 18/02/16 11:51, Peter Maydell wrote: > On 2 February 2016 at 10:49, Leon Alrae wrote: >> On 25/01/16 17:40, Peter Maydell wrote: >>> The r4k_tlb_t structure uses the uint_fast*_t types. Most of these >>> uses are in bitfields and are thus pointless, because the bitfield >>> itself specifies the width of the type; just use 'unsigned int' >>> instead. (On glibc uint_fast16_t is defined as either 32 or 64 bits, >>> so we know the code is not reliant on it being exactly 16 bits.) >>> There is also one use of uint_fast8_t, which we replace with uint8_t, >>> because both are exactly 8 bits on glibc and this is the only >>> place outside the softfloat code which uses an int_fast*_t type. >>> >>> Signed-off-by: Peter Maydell >>> --- >>> I'm going to have a go at getting rid of the int_fast16_t usage >>> in the softfloat code too, but in the meantime this is an >>> independent cleanup. >>> >>> target-mips/cpu.h | 26 +++++++++++++------------- >>> 1 file changed, 13 insertions(+), 13 deletions(-) >> >> Applied to target-mips tree, thanks. > > Hi -- is this going to appear in master soon? I have another patch > pending that depends on it... I'm out of office this week and will be able to send a pull request early next week. If you are planning to apply that another patch earlier, then please feel free to include this one in your pull request. Thanks, Leon