From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jianqun Xu Subject: Re: [PATCH 5/6] dt-bindings: add documentation of rk3399 clock controller Date: Fri, 19 Feb 2016 09:05:13 +0800 Message-ID: <56C66A49.2080501@rock-chips.com> References: <1455673992-16469-1-git-send-email-jay.xu@rock-chips.com> <20160218143648.GL9654@rob-hp-laptop> <56C6664F.8070600@rock-chips.com> <1758156.nKISImzkM9@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="gbk"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1758156.nKISImzkM9@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Heiko Stuebner Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, Rob Herring , huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, Xing Zheng , pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, jwerner-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org SGkgSGVpa28KCtTaIDE5LzAyLzIwMTYgMDg6NTMsIEhlaWtvIFN0dWVibmVyINC0tcA6Cj4gQW0g RnJlaXRhZywgMTkuIEZlYnJ1YXIgMjAxNiwgMDg6NDg6MTUgc2NocmllYiBKaWFucXVuIFh1Ogo+ PiBIaSBSb2IKPj4KPj4g1NogMTgvMDIvMjAxNiAyMjozNiwgUm9iIEhlcnJpbmcg0LS1wDoKPj4+ IE9uIFdlZCwgRmViIDE3LCAyMDE2IGF0IDA5OjU0OjQ5QU0gKzA4MDAsIGppYW5xdW4ueHUgd3Jv dGU6Cj4+Pj4gRnJvbTogWGluZyBaaGVuZyA8emhlbmd4aW5nQHJvY2stY2hpcHMuY29tPgo+Pj4+ Cj4+Pj4gQWRkIHRoZSBkZXZpY2V0cmVlIGJpbmRpbmcgZm9yIHRoZSBjcnUgb24gdGhlIHJrMzM5 OSB3aGljaCBxdWl0ZQo+Pj4+IHNpbWlsYXIgc3RydWN0dXJlZCBhcyBwcmV2aW91cyBjbG9jayBj b250cm9sbGVycy4KPj4+Pgo+Pj4+IFNpZ25lZC1vZmYtYnk6IFhpbmcgWmhlbmcgPHpoZW5neGlu Z0Byb2NrLWNoaXBzLmNvbT4KPj4+PiAtLS0KPj4+Pgo+Pj4+ICAgIC4uLi9iaW5kaW5ncy9jbG9j ay9yb2NrY2hpcCxyazMzOTktY3J1LnR4dCAgICAgICAgIHwgODIKPj4+PiAgICArKysrKysrKysr KysrKysrKysrKysrIDEgZmlsZSBjaGFuZ2VkLCA4MiBpbnNlcnRpb25zKCspCj4+Pj4gICAgY3Jl YXRlIG1vZGUgMTAwNjQ0Cj4+Pj4gICAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L2Nsb2NrL3JvY2tjaGlwLHJrMzM5OS1jcnUudHh0Pj4KPj4+PiBkaWZmIC0tZ2l0Cj4+Pj4gYS9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY2xvY2svcm9ja2NoaXAscmszMzk5LWNy dS50eHQKPj4+PiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9jbG9jay9yb2Nr Y2hpcCxyazMzOTktY3J1LnR4dCBuZXcKPj4+PiBmaWxlIG1vZGUgMTAwNjQ0Cj4+Pj4gaW5kZXgg MDAwMDAwMC4uMDdiY2M2ZQo+Pj4+IC0tLSAvZGV2L251bGwKPj4+PiArKysgYi9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY2xvY2svcm9ja2NoaXAscmszMzk5LWNydS50eHQKPj4+ PiBAQCAtMCwwICsxLDgyIEBACj4+Pj4gKyogUm9ja2NoaXAgUkszMzk5IENsb2NrIGFuZCBSZXNl dCBVbml0Cj4+Pgo+Pj4gWy4uLl0KPj4+Cj4+Pj4gK0V4YW1wbGU6IEdlbmVyYWwgUmVnaXN0ZXIg RmlsZXMKPj4+PiArCj4+Pj4gKwlwbXVncmY6IHN5c2NvbkBmZjMyMDAwMCB7Cj4+Pj4gKwkJY29t cGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktcG11Z3JmIiwgInN5c2NvbiI7Cj4+Pgo+Pj4gSXMg dGhpcyBkb2N1bWVudGVkPwo+Pgo+PiBTaW5jZSB0aGVyZSBpcyBubyBkb2N1bWVudGF0aW9uIGZv ciByb2NrY2hpcCBncmYgZnJvbSBlYXJseSBTb0NzLCBJCj4+IHRoaW5rIGlmIHdlIG5lZWQgdG8g YWRkIGEgbmV3IGRldmljZXRyZWUgZG9jdW1lbnRhdGlvbiwgc3VjaCBhcwo+PiBEb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY2xvY2svcm9ja2NoaXAscmszMzk5LWdyZi50eHQgPwo+ Cj4gVGhlIGdyZiBpcyBub3QgY2xvY2stc3BlY2lmaWMsIHNvIHRoZSBkaXJlY3RvcnkgaXMgcHJv YmFibHkgbm90IGNvcnJlY3QuCj4gSSdkIHRoaW5rIGJpbmRpbmdzL2FybS9yb2NrY2hpcC9ncmYu dHh0IG1pZ2h0IGJlIGJldHRlciBvcgo+IGJpbmRpbmdzL3NvYy9yb2NrY2hpcC9ncmYudHh0IG9y IHNvbWV3aGVyZSBlbHNlLiBBbmQgZGVmaW5lIHRoZSBwcm9wZXJ0aWVzCj4gZm9yIGFsbCBwZXIt c29jIEdSRnMgaW4gdGhlcmUuCj4KPiBJbiBhbnkgY2FzZSB3ZSByZWFsbHkgc2hvdWxkIGFkZCB0 aGUgbWlzc2luZyBncmYgYmluZGluZyBkb2N1bWVudGF0aW9uIChpbiBhCj4gc2VwYXJhdGUgcGF0 Y2ggb2YgY291cnNlKSwgYXMgdGhlIGdyZiBpcyBhIHByZXR0eSBjb21tb25seSB1c2VkIHNoYXJl ZAo+IGNvbXBvbmVudC4KPgpHb3QgaXQsIEkgd2lsbCBhZGQgYmluZGluZ3Mvc29jL3JvY2tjaGlw L2dyZi50eHQgaW4gbmV4dCBwYXRjaApUaGFua3MgIQo+Cj4+Cj4+IElmIHlvdSBhZ3JlZSwgSSB3 aWxsIGFkZCBpdCBpbiBuZXh0IHBhdGNoCj4+Cj4+Pj4gKwkJcmVnID0gPDB4MCAweGZmMzIwMDAw IDB4MCAweDEwMDA+Owo+Pj4+ICsJfTsKPj4+PiArCj4+Pj4gKwlncmY6IHN5c2NvbkBmZjc3MDAw MCB7Cj4+Pj4gKwkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktZ3JmIiwgInN5c2NvbiI7 Cj4+Pgo+Pj4gZGl0dG8uCj4+Pgo+Pj4+ICsJCXJlZyA9IDwweDAgMHhmZjc3MDAwMCAweDAgMHgx MDAwMD47Cj4+Pj4gKwl9Owo+Pj4+ICsKPj4+PiArRXhhbXBsZTogQ2xvY2sgY29udHJvbGxlciBu b2RlOgo+Pj4+ICsKPj4+PiArCXBtdWNydTogcG11LWNsb2NrLWNvbnRyb2xsZXJAZmY3NTAwMDAg ewo+Pj4+ICsJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszMzk5LXBtdWNydSI7Cj4+Pj4gKwkJ cmVnID0gPDB4MCAweGZmNzUwMDAwIDB4MCAweDEwMDA+Owo+Pj4+ICsJCSNjbG9jay1jZWxscyA9 IDwxPjsKPj4+PiArCQkjcmVzZXQtY2VsbHMgPSA8MT47Cj4+Pj4gKwl9Owo+Pj4+ICsKPj4+PiAr CWNydTogY2xvY2stY29udHJvbGxlckBmZjc2MDAwMCB7Cj4+Pj4gKwkJY29tcGF0aWJsZSA9ICJy b2NrY2hpcCxyazMzOTktY3J1IjsKPj4+PiArCQlyZWcgPSA8MHgwIDB4ZmY3NjAwMDAgMHgwIDB4 MTAwMD47Cj4+Pj4gKwkJcm9ja2NoaXAsZ3JmID0gPCZncmY+Owo+Pj4+ICsJCSNjbG9jay1jZWxs cyA9IDwxPjsKPj4+PiArCQkjcmVzZXQtY2VsbHMgPSA8MT47Cj4+Pj4gKwl9Owo+Pj4+ICsKPj4+ PiArRXhhbXBsZTogVUFSVCBjb250cm9sbGVyIG5vZGUgdGhhdCBjb25zdW1lcyB0aGUgY2xvY2sg Z2VuZXJhdGVkIGJ5IHRoZQo+Pj4+IGNsb2NrICsgIGNvbnRyb2xsZXI6Cj4+Pj4gKwo+Pj4+ICsJ dWFydDA6IHNlcmlhbEBmZjFhMDAwMCB7Cj4+Pj4gKwkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxy azMzOTktdWFydCIsICJzbnBzLGR3LWFwYi11YXJ0IjsKPj4+PiArCQlyZWcgPSA8MHgwIDB4ZmYx ODAwMDAgMHgwIDB4MTAwPjsKPj4+PiArCQljbG9ja3MgPSA8JmNydSBTQ0xLX1VBUlQwPiwgPCZj cnUgUENMS19VQVJUMD47Cj4+Pj4gKwkJY2xvY2stbmFtZXMgPSAiYmF1ZGNsayIsICJhcGJfcGNs ayI7Cj4+Pj4gKwkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDk5IElSUV9UWVBFX0xFVkVMX0hJR0g+ Owo+Pj4+ICsJCXJlZy1zaGlmdCA9IDwyPjsKPj4+PiArCQlyZWctaW8td2lkdGggPSA8ND47Cj4+ Pj4gKwl9Owo+Pj4+IC0tCj4+Pj4gMS45LjEKPgo+Cj4KPgoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApM aW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 From: jay.xu@rock-chips.com (Jianqun Xu) Date: Fri, 19 Feb 2016 09:05:13 +0800 Subject: [PATCH 5/6] dt-bindings: add documentation of rk3399 clock controller In-Reply-To: <1758156.nKISImzkM9@phil> References: <1455673992-16469-1-git-send-email-jay.xu@rock-chips.com> <20160218143648.GL9654@rob-hp-laptop> <56C6664F.8070600@rock-chips.com> <1758156.nKISImzkM9@phil> Message-ID: <56C66A49.2080501@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Heiko ? 19/02/2016 08:53, Heiko Stuebner ??: > Am Freitag, 19. Februar 2016, 08:48:15 schrieb Jianqun Xu: >> Hi Rob >> >> ? 18/02/2016 22:36, Rob Herring ??: >>> On Wed, Feb 17, 2016 at 09:54:49AM +0800, jianqun.xu wrote: >>>> From: Xing Zheng >>>> >>>> Add the devicetree binding for the cru on the rk3399 which quite >>>> similar structured as previous clock controllers. >>>> >>>> Signed-off-by: Xing Zheng >>>> --- >>>> >>>> .../bindings/clock/rockchip,rk3399-cru.txt | 82 >>>> ++++++++++++++++++++++ 1 file changed, 82 insertions(+) >>>> create mode 100644 >>>> Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt >>>> b/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt new >>>> file mode 100644 >>>> index 0000000..07bcc6e >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt >>>> @@ -0,0 +1,82 @@ >>>> +* Rockchip RK3399 Clock and Reset Unit >>> >>> [...] >>> >>>> +Example: General Register Files >>>> + >>>> + pmugrf: syscon at ff320000 { >>>> + compatible = "rockchip,rk3399-pmugrf", "syscon"; >>> >>> Is this documented? >> >> Since there is no documentation for rockchip grf from early SoCs, I >> think if we need to add a new devicetree documentation, such as >> Documentation/devicetree/bindings/clock/rockchip,rk3399-grf.txt ? > > The grf is not clock-specific, so the directory is probably not correct. > I'd think bindings/arm/rockchip/grf.txt might be better or > bindings/soc/rockchip/grf.txt or somewhere else. And define the properties > for all per-soc GRFs in there. > > In any case we really should add the missing grf binding documentation (in a > separate patch of course), as the grf is a pretty commonly used shared > component. > Got it, I will add bindings/soc/rockchip/grf.txt in next patch Thanks ! > >> >> If you agree, I will add it in next patch >> >>>> + reg = <0x0 0xff320000 0x0 0x1000>; >>>> + }; >>>> + >>>> + grf: syscon at ff770000 { >>>> + compatible = "rockchip,rk3399-grf", "syscon"; >>> >>> ditto. >>> >>>> + reg = <0x0 0xff770000 0x0 0x10000>; >>>> + }; >>>> + >>>> +Example: Clock controller node: >>>> + >>>> + pmucru: pmu-clock-controller at ff750000 { >>>> + compatible = "rockchip,rk3399-pmucru"; >>>> + reg = <0x0 0xff750000 0x0 0x1000>; >>>> + #clock-cells = <1>; >>>> + #reset-cells = <1>; >>>> + }; >>>> + >>>> + cru: clock-controller at ff760000 { >>>> + compatible = "rockchip,rk3399-cru"; >>>> + reg = <0x0 0xff760000 0x0 0x1000>; >>>> + rockchip,grf = <&grf>; >>>> + #clock-cells = <1>; >>>> + #reset-cells = <1>; >>>> + }; >>>> + >>>> +Example: UART controller node that consumes the clock generated by the >>>> clock + controller: >>>> + >>>> + uart0: serial at ff1a0000 { >>>> + compatible = "rockchip,rk3399-uart", "snps,dw-apb-uart"; >>>> + reg = <0x0 0xff180000 0x0 0x100>; >>>> + clocks = <&cru SCLK_UART0>, <&cru PCLK_UART0>; >>>> + clock-names = "baudclk", "apb_pclk"; >>>> + interrupts = ; >>>> + reg-shift = <2>; >>>> + reg-io-width = <4>; >>>> + }; >>>> -- >>>> 1.9.1 > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948020AbcBSBF3 (ORCPT ); Thu, 18 Feb 2016 20:05:29 -0500 Received: from regular1.263xmail.com ([211.150.99.133]:41619 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1947496AbcBSBF1 (ORCPT ); Thu, 18 Feb 2016 20:05:27 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: jay.xu@rock-chips.com X-FST-TO: zhengxing@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: jay.xu@rock-chips.com X-UNIQUE-TAG: <0961882e0c785cf93e830b06af842c19> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 5/6] dt-bindings: add documentation of rk3399 clock controller To: Heiko Stuebner References: <1455673992-16469-1-git-send-email-jay.xu@rock-chips.com> <20160218143648.GL9654@rob-hp-laptop> <56C6664F.8070600@rock-chips.com> <1758156.nKISImzkM9@phil> Cc: Rob Herring , pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, jwerner@chromium.org, broonie@kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, sboyd@codeaurora.org, linus.walleij@linaro.org, sjoerd.simons@collabora.co.uk, huangtao@rock-chips.com, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Xing Zheng From: Jianqun Xu Message-ID: <56C66A49.2080501@rock-chips.com> Date: Fri, 19 Feb 2016 09:05:13 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1758156.nKISImzkM9@phil> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko ÔÚ 19/02/2016 08:53, Heiko Stuebner дµÀ: > Am Freitag, 19. Februar 2016, 08:48:15 schrieb Jianqun Xu: >> Hi Rob >> >> ÔÚ 18/02/2016 22:36, Rob Herring дµÀ: >>> On Wed, Feb 17, 2016 at 09:54:49AM +0800, jianqun.xu wrote: >>>> From: Xing Zheng >>>> >>>> Add the devicetree binding for the cru on the rk3399 which quite >>>> similar structured as previous clock controllers. >>>> >>>> Signed-off-by: Xing Zheng >>>> --- >>>> >>>> .../bindings/clock/rockchip,rk3399-cru.txt | 82 >>>> ++++++++++++++++++++++ 1 file changed, 82 insertions(+) >>>> create mode 100644 >>>> Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt >>>> b/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt new >>>> file mode 100644 >>>> index 0000000..07bcc6e >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt >>>> @@ -0,0 +1,82 @@ >>>> +* Rockchip RK3399 Clock and Reset Unit >>> >>> [...] >>> >>>> +Example: General Register Files >>>> + >>>> + pmugrf: syscon@ff320000 { >>>> + compatible = "rockchip,rk3399-pmugrf", "syscon"; >>> >>> Is this documented? >> >> Since there is no documentation for rockchip grf from early SoCs, I >> think if we need to add a new devicetree documentation, such as >> Documentation/devicetree/bindings/clock/rockchip,rk3399-grf.txt ? > > The grf is not clock-specific, so the directory is probably not correct. > I'd think bindings/arm/rockchip/grf.txt might be better or > bindings/soc/rockchip/grf.txt or somewhere else. And define the properties > for all per-soc GRFs in there. > > In any case we really should add the missing grf binding documentation (in a > separate patch of course), as the grf is a pretty commonly used shared > component. > Got it, I will add bindings/soc/rockchip/grf.txt in next patch Thanks ! > >> >> If you agree, I will add it in next patch >> >>>> + reg = <0x0 0xff320000 0x0 0x1000>; >>>> + }; >>>> + >>>> + grf: syscon@ff770000 { >>>> + compatible = "rockchip,rk3399-grf", "syscon"; >>> >>> ditto. >>> >>>> + reg = <0x0 0xff770000 0x0 0x10000>; >>>> + }; >>>> + >>>> +Example: Clock controller node: >>>> + >>>> + pmucru: pmu-clock-controller@ff750000 { >>>> + compatible = "rockchip,rk3399-pmucru"; >>>> + reg = <0x0 0xff750000 0x0 0x1000>; >>>> + #clock-cells = <1>; >>>> + #reset-cells = <1>; >>>> + }; >>>> + >>>> + cru: clock-controller@ff760000 { >>>> + compatible = "rockchip,rk3399-cru"; >>>> + reg = <0x0 0xff760000 0x0 0x1000>; >>>> + rockchip,grf = <&grf>; >>>> + #clock-cells = <1>; >>>> + #reset-cells = <1>; >>>> + }; >>>> + >>>> +Example: UART controller node that consumes the clock generated by the >>>> clock + controller: >>>> + >>>> + uart0: serial@ff1a0000 { >>>> + compatible = "rockchip,rk3399-uart", "snps,dw-apb-uart"; >>>> + reg = <0x0 0xff180000 0x0 0x100>; >>>> + clocks = <&cru SCLK_UART0>, <&cru PCLK_UART0>; >>>> + clock-names = "baudclk", "apb_pclk"; >>>> + interrupts = ; >>>> + reg-shift = <2>; >>>> + reg-io-width = <4>; >>>> + }; >>>> -- >>>> 1.9.1 > > > >