From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jianqun Xu Subject: Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi Date: Fri, 19 Feb 2016 10:44:42 +0800 Message-ID: <56C6819A.8090106@rock-chips.com> References: <1455762983-29980-1-git-send-email-jay.xu@rock-chips.com> <1455762983-29980-3-git-send-email-jay.xu@rock-chips.com> <20160218094108.GA7129@sirena.org.uk> <2327512.KAqs6H56Km@phil> <56C5959D.3030806@rock-chips.com> <20160218135751.GE7129@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160218135751.GE7129-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: Heiko Stuebner , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, jwerner-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org, huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rockchip.vger.kernel.org Hi Mark =D4=DA 18/02/2016 21:57, Mark Brown =D0=B4=B5=C0: > On Thu, Feb 18, 2016 at 05:57:49PM +0800, Jianqun Xu wrote: > >> I'm a little confuse, I have upstreamed rockchip-i2s, and the i2s dr= iver set >> the compatible like: >> - compatible: should be one of the followings >> - "rockchip,rk3066-i2s": for rk3066 >> - "rockchip,rk3188-i2s", "rockchip,rk3066-i2s": for rk3188 >> - "rockchip,rk3288-i2s", "rockchip,rk3066-i2s": for rk3288 >> - "rockchip,rk3399-i2s", "rockchip,rk3066-i2s": for rk3399 >> and the driver only has >> static const struct of_device_id rockchip_i2s_match[] =3D { >> { .compatible =3D "rockchip,rk3066-i2s", }, >> {}, >> }; > >> The spi of rk3399 as same as rk3066, rk3188, rk3288, like i2s, if th= ey are >> keep different rules ? > > No, that's just something that got missed in review and which should = be > fixed. > Got it, it's will be fixed in a separate patch later, thank you very mu= ch. -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: jay.xu@rock-chips.com (Jianqun Xu) Date: Fri, 19 Feb 2016 10:44:42 +0800 Subject: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi In-Reply-To: <20160218135751.GE7129@sirena.org.uk> References: <1455762983-29980-1-git-send-email-jay.xu@rock-chips.com> <1455762983-29980-3-git-send-email-jay.xu@rock-chips.com> <20160218094108.GA7129@sirena.org.uk> <2327512.KAqs6H56Km@phil> <56C5959D.3030806@rock-chips.com> <20160218135751.GE7129@sirena.org.uk> Message-ID: <56C6819A.8090106@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark ? 18/02/2016 21:57, Mark Brown ??: > On Thu, Feb 18, 2016 at 05:57:49PM +0800, Jianqun Xu wrote: > >> I'm a little confuse, I have upstreamed rockchip-i2s, and the i2s driver set >> the compatible like: >> - compatible: should be one of the followings >> - "rockchip,rk3066-i2s": for rk3066 >> - "rockchip,rk3188-i2s", "rockchip,rk3066-i2s": for rk3188 >> - "rockchip,rk3288-i2s", "rockchip,rk3066-i2s": for rk3288 >> - "rockchip,rk3399-i2s", "rockchip,rk3066-i2s": for rk3399 >> and the driver only has >> static const struct of_device_id rockchip_i2s_match[] = { >> { .compatible = "rockchip,rk3066-i2s", }, >> {}, >> }; > >> The spi of rk3399 as same as rk3066, rk3188, rk3288, like i2s, if they are >> keep different rules ? > > No, that's just something that got missed in review and which should be > fixed. > Got it, it's will be fixed in a separate patch later, thank you very much. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992726AbcBSCo7 (ORCPT ); Thu, 18 Feb 2016 21:44:59 -0500 Received: from regular1.263xmail.com ([211.150.99.139]:35622 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992711AbcBSCo5 (ORCPT ); Thu, 18 Feb 2016 21:44:57 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: jay.xu@rock-chips.com X-FST-TO: devicetree@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: jay.xu@rock-chips.com X-UNIQUE-TAG: <76311d18166db3e4f01659b6c8b79bef> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi To: Mark Brown References: <1455762983-29980-1-git-send-email-jay.xu@rock-chips.com> <1455762983-29980-3-git-send-email-jay.xu@rock-chips.com> <20160218094108.GA7129@sirena.org.uk> <2327512.KAqs6H56Km@phil> <56C5959D.3030806@rock-chips.com> <20160218135751.GE7129@sirena.org.uk> Cc: Heiko Stuebner , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, jwerner@chromium.org, catalin.marinas@arm.com, will.deacon@arm.com, sboyd@codeaurora.org, linus.walleij@linaro.org, sjoerd.simons@collabora.co.uk, huangtao@rock-chips.com, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org From: Jianqun Xu Message-ID: <56C6819A.8090106@rock-chips.com> Date: Fri, 19 Feb 2016 10:44:42 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160218135751.GE7129@sirena.org.uk> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark ÔÚ 18/02/2016 21:57, Mark Brown дµÀ: > On Thu, Feb 18, 2016 at 05:57:49PM +0800, Jianqun Xu wrote: > >> I'm a little confuse, I have upstreamed rockchip-i2s, and the i2s driver set >> the compatible like: >> - compatible: should be one of the followings >> - "rockchip,rk3066-i2s": for rk3066 >> - "rockchip,rk3188-i2s", "rockchip,rk3066-i2s": for rk3188 >> - "rockchip,rk3288-i2s", "rockchip,rk3066-i2s": for rk3288 >> - "rockchip,rk3399-i2s", "rockchip,rk3066-i2s": for rk3399 >> and the driver only has >> static const struct of_device_id rockchip_i2s_match[] = { >> { .compatible = "rockchip,rk3066-i2s", }, >> {}, >> }; > >> The spi of rk3399 as same as rk3066, rk3188, rk3288, like i2s, if they are >> keep different rules ? > > No, that's just something that got missed in review and which should be > fixed. > Got it, it's will be fixed in a separate patch later, thank you very much.