All of lore.kernel.org
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.vnet.ibm.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	"Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
	frankja@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v2] scripts/kvm/kvm_stat: Fix missing right parantheses and ".format(...)"
Date: Fri, 19 Feb 2016 08:23:57 +0100	[thread overview]
Message-ID: <56C6C30D.2030604@linux.vnet.ibm.com> (raw)
In-Reply-To: <1455848416-13177-1-git-send-email-famz@redhat.com>

On 02/19/2016 03:20 AM, Fam Zheng wrote:
> They seem to have snuck in when applying Janosch Frank
> <frankja@linux.vnet.ibm.com>'s previous patch.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> 
> ---
> v2: Also fix .format. [Janosch]
> ---
>  scripts/kvm/kvm_stat | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
> index 3cf1181..769d884 100755
> --- a/scripts/kvm/kvm_stat
> +++ b/scripts/kvm/kvm_stat
> @@ -796,11 +796,12 @@ def check_access(options):
>          sys.stderr.write("Please enable CONFIG_TRACING in your kernel "
>                           "when using the option -t (default).\n"
>                           "If it is enabled, make {0} readable by the "
> -                         "current user.\n")
> +                         "current user.\n"
> +                         .format(PATH_DEBUGFS_TRACING))
>          if options.tracepoints:
>              sys.exit(1)
> 
> -        sys.stderr.write("Falling back to debugfs statistics!\n"
> +        sys.stderr.write("Falling back to debugfs statistics!\n")
>          options.debugfs = True
>          sleep(5)
> 
Reviewed-by: Janosch Frank <frankja@linux.vnet.ibm.com>
Tested-by: Janosch Frank <frankja@linux.vnet.ibm.com>

Thanks

  reply	other threads:[~2016-02-19  7:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-19  2:20 [Qemu-devel] [PATCH v2] scripts/kvm/kvm_stat: Fix missing right parantheses and ".format(...)" Fam Zheng
2016-02-19  7:23 ` Janosch Frank [this message]
2016-02-22 17:29 ` Stefan Hajnoczi
2016-02-22 17:40   ` Paolo Bonzini
2016-02-25 11:22     ` Stefan Hajnoczi
2016-02-22 17:40 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C6C30D.2030604@linux.vnet.ibm.com \
    --to=frankja@linux.vnet.ibm.com \
    --cc=famz@redhat.com \
    --cc=jjherne@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.