From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keerthy Subject: Re: [PATCH v2 2/2] ARM: AM43XX: HWMOD: Add rtc hwmod Date: Fri, 19 Feb 2016 13:29:23 +0530 Message-ID: <56C6CB5B.20804@ti.com> References: <1455856735-11515-1-git-send-email-j-keerthy@ti.com> <1455856735-11515-3-git-send-email-j-keerthy@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Paul Walmsley , Keerthy Cc: devicetree@vger.kernel.org, tony@atomide.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org On Friday 19 February 2016 12:51 PM, Paul Walmsley wrote: > On Fri, 19 Feb 2016, Keerthy wrote: > >> The patch adds rtc hwmod. RTC module The RTC module is physically >> present on the AM438x SoC used on AM43X-EPOS-EVM, but it is permanently >> disabled. A secure RTC is used instead on these devices, where needed. >> . Hence adding it selectively using a seprate list to get RTC Module >> functional on the other am43x SoCs used on am437x-gp-evm and >> am437x-sk-evm. >> >> Signed-off-by: Keerthy >> --- >> >> Changes in v2: >> >> Inverted the checking logic to accommodate registering for all >> the SoCs compatible to am4372 and removed the negating am438x logic >> to register rtc hwmods as suggested by Paul. >> >> arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) > > OK thanks; I've queued the following patch for v4.6 or if I get unlucky, > v4.7. Thanks Paul! > > - Paul > > From: Keerthy > Date: Fri, 19 Feb 2016 10:08:55 +0530 > Subject: [PATCH] ARM: AM43XX: hwmod: Add rtc hwmod > > The patch registers the rtc hwmod on AM437x chips. The RTC module is > physically present on the AM438x SoC used on AM43X-EPOS-EVM, but it is > permanently disabled. A secure RTC is used instead on these devices, > where needed. Hence adding it selectively using a separate list to get > RTC Module functional on the other am43x SoCs used on am437x-gp-evm > and am437x-sk-evm. > > Signed-off-by: Keerthy > [paul@pwsan.com: cleaned up patch description] > Signed-off-by: Paul Walmsley > --- > arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c > index e97a894b5f88..97fd399202dc 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c > @@ -1020,9 +1020,21 @@ static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] __initdata = { > NULL, > }; > > +static struct omap_hwmod_ocp_if *am43xx_rtc_hwmod_ocp_ifs[] __initdata = { > + &am33xx_l4_wkup__rtc, > + NULL, > +}; > + > int __init am43xx_hwmod_init(void) > { > + int ret; > + > omap_hwmod_am43xx_reg(); > omap_hwmod_init(); > - return omap_hwmod_register_links(am43xx_hwmod_ocp_ifs); > + ret = omap_hwmod_register_links(am43xx_hwmod_ocp_ifs); > + > + if (!ret && of_machine_is_compatible("ti,am4372")) > + ret = omap_hwmod_register_links(am43xx_rtc_hwmod_ocp_ifs); > + > + return ret; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 From: a0393675@ti.com (Keerthy) Date: Fri, 19 Feb 2016 13:29:23 +0530 Subject: [PATCH v2 2/2] ARM: AM43XX: HWMOD: Add rtc hwmod In-Reply-To: References: <1455856735-11515-1-git-send-email-j-keerthy@ti.com> <1455856735-11515-3-git-send-email-j-keerthy@ti.com> Message-ID: <56C6CB5B.20804@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 19 February 2016 12:51 PM, Paul Walmsley wrote: > On Fri, 19 Feb 2016, Keerthy wrote: > >> The patch adds rtc hwmod. RTC module The RTC module is physically >> present on the AM438x SoC used on AM43X-EPOS-EVM, but it is permanently >> disabled. A secure RTC is used instead on these devices, where needed. >> . Hence adding it selectively using a seprate list to get RTC Module >> functional on the other am43x SoCs used on am437x-gp-evm and >> am437x-sk-evm. >> >> Signed-off-by: Keerthy >> --- >> >> Changes in v2: >> >> Inverted the checking logic to accommodate registering for all >> the SoCs compatible to am4372 and removed the negating am438x logic >> to register rtc hwmods as suggested by Paul. >> >> arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) > > OK thanks; I've queued the following patch for v4.6 or if I get unlucky, > v4.7. Thanks Paul! > > - Paul > > From: Keerthy > Date: Fri, 19 Feb 2016 10:08:55 +0530 > Subject: [PATCH] ARM: AM43XX: hwmod: Add rtc hwmod > > The patch registers the rtc hwmod on AM437x chips. The RTC module is > physically present on the AM438x SoC used on AM43X-EPOS-EVM, but it is > permanently disabled. A secure RTC is used instead on these devices, > where needed. Hence adding it selectively using a separate list to get > RTC Module functional on the other am43x SoCs used on am437x-gp-evm > and am437x-sk-evm. > > Signed-off-by: Keerthy > [paul at pwsan.com: cleaned up patch description] > Signed-off-by: Paul Walmsley > --- > arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c > index e97a894b5f88..97fd399202dc 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c > @@ -1020,9 +1020,21 @@ static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] __initdata = { > NULL, > }; > > +static struct omap_hwmod_ocp_if *am43xx_rtc_hwmod_ocp_ifs[] __initdata = { > + &am33xx_l4_wkup__rtc, > + NULL, > +}; > + > int __init am43xx_hwmod_init(void) > { > + int ret; > + > omap_hwmod_am43xx_reg(); > omap_hwmod_init(); > - return omap_hwmod_register_links(am43xx_hwmod_ocp_ifs); > + ret = omap_hwmod_register_links(am43xx_hwmod_ocp_ifs); > + > + if (!ret && of_machine_is_compatible("ti,am4372")) > + ret = omap_hwmod_register_links(am43xx_rtc_hwmod_ocp_ifs); > + > + return ret; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933149AbcBSIA1 (ORCPT ); Fri, 19 Feb 2016 03:00:27 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:47212 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756738AbcBSH77 (ORCPT ); Fri, 19 Feb 2016 02:59:59 -0500 Subject: Re: [PATCH v2 2/2] ARM: AM43XX: HWMOD: Add rtc hwmod To: Paul Walmsley , Keerthy References: <1455856735-11515-1-git-send-email-j-keerthy@ti.com> <1455856735-11515-3-git-send-email-j-keerthy@ti.com> CC: , , , , , From: Keerthy Message-ID: <56C6CB5B.20804@ti.com> Date: Fri, 19 Feb 2016 13:29:23 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 19 February 2016 12:51 PM, Paul Walmsley wrote: > On Fri, 19 Feb 2016, Keerthy wrote: > >> The patch adds rtc hwmod. RTC module The RTC module is physically >> present on the AM438x SoC used on AM43X-EPOS-EVM, but it is permanently >> disabled. A secure RTC is used instead on these devices, where needed. >> . Hence adding it selectively using a seprate list to get RTC Module >> functional on the other am43x SoCs used on am437x-gp-evm and >> am437x-sk-evm. >> >> Signed-off-by: Keerthy >> --- >> >> Changes in v2: >> >> Inverted the checking logic to accommodate registering for all >> the SoCs compatible to am4372 and removed the negating am438x logic >> to register rtc hwmods as suggested by Paul. >> >> arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) > > OK thanks; I've queued the following patch for v4.6 or if I get unlucky, > v4.7. Thanks Paul! > > - Paul > > From: Keerthy > Date: Fri, 19 Feb 2016 10:08:55 +0530 > Subject: [PATCH] ARM: AM43XX: hwmod: Add rtc hwmod > > The patch registers the rtc hwmod on AM437x chips. The RTC module is > physically present on the AM438x SoC used on AM43X-EPOS-EVM, but it is > permanently disabled. A secure RTC is used instead on these devices, > where needed. Hence adding it selectively using a separate list to get > RTC Module functional on the other am43x SoCs used on am437x-gp-evm > and am437x-sk-evm. > > Signed-off-by: Keerthy > [paul@pwsan.com: cleaned up patch description] > Signed-off-by: Paul Walmsley > --- > arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c > index e97a894b5f88..97fd399202dc 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c > @@ -1020,9 +1020,21 @@ static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] __initdata = { > NULL, > }; > > +static struct omap_hwmod_ocp_if *am43xx_rtc_hwmod_ocp_ifs[] __initdata = { > + &am33xx_l4_wkup__rtc, > + NULL, > +}; > + > int __init am43xx_hwmod_init(void) > { > + int ret; > + > omap_hwmod_am43xx_reg(); > omap_hwmod_init(); > - return omap_hwmod_register_links(am43xx_hwmod_ocp_ifs); > + ret = omap_hwmod_register_links(am43xx_hwmod_ocp_ifs); > + > + if (!ret && of_machine_is_compatible("ti,am4372")) > + ret = omap_hwmod_register_links(am43xx_rtc_hwmod_ocp_ifs); > + > + return ret; > } >