From: Samuli Piippo <samuli.piippo@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-qt5][PATCH] qt5: use common PACKAGECONFIG to build examples
Date: Fri, 19 Feb 2016 10:06:29 +0200 [thread overview]
Message-ID: <56C6CD05.7070300@gmail.com> (raw)
In-Reply-To: <CAP9ODKo9D=V8w1-oJmz605VsDWGtFJ=1raD+35yeSJCkRt-TSw@mail.gmail.com>
On 04.02.2016 13:19, Otavio Salvador wrote:
> On Wed, Feb 3, 2016 at 1:12 PM, Samuli Piippo
> <samuli.piippo@theqtcompany.com> wrote:
>> Each Qt module's examples can now be enabled with PACKAGECONFIG.
>> Replace the webkit patch with a PACKAGECONFIG option and follow
>> common practice by not building QtWayland examples by default,
>> those can be enabled in a .bbappend with PACKAGECONFIG += "examples"
>>
>> Enabling PACKAGECONFIG[examples] in qtbase, will still cause every
>> Qt module to build their examples.
>>
>> Signed-off-by: Samuli Piippo <samuli.piippo@theqtcompany.com>
>
> Acked-by: Otavio Salvador <otavio@ossystems.com.br>
>
> I think in a subsequent patch, examples should all to be disabled by
> default. What do you think?
>
Sorry, I don't follow. QtWayland is the only module that has examples
built by default, and this disables those as well.
Is there anything that's needed in a subsequent patch?
next prev parent reply other threads:[~2016-02-19 8:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 15:12 [meta-qt5][PATCH] qt5: use common PACKAGECONFIG to build examples Samuli Piippo
2016-02-04 11:19 ` Otavio Salvador
2016-02-19 8:06 ` Samuli Piippo [this message]
2016-02-19 11:39 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C6CD05.7070300@gmail.com \
--to=samuli.piippo@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.