From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1427495AbcBSN1Z (ORCPT ); Fri, 19 Feb 2016 08:27:25 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:58931 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1426692AbcBSN1Y (ORCPT ); Fri, 19 Feb 2016 08:27:24 -0500 X-IronPort-AV: E=Sophos;i="5.22,470,1449532800"; d="scan'208";a="339407522" Subject: Re: [Xen-devel] [PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check To: "Luis R. Rodriguez" , References: <1455887316-9223-1-git-send-email-mcgrof@kernel.org> <1455887316-9223-9-git-send-email-mcgrof@kernel.org> CC: , , , , , , From: David Vrabel Message-ID: <56C71839.3090609@citrix.com> Date: Fri, 19 Feb 2016 13:27:21 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <1455887316-9223-9-git-send-email-mcgrof@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/02/16 13:08, Luis R. Rodriguez wrote: > The current check is a super long winded way of asking if this > is on lguest. The flags is used for legacy features, this is > likely inspired by the ACPI IA-PC boot architecture flags, where > as for RTC it annotates No CMOS real-time clock present. I don't > expect we will be implementing more legacy features, its simply > pointless so just remove this legacy flag feature thing as well. No. This check is needed for Xen PV domU guests and without it PV guests don't get a console (as I think the history of the change that introduced this makes clear). I think this trend towards a coarse-grained subarch instead of a set of feature bits is the wrong direction. David