From mboxrd@z Thu Jan  1 00:00:00 1970
From: Doug Goldstein <cardoe@cardoe.com>
Subject: Re: [PATCH v2 1/4] tools/configure: only require
 bcc/ld86/as86 when needed
Date: Fri, 19 Feb 2016 08:27:21 -0600
Message-ID: <56C72649.4090905@cardoe.com>
References: <1455850625-9624-1-git-send-email-cardoe@cardoe.com>
	<20160219140036.GB31079@localhost.localdomain>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6061136677463832351=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20160219140036.GB31079@localhost.localdomain>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--===============6061136677463832351==
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="XCvL54xoRX3fxWVIIVrbMEA2wsSpUJKqO"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--XCvL54xoRX3fxWVIIVrbMEA2wsSpUJKqO
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On 2/19/16 8:00 AM, Konrad Rzeszutek Wilk wrote:
> On Thu, Feb 18, 2016 at 08:57:02PM -0600, Doug Goldstein wrote:
>> bcc/ld86/as86 are only necessary when we build rombios and not always =
so
>> failing the build when they aren't available should not happen if the
>> user isn't building rombios.
>=20
> That is quite the long sentence. Perhaps trim it down to:
>=20
> "are necessary when we build ROMBIOS. However if we do not build it=20
> (not building qemu-trad) - the build requirements are overly strict
> and can lead to failures." ?
>=20
> Otherwise
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>=20

Agreed. That's better. Thank you for the review.


--=20
Doug Goldstein


--XCvL54xoRX3fxWVIIVrbMEA2wsSpUJKqO
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0

iQJ8BAEBCgBmBQJWxyZLXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB
MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUyLoP/iXNU2A3uKuOWz7/zWLjMYoi
/64Z6tVbDrTgEOAv6jHJYMeFytD22z2STKml8SUMvJlVtfUmzihlagBOIwXyiAIR
XwP98/NqBHw1qfI2D9zc56Pf6BHn9brhPedSE0+u2KHoT1FwYs3k7zfBCQqqXYzm
sOOJMQCE/fF0MwJ4ug9xioBZAAiGZm5DgT6IITbODEnhE3bnTcjZa6aBBiUukFL+
QbjRZZPXAyRHkmNBtKRDw5Ua6Czmz2/PILv2cRVJ78mH2AFoByMsF92c4bMz3o85
jcod1ICdIShjkSrl6UDL4/7jTlEWSAHmDL7b0pCdjVZADq43Ki3NyP8nVQJZfc/X
gfqbF0QC3v9ZSwHDhLUMmOGX03DaXBymErXxIcJqUbq6gmwIPgVqpS2A/ZX9kRA8
fWVuGnYbhBn2h6kotv2C9TS+aabNyY438n3RwyLGGEVLyUpFe+5e0smayoUDypSi
zY6NpPZr4EQFm0QtNtZHGngf/EZTElFfcbB35tVyM6n9czql+JIpM6Da4XXAPvHd
EgQDiDHD3uKl1CsFVkvrUKaAhT1Sd620bpDuaNfeX4h9jBHIC8BIskcshNAGwru2
GBYcn+84dIspMLJuoOe8ETRpkoZFGJYSThKpOwG4epEuT54CUwDFntk09vKOYNpB
OBLFhusugMzsgCtxTO9K
=cwiB
-----END PGP SIGNATURE-----

--XCvL54xoRX3fxWVIIVrbMEA2wsSpUJKqO--


--===============6061136677463832351==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============6061136677463832351==--