All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/8] block-migration: acquire AioContext as necessary
Date: Fri, 19 Feb 2016 16:02:50 +0100	[thread overview]
Message-ID: <56C72E9A.5000109@redhat.com> (raw)
In-Reply-To: <20160216071711.GI18664@ad.usersys.redhat.com>



On 16/02/2016 08:17, Fam Zheng wrote:
>> @@ -321,8 +339,9 @@ static int set_dirty_tracking(void)
>>      int ret;
>>  
>>      QSIMPLEQ_FOREACH(bmds, &block_mig_state.bmds_list, entry) {
>> +        /* Creating/dropping dirty bitmaps only requires the big QEMU lock.  */
> 
> Why? I don't think it is safe today.  The BDS state is mutated and it can race
> with bdrv_set_dirty() etc.

You're completely right.

> (Also the refresh_total_sectors in bdrv_nb_sectors
> can even do read/write, no?)

refresh_total_sectors will just do a lseek(SEEK_END) basically.  So
that's safe.

Paolo

  parent reply	other threads:[~2016-02-19 15:03 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-14 17:17 [Qemu-devel] [PATCH 0/8] virtio: allow migration with dataplane Paolo Bonzini
2016-02-14 17:17 ` [Qemu-devel] [PATCH 1/8] block-migration: acquire AioContext as necessary Paolo Bonzini
2016-02-16  7:17   ` Fam Zheng
2016-02-19  7:41     ` Michael S. Tsirkin
2016-02-19 15:02     ` Paolo Bonzini [this message]
2016-02-14 17:17 ` [Qemu-devel] [PATCH 2/8] vring: make vring_enable_notification return void Paolo Bonzini
2016-02-15 16:24   ` Cornelia Huck
2016-02-16  7:18   ` Fam Zheng
2016-02-14 17:17 ` [Qemu-devel] [PATCH 3/8] virtio: add AioContext-specific function for host notifiers Paolo Bonzini
2016-02-16  7:20   ` Fam Zheng
2016-02-16  9:42     ` Cornelia Huck
2016-02-14 17:17 ` [Qemu-devel] [PATCH 4/8] virtio: export vring_notify as virtio_should_notify Paolo Bonzini
2016-02-15 16:44   ` Cornelia Huck
2016-02-16  7:21   ` Fam Zheng
2016-02-14 17:17 ` [Qemu-devel] [PATCH 5/8] virtio-blk: fix "disabled data plane" mode Paolo Bonzini
2016-02-15 17:58   ` Cornelia Huck
2016-02-16 15:45     ` Paolo Bonzini
2016-02-16 16:15       ` Cornelia Huck
2016-02-16 16:29         ` Paolo Bonzini
2016-02-16  7:26   ` Fam Zheng
2016-03-09 12:21   ` Christian Borntraeger
2016-03-09 12:55     ` Paolo Bonzini
2016-03-09 13:02       ` Christian Borntraeger
2016-03-09 13:05         ` Christian Borntraeger
2016-03-09 13:12           ` Cornelia Huck
2016-03-09 14:29       ` Christian Borntraeger
2016-03-09 16:17         ` Paolo Bonzini
2016-03-10  1:51           ` Fam Zheng
2016-03-10  9:03             ` Christian Borntraeger
2016-03-10  9:40               ` Christian Borntraeger
2016-03-11 10:28                 ` Paolo Bonzini
2016-03-14  9:18                   ` tu bo
2016-03-15 12:45                   ` Fam Zheng
2016-03-15 13:18                     ` Cornelia Huck
2016-03-15 14:08                       ` Paolo Bonzini
2016-03-15 23:34                         ` Fam Zheng
2016-03-16  5:21                     ` tu bo
2016-02-14 17:17 ` [Qemu-devel] [PATCH 6/8] virtio-blk: do not use vring in dataplane Paolo Bonzini
2016-02-16  8:15   ` Fam Zheng
2016-02-14 17:17 ` [Qemu-devel] [PATCH 7/8] virtio-scsi: " Paolo Bonzini
2016-02-16  8:28   ` Fam Zheng
2016-02-14 17:17 ` [Qemu-devel] [PATCH 8/8] vring: remove Paolo Bonzini
2016-02-16  8:32   ` Fam Zheng
2016-02-16  8:57 ` [Qemu-devel] [PATCH 0/8] virtio: allow migration with dataplane Christian Borntraeger
2016-02-16 16:25   ` Paolo Bonzini
2016-02-19  7:42 ` Michael S. Tsirkin
2016-02-19 14:59   ` Paolo Bonzini
2016-02-22 16:01 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C72E9A.5000109@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=famz@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.