From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426157AbcBSPkK (ORCPT ); Fri, 19 Feb 2016 10:40:10 -0500 Received: from smtp.citrix.com ([66.165.176.89]:27581 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422908AbcBSPkI (ORCPT ); Fri, 19 Feb 2016 10:40:08 -0500 X-IronPort-AV: E=Sophos;i="5.22,471,1449532800"; d="scan'208";a="332902554" Subject: Re: [PATCH] xen/blback: Fit the important information of the thread in 17 characters To: Konrad Rzeszutek Wilk , , References: <1455726686-23091-1-git-send-email-konrad.wilk@oracle.com> From: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Message-ID: <56C73754.1080303@citrix.com> Date: Fri, 19 Feb 2016 16:40:04 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1455726686-23091-1-git-send-email-konrad.wilk@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org El 17/2/16 a les 17:31, Konrad Rzeszutek Wilk ha escrit: > The processes names are truncated to 17, while we had the length > of the process as name 20 - which meant that while we filled > it out with various details - the last 3 characters (which had > the queue number) never surfaced to the user-space. > > To simplify this and be able to fit the device name, domain id, > and the queue number we remove the 'blkback' from the name. > > Prior to this patch the device name is "blkback.." > for example: blkback.8.xvda, blkback.11.hda. > > With the multiqueue block backend we add "-%d" for the queue. > But sadly this is already way past the limit so it gets stripped. > > Possible solution had been identified by Ian: > http://lists.xenproject.org/archives/html/xen-devel/2015-05/msg03516.html > > " > If you are pressed for space then the "xvd" is probably a bit redundant > in a string which starts blkbk. > > The guest may not even call the device xvdN (iirc BSD has another > prefix) any how, so having blkback say so seems of limited use anyway. > > Since this seems to not include a partition number how does this work in > the split partition scheme? (i.e. one where the guest is given xvda1 and > xvda2 rather than xvda with a partition table) > > [It will be 'blkback.8.xvda1', and 'blkback.11.xvda2'] > > Perhaps something derived from one of the schemes in > http://xenbits.xen.org/docs/unstable/misc/vbd-interface.txt might be a > better fit? > > After a bit of discussion (see > http://lists.xenproject.org/archives/html/xen-devel/2015-12/msg01588.html) > we settled on dropping the "blback" part. > > This will make it possible to have the .-: > > [1.xvda-0] > [1.xvda-1] > > And we enough space to make it go up to: > > [32100.xvdfg9-5] > > Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Roger Pau Monné According to: http://lists.xenproject.org/archives/html/xen-devel/2015-05/msg03505.html Should this have a: Reported-by: Jan Beulich Thanks!