From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH v3 05/10] serial: mps2-uart: add support for early console Date: Fri, 19 Feb 2016 07:46:57 -0800 Message-ID: <56C738F1.2070307@hurleysoftware.com> References: <1455617295-23736-1-git-send-email-vladimir.murzin@arm.com> <1455617295-23736-6-git-send-email-vladimir.murzin@arm.com> <56C31F9F.10000@arm.com> <56C6E42E.5070601@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Shevchenko , Vladimir Murzin Cc: Mark Rutland , devicetree , Russell King , Pawel Moll , Arnd Bergmann , ijc+devicetree , Greg Kroah-Hartman , Daniel Lezcano , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rob Herring , Kumar Gala , "linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Thomas Gleixner , "linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jiri Slaby , linux-arm Mailing List List-Id: linux-api@vger.kernel.org On 02/19/2016 01:57 AM, Andy Shevchenko wrote: > On Fri, Feb 19, 2016 at 11:45 AM, Vladimir Murzin > wrote: >> On 16/02/16 13:09, Vladimir Murzin wrote: >>>>> +EARLYCON_DECLARE(mps2, mps2_early_console_setup); >>>>>>> +OF_EARLYCON_DECLARE(mps2, "arm,mps2-uart", mps2_early_console_setup); >>>>> >>>>> IIRC Peter Hurley mentioned you don't need to put both anymore, OF_ >>>>> one is enough. >>>>> >>> I've just tried with OF_ only and seems it works fine. Thanks for >>> pointing at it! >>> >> >> ..and the reason for that was that I had stdout pointing at uart node. >> Now, while testing v4 I end-up with configuration: >> >> 1) no EARLYCON_DECLARE in mps2-uart.c >> 2) stdout not set >> 3) cmdline has "earlycon=mps2,0x40004000 console=/dev/ttyMPS" >> >> and I don't see bootconsole, but if I avoid 1) everything works fine. >> So, I'd leave EARLYCON_DECLARE in this patch. > > Peter, what is your comment on this? That Vladimir is not testing with linux-next. linux-next has common framework for both command line and OF-defined earlycons. Vladimir, if you pull in Greg's tty-next branch, then just OF_EARLYCON_DECLARE(mps2, "arm,mps2-uart", mps2_early_console_setup); should enable both command-line and OF-defined earlycons. Regards, Peter Hurley From mboxrd@z Thu Jan 1 00:00:00 1970 From: peter@hurleysoftware.com (Peter Hurley) Date: Fri, 19 Feb 2016 07:46:57 -0800 Subject: [PATCH v3 05/10] serial: mps2-uart: add support for early console In-Reply-To: References: <1455617295-23736-1-git-send-email-vladimir.murzin@arm.com> <1455617295-23736-6-git-send-email-vladimir.murzin@arm.com> <56C31F9F.10000@arm.com> <56C6E42E.5070601@arm.com> Message-ID: <56C738F1.2070307@hurleysoftware.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/19/2016 01:57 AM, Andy Shevchenko wrote: > On Fri, Feb 19, 2016 at 11:45 AM, Vladimir Murzin > wrote: >> On 16/02/16 13:09, Vladimir Murzin wrote: >>>>> +EARLYCON_DECLARE(mps2, mps2_early_console_setup); >>>>>>> +OF_EARLYCON_DECLARE(mps2, "arm,mps2-uart", mps2_early_console_setup); >>>>> >>>>> IIRC Peter Hurley mentioned you don't need to put both anymore, OF_ >>>>> one is enough. >>>>> >>> I've just tried with OF_ only and seems it works fine. Thanks for >>> pointing at it! >>> >> >> ..and the reason for that was that I had stdout pointing at uart node. >> Now, while testing v4 I end-up with configuration: >> >> 1) no EARLYCON_DECLARE in mps2-uart.c >> 2) stdout not set >> 3) cmdline has "earlycon=mps2,0x40004000 console=/dev/ttyMPS" >> >> and I don't see bootconsole, but if I avoid 1) everything works fine. >> So, I'd leave EARLYCON_DECLARE in this patch. > > Peter, what is your comment on this? That Vladimir is not testing with linux-next. linux-next has common framework for both command line and OF-defined earlycons. Vladimir, if you pull in Greg's tty-next branch, then just OF_EARLYCON_DECLARE(mps2, "arm,mps2-uart", mps2_early_console_setup); should enable both command-line and OF-defined earlycons. Regards, Peter Hurley From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1427187AbcBSPrG (ORCPT ); Fri, 19 Feb 2016 10:47:06 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:36524 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1427073AbcBSPrC (ORCPT ); Fri, 19 Feb 2016 10:47:02 -0500 Subject: Re: [PATCH v3 05/10] serial: mps2-uart: add support for early console To: Andy Shevchenko , Vladimir Murzin References: <1455617295-23736-1-git-send-email-vladimir.murzin@arm.com> <1455617295-23736-6-git-send-email-vladimir.murzin@arm.com> <56C31F9F.10000@arm.com> <56C6E42E.5070601@arm.com> Cc: Mark Rutland , devicetree , Russell King , Pawel Moll , Arnd Bergmann , ijc+devicetree , Greg Kroah-Hartman , Daniel Lezcano , "linux-kernel@vger.kernel.org" , Rob Herring , Kumar Gala , "linux-serial@vger.kernel.org" , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Thomas Gleixner , "linux-api@vger.kernel.org" , Jiri Slaby , linux-arm Mailing List From: Peter Hurley Message-ID: <56C738F1.2070307@hurleysoftware.com> Date: Fri, 19 Feb 2016 07:46:57 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/19/2016 01:57 AM, Andy Shevchenko wrote: > On Fri, Feb 19, 2016 at 11:45 AM, Vladimir Murzin > wrote: >> On 16/02/16 13:09, Vladimir Murzin wrote: >>>>> +EARLYCON_DECLARE(mps2, mps2_early_console_setup); >>>>>>> +OF_EARLYCON_DECLARE(mps2, "arm,mps2-uart", mps2_early_console_setup); >>>>> >>>>> IIRC Peter Hurley mentioned you don't need to put both anymore, OF_ >>>>> one is enough. >>>>> >>> I've just tried with OF_ only and seems it works fine. Thanks for >>> pointing at it! >>> >> >> ..and the reason for that was that I had stdout pointing at uart node. >> Now, while testing v4 I end-up with configuration: >> >> 1) no EARLYCON_DECLARE in mps2-uart.c >> 2) stdout not set >> 3) cmdline has "earlycon=mps2,0x40004000 console=/dev/ttyMPS" >> >> and I don't see bootconsole, but if I avoid 1) everything works fine. >> So, I'd leave EARLYCON_DECLARE in this patch. > > Peter, what is your comment on this? That Vladimir is not testing with linux-next. linux-next has common framework for both command line and OF-defined earlycons. Vladimir, if you pull in Greg's tty-next branch, then just OF_EARLYCON_DECLARE(mps2, "arm,mps2-uart", mps2_early_console_setup); should enable both command-line and OF-defined earlycons. Regards, Peter Hurley