From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] arm/monitor vm-events: Implement
	guest-request support
Date: Fri, 19 Feb 2016 16:05:49 +0000
Message-ID: <56C73D5D.3080903@citrix.com>
References: <1455824116-13783-1-git-send-email-czuzu@bitdefender.com>
	<alpine.DEB.2.02.1602191324120.17248@kaball.uk.xensource.com>
	<56C73B22.1060702@bitdefender.com>
	<alpine.DEB.2.02.1602191559390.17248@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1602191559390.17248@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Corneliu ZUZU <czuzu@bitdefender.com>
Cc: Tamas K Lengyel <tamas@tklengyel.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Razvan Cojocaru <rcojocaru@bitdefender.com>, xen-devel@lists.xen.org, Stefano Stabellini <stefano.stabellini@citrix.com>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 19/02/16 16:00, Stefano Stabellini wrote:
> On Fri, 19 Feb 2016, Corneliu ZUZU wrote:
>> On 2/19/2016 3:49 PM, Stefano Stabellini wrote:
>>> On Thu, 18 Feb 2016, Corneliu ZUZU wrote:
>>>> +
>>>> +    if ( sync )
>>>> +    {
>>>> +        req->flags |= VM_EVENT_FLAG_VCPU_PAUSED;
>>>> +        vm_event_vcpu_pause(v);
>>>> +    }
>>>> +
>>>> +#if CONFIG_X86
>>>> +    if ( altp2m_active(d) )
>>> I would rather
>>>
>>> #define altp2m_active(d) (0)
>>>
>>> on ARM, removing the two ifdefs in this file.
>> Yeah, I actually wanted to get rid of that too at some point, the question is,
>> what do I do with "req->altp2m_idx = vcpu_altp2m(v).p2midx"? I'm not familiar
>> w/ altp2m design, maybe someone that knows more of the internals of that can
>> give a suggestion.
> If you #define altp2m_active to (0), gcc will automatically avoid the if
> statement.

You will still get the compile error from ARM's struct vcpu not having
altp2m information.

~Andrew