From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [PATCH] docs: document handling of metacharacter escape in xl disk format Date: Fri, 19 Feb 2016 09:11:43 -0700 Message-ID: <56C73EBF.9070801@suse.com> References: <1455793357-5712-1-git-send-email-ian.campbell@citrix.com> <56C64955.7000909@suse.com> <1455876850.6225.73.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1455876850.6225.73.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 02/19/2016 03:14 AM, Ian Campbell wrote: > On Thu, 2016-02-18 at 15:44 -0700, Jim Fehlig wrote: >> Ian Campbell wrote: >>> Signed-off-by: Ian Campbell >>> Cc: Jim Fehlig >>> --- >>> docs/misc/xl-disk-configuration.txt | 18 ++++++++++++++++++ >>> 1 file changed, 18 insertions(+) >>> >>> diff --git a/docs/misc/xl-disk-configuration.txt b/docs/misc/xl-disk- >>> configuration.txt >>> index 6a2118d..a03ad10 100644 >>> --- a/docs/misc/xl-disk-configuration.txt >>> +++ b/docs/misc/xl-disk-configuration.txt >>> @@ -48,6 +48,24 @@ positionally or explicitly). >>> >>> Whitespace may appear before each parameter and will be ignored. >>> >>> +Metacharacters in a may be escaped using a backslash: >>> + >>> + Escape HEX Description >>> + ------ --- ----------- >>> + \a 0x07 Bell >>> + \b 0x08 Backspace >>> + \t 0x09 Horizontal Tab >>> + \n 0x0A New Line / Line Feed >>> + \f 0x0C Form Feed >>> + \r 0x0D Carriage Return >>> + \v 0x0B Vertical Tab >>> + \" 0x22 A literal double quote >>> + \' 0x27 A literal single quote >>> + \\ 0x5C A literal backslash >>> + \xXX Character XX in hexadecimal >>> + \OOO Character OOO in octal >> Do you know how any of these would be useful in a diskspec? I guess I'm >> struggling to understand when a 'Bell' would be needed :-). > I've not got a clue -- these are just all the ones handled by > xlu__cfgl_dequote, perhaps just for completeness? Maybe this code was copied from elsewhere and the unneeded/unused escapes were not removed. Regardless, it's probably unwise to remove things like bell, form feed, and vertical tab now. > > This is applied to all strings in a cfg file, not just diskspecs, Ah, right. And as such, I agree with your follow-up comment that this info should then be in xl.cfg(5). Regards, Jim