From: Corneliu ZUZU <czuzu@bitdefender.com>
To: Tamas K Lengyel <tamas@tklengyel.com>, Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>,
Stefano Stabellini <stefano.stabellini@citrix.com>
Subject: Re: [PATCH] arm/monitor vm-events: Implement guest-request support
Date: Fri, 19 Feb 2016 18:35:20 +0200 [thread overview]
Message-ID: <56C74448.1080709@bitdefender.com> (raw)
In-Reply-To: <CABfawhnoGGuOtM9-DqMQRm2f=oz6J=WL1U13XcHEkzBOr-ExhQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1607 bytes --]
On 2/19/2016 6:02 PM, Tamas K Lengyel wrote:
>
>
> On Fri, Feb 19, 2016 at 7:26 AM, Jan Beulich <JBeulich@suse.com
> <mailto:JBeulich@suse.com>> wrote:
>
> >>> On 18.02.16 at 20:35, <czuzu@bitdefender.com <mailto:czuzu@bitdefender.com>> wrote:
> > ---
> > MAINTAINERS | 1 +
> > xen/arch/arm/hvm.c | 8 +++
> > xen/arch/x86/hvm/event.c | 116
> ++++++----------------------------------
> > xen/arch/x86/hvm/hvm.c | 1 +
> > xen/arch/x86/monitor.c | 14 -----
> > xen/arch/x86/vm_event.c | 1 +
> > xen/common/Makefile | 2 +-
> > xen/common/hvm/Makefile | 3 +-
> > xen/common/hvm/event.c | 96
> +++++++++++++++++++++++++++++++++
>
> So here you _again_ try to introduce something HVM-ish for ARM.
> Why? Why can't this code live in common/vm_event.c?
>
>
> I too am wondering if this is the right way to architect this. It
> would be better to move the guest-requested stuff into the generic
> vm_event component as it doesn't seem to be HVM specific other then it
> using an HVMOP hypercall to be triggered.
>
> Tamas
>
Oh, that. "xen/common/hvm/event.c". I too don't know if it's the right
way, but Jan, please at least don't attribute the way the code already
is to me, I did not architect it.
And it's not human to expect doing everything perfectly in a single
shot. If you're of the opinion that it should be in vm_event.c I will
gladly try to put it there. Of course, that
could also be done in another patch.
Corneliu.
[-- Attachment #1.2: Type: text/html, Size: 3262 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-02-19 16:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 19:35 [PATCH] arm/monitor vm-events: Implement guest-request support Corneliu ZUZU
2016-02-18 20:08 ` Razvan Cojocaru
2016-02-18 21:25 ` Tamas K Lengyel
2016-02-19 5:44 ` Corneliu ZUZU
2016-02-19 13:49 ` Stefano Stabellini
2016-02-19 13:56 ` Razvan Cojocaru
2016-02-19 15:56 ` Corneliu ZUZU
2016-02-19 16:00 ` Stefano Stabellini
2016-02-19 16:05 ` Andrew Cooper
2016-02-19 16:10 ` Corneliu ZUZU
2016-02-19 17:47 ` Stefano Stabellini
2016-02-19 17:54 ` Tamas K Lengyel
2016-02-19 18:11 ` Corneliu ZUZU
2016-02-19 18:27 ` Tamas K Lengyel
2016-02-19 18:33 ` Corneliu ZUZU
2016-02-19 18:42 ` Tamas K Lengyel
2016-02-19 20:46 ` Corneliu ZUZU
2016-02-19 14:26 ` Jan Beulich
2016-02-19 16:02 ` Tamas K Lengyel
2016-02-19 16:35 ` Corneliu ZUZU [this message]
2016-02-19 16:25 ` Corneliu ZUZU
2016-02-19 17:15 ` Jan Beulich
2016-02-19 18:01 ` Corneliu ZUZU
2016-02-22 10:14 ` Jan Beulich
2016-02-22 11:26 ` Corneliu ZUZU
2016-02-22 11:38 ` Jan Beulich
2016-02-22 11:40 ` Razvan Cojocaru
2016-02-23 9:09 ` Corneliu ZUZU
2016-02-23 10:54 ` Razvan Cojocaru
2016-02-23 11:00 ` Corneliu ZUZU
2016-02-23 11:06 ` Razvan Cojocaru
2016-02-23 14:28 ` Tamas K Lengyel
2016-02-23 14:30 ` Tamas K Lengyel
2016-02-23 14:57 ` Corneliu ZUZU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C74448.1080709@bitdefender.com \
--to=czuzu@bitdefender.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=rcojocaru@bitdefender.com \
--cc=stefano.stabellini@citrix.com \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.