From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Joshua Henderson <joshua.henderson@microchip.com>,
linux-kernel@vger.kernel.org
Cc: Cristian Birsan <cristian.birsan@microchip.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v4 1/2] usb: musb: Fix DMA for host mode
Date: Fri, 19 Feb 2016 20:54:07 +0300 [thread overview]
Message-ID: <56C756BF.2070309@cogentembedded.com> (raw)
In-Reply-To: <1455900093-15577-1-git-send-email-joshua.henderson@microchip.com>
Hello.
On 02/19/2016 07:41 PM, Joshua Henderson wrote:
> From: Cristian Birsan <cristian.birsan@microchip.com>
>
> Commit ac33cdb16681 ("usb: musb: Remove ifdefs for musb_host_rx in
> musb_host.c part5") introduces a problem setting DMA host mode.
>
> This commit fixes the done condition that advances the musb schedule.
> Without this patch the the msub_advance_schedule() is called immediately
> after receiving an endpoint RX interrupt without waiting for the DMA
> transfer to complete. As a consequence when the dma complete interrupt
> arrives the in_qh member of hw_ep is already null an the musb_host_rx()
> exits on !urb error case.
>
> Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
> Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
> Tested-by: Ladislav Michl <ladis@linux-mips.org>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Although you didn't describe your changes to the original patch in the
change log...
MBR, Sergei
prev parent reply other threads:[~2016-02-19 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 16:41 [PATCH v4 1/2] usb: musb: Fix DMA for host mode Joshua Henderson
2016-02-19 17:54 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C756BF.2070309@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=balbi@kernel.org \
--cc=cristian.birsan@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=joshua.henderson@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.