From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1428509AbcBSTCR (ORCPT ); Fri, 19 Feb 2016 14:02:17 -0500 Received: from www62.your-server.de ([213.133.104.62]:47003 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422838AbcBSTCQ (ORCPT ); Fri, 19 Feb 2016 14:02:16 -0500 Message-ID: <56C766B0.1070607@iogearbox.net> Date: Fri, 19 Feb 2016 20:02:08 +0100 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Sasha Levin , ast@kernel.org CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCH v2] bpf: grab rcu read lock for bpf_percpu_hash_update References: <1455907990-22250-1-git-send-email-sasha.levin@oracle.com> In-Reply-To: <1455907990-22250-1-git-send-email-sasha.levin@oracle.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/19/2016 07:53 PM, Sasha Levin wrote: > bpf_percpu_hash_update() expects rcu lock to be held and warns if it's not, > which pointed out a missing rcu read lock. > > Fixes: 15a07b338 ("bpf: add lookup/update support for per-cpu hash and array maps") > Signed-off-by: Sasha Levin LGTM, patch is against net-next tree. Acked-by: Daniel Borkmann