From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757915AbcBSWiH (ORCPT ); Fri, 19 Feb 2016 17:38:07 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:54806 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757484AbcBSWiF (ORCPT ); Fri, 19 Feb 2016 17:38:05 -0500 Subject: Re: [PATCH] uapi: update install list after nvme.h rename To: Mario Limonciello , Jiri Slaby , , , , References: <1452474851-386-1-git-send-email-vapier@gentoo.org> <5694BD46.3030004@suse.cz> <20160114011720.GT4894@vapier.lan> <56975BA7.10905@suse.cz> <56C795EC.9010003@dell.com> CC: Michal Marek , Kernel Build Daemon , "Dominguez, Jared" From: Jens Axboe Message-ID: <56C7993E.2040907@fb.com> Date: Fri, 19 Feb 2016 15:37:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56C795EC.9010003@dell.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-02-19_10:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/19/2016 03:23 PM, Mario Limonciello wrote: > > > On 01/14/2016 02:26 AM, Jiri Slaby wrote: >> On 01/14/2016, 02:17 AM, Mike Frysinger wrote: >>> On 12 Jan 2016 09:45, Jiri Slaby wrote: >>>> On 01/11/2016, 02:14 AM, Mike Frysinger wrote: >>>>> Commit 9d99a8dda154 ("nvme: move hardware structures out of the >>>>> uapi version of nvme.h") renamed nvme.h to nvme_ioctl.h, but >>>>> the uapi list still refers to nvme.h. People trying to install >>>>> the headers hit a failure as the header no longer exists. >>>> >>>> Wouldn't reverting the rename be nicer to userspace? So that the >>>> filename is preserved and anybody who #included nvme.h still can >>>> do so? >> >>> i have no opinion on either route >> > Can someone with authority please decide on what to do about this? > It's wrecking havoc in userspace right now on stuff that needs nvme.h. The patch is in Linus' tree, and it was marked stable as well. So stable will pick it up, when the next 4.4-stable is spun. -- Jens Axboe