From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Gonglei <arei.gonglei@huawei.com>,
netdev@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org
Cc: peter.huangpeng@huawei.com, "David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH] xen-netfront: set real_num_tx_queues to zreo avoid to trigger BUG_ON
Date: Sat, 20 Feb 2016 18:50:41 +0300 [thread overview]
Message-ID: <56C88B51.3010706@cogentembedded.com> (raw)
In-Reply-To: <1455931646-5672-1-git-send-email-arei.gonglei@huawei.com>
On 02/20/2016 04:27 AM, Gonglei wrote:
> It's possible for a race condition to exist between xennet_open() and
> talk_to_netback(). After invoking netfront_probe() then other
> threads or processes invoke xennet_open (such as NetworkManager)
> immediately may trigger BUG_ON(). Besides, we also should reset
> real_num_tx_queues in xennet_destroy_queues().
>
> [ 3324.658057] kernel BUG at include/linux/netdevice.h:508!
> [ 3324.658057] invalid opcode: 0000 [#1] SMP
> [ 3324.658057] CPU: 0 PID: 662 Comm: NetworkManager Tainted: G
> [<ffffffff810bc646>] ? raw_notifier_call_chain+0x16/0x20
> [<ffffffff8166e1be>] __dev_open+0xce/0x150
> [<ffffffff8166e501>] __dev_change_flags+0xa1/0x170
> [<ffffffff8166e5f9>] dev_change_flags+0x29/0x70
> [<ffffffff8167c49f>] do_setlink+0x39f/0xb40
> [<ffffffff813c9ce2>] ? nla_parse+0x32/0x120
> [<ffffffff8167d544>] rtnl_newlink+0x604/0x900
> [<ffffffff8169f453>] ? netlink_unicast+0x193/0x1c0
> [<ffffffff81324808>] ? security_capable+0x18/0x20
> [<ffffffff810a4e9d>] ? ns_capable+0x2d/0x60
> [<ffffffff8167b955>] rtnetlink_rcv_msg+0xf5/0x270
> [<ffffffff813b32bd>] ? rhashtable_lookup_compare+0x5d/0xa0
> [<ffffffff8167b860>] ? rtnetlink_rcv+0x40/0x40
> [<ffffffff8169fc89>] netlink_rcv_skb+0xb9/0xe0
> [<ffffffff8167b84c>] rtnetlink_rcv+0x2c/0x40
> [<ffffffff8169f3ed>] netlink_unicast+0x12d/0x1c0
> [<ffffffff8169f953>] netlink_sendmsg+0x4d3/0x630
> [<ffffffff813280a2>] ? sock_has_perm+0x72/0x90
> [<ffffffff8164d34f>] do_sock_sendmsg+0x9f/0xc0
> [ 3324.703482] RIP [<ffffffffa0065a50>] xennet_open+0x180/0x182 [xen_netfront]
>
> CC: David S. Miller <davem@davemloft.net>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Full name required for this tag.
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-02-20 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 1:27 [PATCH] xen-netfront: set real_num_tx_queues to zreo avoid to trigger BUG_ON Gonglei
2016-02-20 4:36 ` David Miller
2016-02-20 6:00 ` Gonglei (Arei)
2016-02-22 13:33 ` [Xen-devel] " David Vrabel
2016-02-20 15:50 ` Sergei Shtylyov [this message]
2016-02-22 14:10 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C88B51.3010706@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=arei.gonglei@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.huangpeng@huawei.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.