From: Alex Elder <elder@ieee.org>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: Ceph Development <ceph-devel@vger.kernel.org>,
Varada Kari <Varada.Kari@sandisk.com>
Subject: Re: [PATCH 2/4] libceph: use the right footer size when skipping a message
Date: Sat, 20 Feb 2016 14:15:33 -0600 [thread overview]
Message-ID: <56C8C965.4010602@ieee.org> (raw)
In-Reply-To: <CAOi1vP-3TvUMVL+SMcagJ_wf1RE7Z3PbeUhUzUvOUJkX+1D_Ww@mail.gmail.com>
On 02/20/2016 02:05 PM, Ilya Dryomov wrote:
>>> >>
>>> >> +static size_t sizeof_footer(struct ceph_connection *con)
>> >
>> > I understand why this is named this way. But it's supplying a
>> > connection as argument, but a footer is a message attribute.
>> > So I might call this con_msg_footer_size().
> The *size* of footer is a connection attribute though ;)
Yeah, I know. That's why I suggested the con_msg_***().
But in any case, the code looks correct regardless of the
name.
-Alex
next prev parent reply other threads:[~2016-02-20 20:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 16:45 [PATCH 0/4] libceph: message skipping fixes Ilya Dryomov
2016-02-20 16:45 ` [PATCH 1/4] libceph: don't bail early from try_read() when skipping a message Ilya Dryomov
2016-02-20 18:28 ` Alex Elder
2016-02-20 20:21 ` Ilya Dryomov
2016-02-20 20:38 ` Alex Elder
2016-02-20 16:45 ` [PATCH 2/4] libceph: use the right footer size " Ilya Dryomov
2016-02-20 18:44 ` Alex Elder
2016-02-20 20:05 ` Ilya Dryomov
2016-02-20 20:15 ` Alex Elder [this message]
2016-02-21 14:31 ` Ilya Dryomov
2016-02-21 14:35 ` [PATCH 4/4] libceph: use sizeof_footer() more Ilya Dryomov
2016-02-21 15:08 ` Alex Elder
2016-02-20 16:45 ` [PATCH 3/4] libceph: don't spam dmesg with stray reply warnings Ilya Dryomov
2016-02-20 18:46 ` Alex Elder
2016-02-20 16:45 ` [PATCH 4/4] libceph: use sizeof_footer() in ceph_msg_revoke() Ilya Dryomov
2016-02-20 18:47 ` Alex Elder
2016-02-20 19:51 ` Ilya Dryomov
2016-02-20 19:56 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C8C965.4010602@ieee.org \
--to=elder@ieee.org \
--cc=Varada.Kari@sandisk.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.