From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1427488AbcBTU6M (ORCPT ); Sat, 20 Feb 2016 15:58:12 -0500 Received: from mail-am1on0064.outbound.protection.outlook.com ([157.56.112.64]:4010 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1422970AbcBTU6H (ORCPT ); Sat, 20 Feb 2016 15:58:07 -0500 Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=nextfour.com; Subject: Re: [REGRESSION, bisected] 4.5rc4 sound fsl-soc To: Fabio Estevam , , References: <56C1B59F.4040204@nextfour.com> <56C1CBD3.4000900@nextfour.com> CC: From: =?UTF-8?Q?Mika_Penttil=c3=a4?= Message-ID: <56C8D356.7000904@nextfour.com> Date: Sat, 20 Feb 2016 22:57:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [84.250.21.106] X-ClientProxiedBy: VI1PR02CA0029.eurprd02.prod.outlook.com (25.162.7.167) To AM2PR07MB0900.eurprd07.prod.outlook.com (25.161.71.21) X-Microsoft-Exchange-Diagnostics: 1;AM2PR07MB0900;2:ksCiXyoaOoH+RpQqXjt6/aTuemvhbTPRP9sl3bMx6K0W6L8HA9MSXMFBUGi6hBrBi/DFVqSk77JyOiJtdYeOyHeofdZnqRpNzSt3soOKEkTKyY+tC7PsyGaV5Z0cOqfuCmbo+olYEhvRna4ep8ftQw==;3:Id3hMex7SQNHB13s1aw2fw33K9PvgYiDZ2DC7MrEdEielKp9cNQ1FHb6u+h7nDqf135HRAjm9BhCJjc1jei2U0sCQascVD7+xAKSFoRQ/hrnVBEqpIl0X7N//2vluexs;25:OXISogro2QNqsmDxJCEtIkBTUpriRPpXJPGYdYGl3f0TDY4Ji7fvsSjpvr0gpSUkMMDAoFVFQc2+xM4Uc5oCjLSguyUK6BQeVBLuDSf/yKfyWYGSL21ED7CX/yTH/8YWObE/iH3kQJtXuIKxxWVwkAFlWolme9hK4PygCqBY9CmzSd+dAR+7c7ksQRk1F8BHVnhMwv90L7S3pxE7vtlP3p9L+mWKt4Xo537vQJHat/so17ZdziiMco96NfEukz46hFrOyNpXRS3+TPW3fek6jhPIGRfhT/S2zuoiTyyGS1eaknA5mTjxX3vt4/YmKhQpXlh8NH6+aBwqG9Ve91Es8Qvf/i6YnUJWMp6XBsbuJs0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM2PR07MB0900; X-MS-Office365-Filtering-Correlation-Id: 066457e7-e594-48e5-efec-08d33a3886e7 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:AM2PR07MB0900;BCL:0;PCL:0;RULEID:;SRVR:AM2PR07MB0900; X-Microsoft-Exchange-Diagnostics: 1;AM2PR07MB0900;4:vBvlQ13Dzj7mnfUDqYCusMBBey8vh/JpcVCEMNYEGKttPZK535RHzrEydThZLE28k995ZnRRw0VkPUSYWg50rEiUaeiHyQbdTM3qCCfw5Y8FrHahv8vl7sDf/br2wAq6m20o8pnp3KF+5yqBkscCVHayUp2v+yzkDZaxVrgB/gppE85WALUuAmmjzqw6JzEMHJRJii2D24o7fz0R/8sg8H9PNWgDx+w30OVuk+m8DbbpJck8qXk4T6nuJcpXPePr89Ohr/7TeDU5owPJI4WWqN1YKemo6LorvvMi8OHFXvJpi/19s6OLp3/bwdc97q7+2wFoCwnDSrahUFboTqEi9i6PHXW8JdJgwt7hM4hKbS59RGyTp09X2txFPBrBoADKVssDds4ItwxxKczRlDJCPwdqCzxLFRJkr8Er6NDWnSE= X-Forefront-PRVS: 0858FF8026 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(164054003)(479174004)(377454003)(36756003)(33656002)(4326007)(23746002)(2906002)(2870700001)(5004730100002)(93886004)(66066001)(65956001)(1096002)(42186005)(6116002)(3846002)(586003)(189998001)(47776003)(4001350100001)(86362001)(122386002)(15975445007)(87976001)(5001770100001)(77096005)(50466002)(92566002)(83506001)(5001960100002)(117156001)(3900700001)(19580395003)(87266999)(80316001)(76176999)(19580405001)(40100003)(5008740100001)(50986999)(2950100001)(54356999)(2201001)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:AM2PR07MB0900;H:[192.168.1.71];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM2PR07MB0900;23:NZg8FJGWuXq2viYAa21KulPbfeLeozJedp3xN?= =?Windows-1252?Q?ZG6Eu7IPY0uiVSlMiQXab+56A+f8sHXndEDNRoPkHvLUIFeguPj6dKsM?= =?Windows-1252?Q?unSsWCgJmeJZHmgWJcqLePLhDR7zci108OrAiMB4R6P0cwyhporxkoFs?= =?Windows-1252?Q?dl65lNq6O5pGJq2tbpOXx68MBpSGt1lZ5nLoWcGc7PP1ED5CsEjtLWiy?= =?Windows-1252?Q?63cLHgfS1MPga5Pdo4Ay8srZijozIOyH/SXtPXOhHNWHDO/ctvLaUaET?= =?Windows-1252?Q?BXBdj4OQEcOn3v89ncJk06MERICLQws+AonB+p4qID7ZW7q7x7Uxp6+h?= =?Windows-1252?Q?kjEv+SfCisTV1KxFE02haau+p8UfhNH2O5WrT+xG0EyBYEgWVplAJOsJ?= =?Windows-1252?Q?DoKU7lxDA5lAW65t5vMxoTKQ+MC3QLsQTe+LbNhFHSLVBsKMTskYqGSZ?= =?Windows-1252?Q?7rw5MmtjL7No0lENJkc50S64L2J04JqG5R8RP0XNbTaFKnuQw/DXUnT+?= =?Windows-1252?Q?VGTvpU3kqVSM+ONY0NyrC2RAstHClWmgxF1yl3v0WsUoioO67M46sPRT?= =?Windows-1252?Q?55QXmD5CQfy/U8OUf5PDNWqMg2eXU/JUn/V618ddKEjZ5M1LlHqB6yM/?= =?Windows-1252?Q?/sIrsSvCXp6ZVlc92/UvgcPZIFY+aWXuKyeO8z8jrpsnYeyaUzV8ZHXM?= =?Windows-1252?Q?J/JAoveCiaDwxEMgyDhCwJ7x7GgUbQqcMeFKa8TWmh5/fBBlL59jDBPn?= =?Windows-1252?Q?O92zMdc+xxXA43IjZ8dxR2HSfDHgD2iNX8u9wP8mCSwg957Idx+f5SzA?= =?Windows-1252?Q?Y7jvRWEvLlXns9hdnL0NWMuoB5HcMAiq3cttW+ERQXJ10r1hlIHllWoB?= =?Windows-1252?Q?EIECIHvzNA5hU/MXHFETgd+Bf1XN0CIpdybBB7mHTCdKtciBMeQwTFPa?= =?Windows-1252?Q?aVloc+Z6TsVWlK16I8W3jX0sOsoUVsHIAOnqE75VHmTUXNKSbvzYR0IK?= =?Windows-1252?Q?uXM7C8i+0Bm+rbK8e1guVxyQZw2u8Jeg1hnC5xjHVroIBjkOx/kIxGB0?= =?Windows-1252?Q?965iH90Wn/7a5V98x9mjezli4Qh65hbuerQPjtpATbi5vfPoTbTkmNJd?= =?Windows-1252?Q?9oYtoefhd5hBVAqhf5c9exeLKFcPDX4uvfrxtMuABEGVNuBMZbNRi/rI?= =?Windows-1252?Q?kQA7UIQjydVeCj+QSMxmRteQr8odTjuPvF5C1H9su/r+FK/5oysB8vmh?= =?Windows-1252?Q?zo1kMeW2Zp0rhqsfAN3AAUaGWUerTW2mwKOPedNuTKLV1Bx1hYDfoITT?= =?Windows-1252?Q?DitSiIIc84XRRhn0TrnLkpYinNMeFd5+j9aRY5q4uNQkmxgR66M9vXZJ?= =?Windows-1252?Q?JSTEI4gRt+Q?= X-Microsoft-Exchange-Diagnostics: 1;AM2PR07MB0900;5:qnwzXuJhiwN3eNmW2x851ylriBEEOb75MJu5ha6DXseBjkUuSvW9CH9mbrV3t7LsE/r6Nc1hYiAs+OGvQLL23qXmHip/WNU5OkINRTKIaIpB/J50/a7VPq8FxkmmwqY8yn+mWN3m67pR122dmXcB0Q==;24:ZWal35GgC8AsTWXLU0irWKLY8owUjqE8J6hL8CM018ygnj7jGcnb+e6YJtgn3Q39+iXtZJxGDpFqqK1+jQsn2YiIHwPmRDYCMR4Cdc4dBQE= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nextfour.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2016 20:58:04.0611 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR07MB0900 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark, I can confirm that the patch: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/base/regmap/regcache.c?id=3245d460a1eb55b5c3ca31dde7b5c5ac71546edf solved the audio codec probing issue for me. Without it there's no sound on imx6 with 4.5-rc4. Please apply. Thanks, Mika On 20.02.2016 22:45, Fabio Estevam wrote: > Hi Mika, > > Did it work for you? > > If so, please ask in the mailing list for Mark Brown to apply that patch. > > Thanks > > ________________________________________ > From: Mika Penttilä > Sent: Monday, February 15, 2016 11:00 AM > To: Fabio Estevam > Subject: Re: [REGRESSION, bisected] 4.5rc4 sound fsl-soc > > On 02/15/2016 01:30 PM, Fabio Estevam wrote: >> [Sorry for the top post, can't reply properly from this Inbox] > Hi, > > will test that tomorrow morning EET. > > > thanks, > Mika > > >> Could you please try applying this commit from linux-next? >> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/base/regmap/regcache.c?id=3245d460a1eb55b5c3ca31dde7b5c5ac71546edf >> >> Thanks, >> >> Fabio Estevam >> >> ________________________________________ >> From: Mika Penttilä >> Sent: Monday, February 15, 2016 9:25 AM >> To: LKML; mail@maciej.szmigiero.name; Fabio Estevam >> Subject: [REGRESSION, bisected] 4.5rc4 sound fsl-soc >> >> Hi, >> >> The following commit : >> >> 5c408fee254633a5be69505bc86c6b034f871ab4 is the first bad commit >> commit 5c408fee254633a5be69505bc86c6b034f871ab4 >> Author: Maciej S. Szmigiero >> Date: Mon Jan 18 20:07:44 2016 +0100 >> >> ASoC: fsl_ssi: remove explicit register defaults >> >> There is no guarantee that on fsl_ssi module load >> SSI registers will have their power-on-reset values. >> >> In fact, if the driver is reloaded the values in >> registers will be whatever they were set to previously. >> >> However, the cache needs to be fully populated at probe >> time to avoid non-atomic allocations during register >> access. >> >> Special case here is imx21-class SSI, since >> according to datasheet it don't have SACC{ST,EN,DIS} >> regs. >> >> This fixes hard lockup on fsl_ssi module reload, >> at least in AC'97 mode. >> >> Fixes: 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support MEGA Fast") >> Signed-off-by: Maciej S. Szmigiero >> Tested-by: Fabio Estevam >> Signed-off-by: Mark Brown >> >> >> causes regmap init failure when loading the sgtl5000 codec on imx6q, and >> leads to no audio. >> >> With the mentioned patch reverted sound works ok. >> >> --Mika >>