From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXPDp-0000v2-7C for qemu-devel@nongnu.org; Sun, 21 Feb 2016 03:18:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXPDm-0001D1-0R for qemu-devel@nongnu.org; Sun, 21 Feb 2016 03:18:29 -0500 Received: from mout.web.de ([212.227.15.4]:55557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXPDl-0001Cx-NC for qemu-devel@nongnu.org; Sun, 21 Feb 2016 03:18:25 -0500 References: <1455736149-21869-1-git-send-email-davidkiarie4@gmail.com> <1455736149-21869-2-git-send-email-davidkiarie4@gmail.com> <56C97260.3000609@web.de> From: Jan Kiszka Message-ID: <56C972CC.9090604@web.de> Date: Sun, 21 Feb 2016 09:18:20 +0100 MIME-Version: 1.0 In-Reply-To: <56C97260.3000609@web.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [V4 1/4] hw/i386: Introduce AMD IO MMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Kiarie , qemu-devel@nongnu.org Cc: marcel@redhat.com, valentine.sinitsyn@gmail.com, crosthwaitepeter@gmail.com, mst@redhat.com -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 2016-02-21 09:16, Jan Kiszka wrote: > On 2016-02-17 20:09, David Kiarie wrote: >> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h new file >> mode 100644 index 0000000..4264c19 --- /dev/null +++ >> b/hw/i386/amd_iommu.h > > ... > >> +/* extended feature support */ +#define >> IOMMU_EXT_FEATURES(IOMMU_FEATURE_PREFETCH | IOMMU_FEATURE_PPR | >> \ + IOMMU_FEATURE_NX | IOMMU_FEATURE_IA | IOMMU_FEATURE_GT >> | \ + IOMMU_FEATURE_GA | IOMMU_FEATURE_HE | >> IOMMU_GATS_MODE | \ + IOMMU_HATS_MODE) + +/* capabilities >> header */ +#define IOMMU_CAPAB_FEATURES(IOMMU_CAPAB_FLAT_EXT | \ >> + IOMMU_CAPAB_FLAG_NPCACHE | \ IOMMU_CAPAB_FLAG_IOTLBSUP >> \ Oh, and there is a stray '\' here. >> + | IOMMU_CAPAB_ID_SEC | IOMMU_CAPAB_INIT_TYPE | \ + >> IOMMU_CAPAB_FLAG_HTTUNNEL | IOMMU_CAPAB_EFR_SUP) > > These two do not compile because you misformatted the macros. Must > be > > #define X (Y | Z | ...) > > Jan > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlbJcswACgkQitSsb3rl5xRgIACfdNU0T9q5sNfnAqfXSAUSsuuE sMIAoL1duOzpcBkY6OXKxwEpb7uijplA =6zSV -----END PGP SIGNATURE-----