From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47976)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1aXPP4-0000QT-4W
	for qemu-devel@nongnu.org; Sun, 21 Feb 2016 03:30:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1aXPOz-0004Bf-4a
	for qemu-devel@nongnu.org; Sun, 21 Feb 2016 03:30:06 -0500
Received: from mout.web.de ([212.227.15.4]:61652)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1aXPOy-0004BY-RM
	for qemu-devel@nongnu.org; Sun, 21 Feb 2016 03:30:01 -0500
References: <1455736149-21869-1-git-send-email-davidkiarie4@gmail.com>
From: Jan Kiszka <jan.kiszka@web.de>
Message-ID: <56C97583.4010502@web.de>
Date: Sun, 21 Feb 2016 09:29:55 +0100
MIME-Version: 1.0
In-Reply-To: <1455736149-21869-1-git-send-email-davidkiarie4@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="R5jqAA98PcoJOLuiGSKUlf7OowOGs1SRT"
Subject: Re: [Qemu-devel] [V4 0/4] AMD IOMMU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Kiarie <davidkiarie4@gmail.com>, qemu-devel@nongnu.org
Cc: marcel@redhat.com, valentine.sinitsyn@gmail.com, crosthwaitepeter@gmail.com, mst@redhat.com

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--R5jqAA98PcoJOLuiGSKUlf7OowOGs1SRT
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable

On 2016-02-17 20:09, David Kiarie wrote:
> Hello there,
>=20
> This is v5 of AMD IOMMU patches that fixes the issues mentioned in v4 e=
xcept I fail to see the endian-ness issues Michael mentioned.
>=20
> I also stripped PIIX AMD IOMMU support since I added an MSI interrupt. =
One of the patches has a conflict with current master but it this is merg=
able I could quickly send a clean patch.

I've just made it compile over master, but something is broken, at
least in the PCI capability layout:

# lspci -vv -s 00:04.0
00:04.0 Generic system peripheral [0806]: Advanced Micro Devices [AMD] De=
vice 0020
        Subsystem: Red Hat, Inc Device 1100
        Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParEr=
r- Stepping- SERR+ FastB2B- DisINTx-
        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=3Dfast >TAbort- =
<TAbort- <MAbort- >SERR- <PERR- INTx-
        Capabilities: [64] HyperTransport: Slave or Primary Interface
                Command: BaseUnitID=3D0 UnitCnt=3D0 MastHost- DefDir-
                Link Control 0: CFlE- CST- CFE- <LkFail- Init- EOC- TXO- =
<CRCErr=3D0
                Link Config 0: MLWI=3D8bit MLWO=3D8bit LWI=3D8bit LWO=3D8=
bit
                Link Control 1: CFlE- CST- CFE- <LkFail- Init- EOC- TXO- =
<CRCErr=3D0
                Link Config 1: MLWI=3D8bit MLWO=3D8bit LWI=3D8bit LWO=3D8=
bit
                Revision ID: 0.00
        Capabilities: [60] MSI: Enable- Count=3D1/1 Maskable- 64bit-
                Address: 00006008  Data: 0000
        Capabilities: [5c] HyperTransport: Slave or Primary Interface
                Command: BaseUnitID=3D0 UnitCnt=3D0 MastHost- DefDir-
                Link Control 0: CFlE- CST+ CFE- <LkFail- Init- EOC- TXO- =
<CRCErr=3Dc
                Link Config 0: MLWI=3D8bit MLWO=3D8bit LWI=3D8bit LWO=3D8=
bit
                Link Control 1: CFlE- CST- CFE+ <LkFail- Init- EOC- TXO- =
<CRCErr=3D0
                Link Config 1: MLWI=3D8bit MLWO=3D8bit LWI=3D8bit LWO=3D8=
bit
                Revision ID: 0.00
        Capabilities: [58] MSI: Enable- Count=3D1/1 Maskable- 64bit-
                Address: 00005808  Data: 5c05
        Capabilities: [40] <chain broken>


Two times MSI, and a broken chain. At least unusual is also the
reverted ordering. Please examine and fix.

Thanks,
Jan



--R5jqAA98PcoJOLuiGSKUlf7OowOGs1SRT
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlbJdYMACgkQitSsb3rl5xSnYwCfYdLgh/xmg08iUjMSLg11iN/Y
jsQAnjgdSmMEDjDGPpiAs3e1heCzWRdI
=aQI9
-----END PGP SIGNATURE-----

--R5jqAA98PcoJOLuiGSKUlf7OowOGs1SRT--