From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Subject: Re: [PATCH] Revert "regulator: tps65217: remove tps65217.dtsi file" Date: Sun, 21 Feb 2016 10:27:49 +0100 Message-ID: <56C98315.1000707@denx.de> References: <1455891139-6139-1-git-send-email-peter.ujfalusi@ti.com> <20160219170404.GH21202@atomide.com> Reply-To: hs@denx.de Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160219170404.GH21202@atomide.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Tony Lindgren Cc: linux-omap@vger.kernel.org, devicetree@vger.kernel.org, j-keerthy@ti.com, linux-kernel@vger.kernel.org, broonie@kernel.org, hs@denx.de, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org Hello Tony, Peter, Am 19.02.2016 um 18:04 schrieb Tony Lindgren: > * Peter Ujfalusi [160219 06:14]: >> This reverts commit 8e6ebfaa9b384088002baa10f7534efa73a0794e. >> >> Without the patch reverted regulators will not work. This prevents >> MMC to be working for example so the boards can not boot to >> MMC rootfs. >> >> Tested it on beaglebone white and bisect also points to the >> reverted commit. >> The issue can be also fixed by adding "regulator-compatible =" to all board >> dts file for the regulators. >> >> Signed-off-by: Peter Ujfalusi >> --- >> Hi, >> >> I have noticed that bbw did not find the MMC with linux-next, but it turns out >> that even 4.5-rc4 is behaving the same way. >> I have run bisect and with this revert patch I can boot up fine. >> To be honest I don't know why the tps65217.dtsi has been deleted in the first >> place. > > I think initially the only real issue was the naming. The > tps65217.dtsi file should be just renamed to tps65217-am335x.dtsi > to make it clear that this configuration is commonly used for > most am335x boards. > > I'll apply this revert into omap-for-v4.5/fixes as it fixes a > regression. Sorry for breaking ... but I have no bbw hw for testing ... (This is maybe a reason for having something like an automated testsystem, see an example/proposal here: https://github.com/hsdenx/tbot see a demo for automated tests (running on a raspberry pi at my home in hungary, boards are in munich/germany) http://xeidos.ddns.net/buildbot/tgrid ) But I removed this file as Mark Brown suggested it, see: https://lkml.org/lkml/2015/10/21/581 So please introduce a "tps65217-am335x.dtsi" file ... Mark? bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany From mboxrd@z Thu Jan 1 00:00:00 1970 From: hs@denx.de (Heiko Schocher) Date: Sun, 21 Feb 2016 10:27:49 +0100 Subject: [PATCH] Revert "regulator: tps65217: remove tps65217.dtsi file" In-Reply-To: <20160219170404.GH21202@atomide.com> References: <1455891139-6139-1-git-send-email-peter.ujfalusi@ti.com> <20160219170404.GH21202@atomide.com> Message-ID: <56C98315.1000707@denx.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Tony, Peter, Am 19.02.2016 um 18:04 schrieb Tony Lindgren: > * Peter Ujfalusi [160219 06:14]: >> This reverts commit 8e6ebfaa9b384088002baa10f7534efa73a0794e. >> >> Without the patch reverted regulators will not work. This prevents >> MMC to be working for example so the boards can not boot to >> MMC rootfs. >> >> Tested it on beaglebone white and bisect also points to the >> reverted commit. >> The issue can be also fixed by adding "regulator-compatible =" to all board >> dts file for the regulators. >> >> Signed-off-by: Peter Ujfalusi >> --- >> Hi, >> >> I have noticed that bbw did not find the MMC with linux-next, but it turns out >> that even 4.5-rc4 is behaving the same way. >> I have run bisect and with this revert patch I can boot up fine. >> To be honest I don't know why the tps65217.dtsi has been deleted in the first >> place. > > I think initially the only real issue was the naming. The > tps65217.dtsi file should be just renamed to tps65217-am335x.dtsi > to make it clear that this configuration is commonly used for > most am335x boards. > > I'll apply this revert into omap-for-v4.5/fixes as it fixes a > regression. Sorry for breaking ... but I have no bbw hw for testing ... (This is maybe a reason for having something like an automated testsystem, see an example/proposal here: https://github.com/hsdenx/tbot see a demo for automated tests (running on a raspberry pi at my home in hungary, boards are in munich/germany) http://xeidos.ddns.net/buildbot/tgrid ) But I removed this file as Mark Brown suggested it, see: https://lkml.org/lkml/2015/10/21/581 So please introduce a "tps65217-am335x.dtsi" file ... Mark? bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751825AbcBUR45 (ORCPT ); Sun, 21 Feb 2016 12:56:57 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:53680 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbcBURxE (ORCPT ); Sun, 21 Feb 2016 12:53:04 -0500 X-Auth-Info: T7AFCD7GFmHQrE/7+0Mqk+Qw5bvJ47cuMziUlozh0Ws= Subject: Re: [PATCH] Revert "regulator: tps65217: remove tps65217.dtsi file" To: Tony Lindgren References: <1455891139-6139-1-git-send-email-peter.ujfalusi@ti.com> <20160219170404.GH21202@atomide.com> Cc: Peter Ujfalusi , hs@denx.de, j-keerthy@ti.com, broonie@kernel.org, robh@kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Reply-To: hs@denx.de From: Heiko Schocher Message-ID: <56C98315.1000707@denx.de> Date: Sun, 21 Feb 2016 10:27:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20160219170404.GH21202@atomide.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Tony, Peter, Am 19.02.2016 um 18:04 schrieb Tony Lindgren: > * Peter Ujfalusi [160219 06:14]: >> This reverts commit 8e6ebfaa9b384088002baa10f7534efa73a0794e. >> >> Without the patch reverted regulators will not work. This prevents >> MMC to be working for example so the boards can not boot to >> MMC rootfs. >> >> Tested it on beaglebone white and bisect also points to the >> reverted commit. >> The issue can be also fixed by adding "regulator-compatible =" to all board >> dts file for the regulators. >> >> Signed-off-by: Peter Ujfalusi >> --- >> Hi, >> >> I have noticed that bbw did not find the MMC with linux-next, but it turns out >> that even 4.5-rc4 is behaving the same way. >> I have run bisect and with this revert patch I can boot up fine. >> To be honest I don't know why the tps65217.dtsi has been deleted in the first >> place. > > I think initially the only real issue was the naming. The > tps65217.dtsi file should be just renamed to tps65217-am335x.dtsi > to make it clear that this configuration is commonly used for > most am335x boards. > > I'll apply this revert into omap-for-v4.5/fixes as it fixes a > regression. Sorry for breaking ... but I have no bbw hw for testing ... (This is maybe a reason for having something like an automated testsystem, see an example/proposal here: https://github.com/hsdenx/tbot see a demo for automated tests (running on a raspberry pi at my home in hungary, boards are in munich/germany) http://xeidos.ddns.net/buildbot/tgrid ) But I removed this file as Mark Brown suggested it, see: https://lkml.org/lkml/2015/10/21/581 So please introduce a "tps65217-am335x.dtsi" file ... Mark? bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany