From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:60341 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750880AbcBUUMg (ORCPT ); Sun, 21 Feb 2016 15:12:36 -0500 Subject: Re: [PATCH v3 4/4] iio: ad5755: Add full DT binding documentation To: Rob Herring , Sean Nyekjaer References: <1455632757-21748-1-git-send-email-sean.nyekjaer@prevas.dk> <1455632757-21748-2-git-send-email-sean.nyekjaer@prevas.dk> <1455632757-21748-3-git-send-email-sean.nyekjaer@prevas.dk> <1455632757-21748-4-git-send-email-sean.nyekjaer@prevas.dk> <20160218143724.GQ9654@rob-hp-laptop> Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org From: Jonathan Cameron Message-ID: <56CA1A33.6060207@kernel.org> Date: Sun, 21 Feb 2016 20:12:35 +0000 MIME-Version: 1.0 In-Reply-To: <20160218143724.GQ9654@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 18/02/16 14:37, Rob Herring wrote: > On Tue, Feb 16, 2016 at 03:25:57PM +0100, Sean Nyekjaer wrote: >> Signed-off-by: Sean Nyekjaer >> --- >> Changes since v2: >> - Removed defines, alot easier to read :-) >> >> .../devicetree/bindings/iio/dac/ad5755.txt | 94 ++++++++++++++++++++++ >> 1 file changed, 94 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iio/dac/ad5755.txt b/Documentation/devicetree/bindings/iio/dac/ad5755.txt >> index 4c91583..751204b 100644 >> --- a/Documentation/devicetree/bindings/iio/dac/ad5755.txt >> +++ b/Documentation/devicetree/bindings/iio/dac/ad5755.txt >> @@ -15,10 +15,104 @@ Recommended properties: >> - spi-max-frequency: Definition as per >> Documentation/devicetree/bindings/spi/spi-bus.txt >> >> +Optional properties: >> +See include/dt-bindings/iio/ad5755.h >> + - adi,ext_dc_dc_compenstation_resistor: boolean set if the hardware have an > > Use - instead of _ in property names. > >> + external resistor and thereby bypasses >> + the internal compensation resistor. >> + - adi,dc_dc_phase: >> + Valid values for DC DC Phase control is: >> + 0: All dc-to-dc converters clock on the same edge. >> + 1: Channel A and Channel B clock on the same edge, >> + Channel C and Channel D clock on opposite edges. >> + 2: Channel A and Channel C clock on the same edge, >> + Channel B and Channel D clock on opposite edges. >> + 3: Channel A, Channel B, Channel C, and Channel D >> + clock 90 degrees out of phase from each other. >> + - adi,dc_dc_freq: >> + Valid values for DC DC frequency is: >> + 0: 250 kHz. >> + 1: 410 kHz. >> + 2: 650 kHz. > > It is preferrable to make the values the actual units rather than > register values. Then we can have common properties. Is this a common > property of a DAC? Not overly common (in the parts we have seen in IIO so far), but best to allow for it becoming a general property in the future and actual units definitely the way to go. > >> + - adi,dc_dc_maxv: >> + Valid values for the maximum allowed Vboost voltage supplied by >> + the dc-to-dc converter is: >> + 0: 23 V. >> + 1: 24.5 V. >> + 2: 27 V. >> + 3: 29.5 V. > > Same here. > > Rob > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH v3 4/4] iio: ad5755: Add full DT binding documentation Date: Sun, 21 Feb 2016 20:12:35 +0000 Message-ID: <56CA1A33.6060207@kernel.org> References: <1455632757-21748-1-git-send-email-sean.nyekjaer@prevas.dk> <1455632757-21748-2-git-send-email-sean.nyekjaer@prevas.dk> <1455632757-21748-3-git-send-email-sean.nyekjaer@prevas.dk> <1455632757-21748-4-git-send-email-sean.nyekjaer@prevas.dk> <20160218143724.GQ9654@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160218143724.GQ9654@rob-hp-laptop> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring , Sean Nyekjaer Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 18/02/16 14:37, Rob Herring wrote: > On Tue, Feb 16, 2016 at 03:25:57PM +0100, Sean Nyekjaer wrote: >> Signed-off-by: Sean Nyekjaer >> --- >> Changes since v2: >> - Removed defines, alot easier to read :-) >> >> .../devicetree/bindings/iio/dac/ad5755.txt | 94 ++++++++++++++++++++++ >> 1 file changed, 94 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iio/dac/ad5755.txt b/Documentation/devicetree/bindings/iio/dac/ad5755.txt >> index 4c91583..751204b 100644 >> --- a/Documentation/devicetree/bindings/iio/dac/ad5755.txt >> +++ b/Documentation/devicetree/bindings/iio/dac/ad5755.txt >> @@ -15,10 +15,104 @@ Recommended properties: >> - spi-max-frequency: Definition as per >> Documentation/devicetree/bindings/spi/spi-bus.txt >> >> +Optional properties: >> +See include/dt-bindings/iio/ad5755.h >> + - adi,ext_dc_dc_compenstation_resistor: boolean set if the hardware have an > > Use - instead of _ in property names. > >> + external resistor and thereby bypasses >> + the internal compensation resistor. >> + - adi,dc_dc_phase: >> + Valid values for DC DC Phase control is: >> + 0: All dc-to-dc converters clock on the same edge. >> + 1: Channel A and Channel B clock on the same edge, >> + Channel C and Channel D clock on opposite edges. >> + 2: Channel A and Channel C clock on the same edge, >> + Channel B and Channel D clock on opposite edges. >> + 3: Channel A, Channel B, Channel C, and Channel D >> + clock 90 degrees out of phase from each other. >> + - adi,dc_dc_freq: >> + Valid values for DC DC frequency is: >> + 0: 250 kHz. >> + 1: 410 kHz. >> + 2: 650 kHz. > > It is preferrable to make the values the actual units rather than > register values. Then we can have common properties. Is this a common > property of a DAC? Not overly common (in the parts we have seen in IIO so far), but best to allow for it becoming a general property in the future and actual units definitely the way to go. > >> + - adi,dc_dc_maxv: >> + Valid values for the maximum allowed Vboost voltage supplied by >> + the dc-to-dc converter is: >> + 0: 23 V. >> + 1: 24.5 V. >> + 2: 27 V. >> + 3: 29.5 V. > > Same here. > > Rob > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >