From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
wsa@the-dreams.de, linux-i2c@vger.kernel.org,
lucas.demarchi@intel.com, srinivas.pandruvada@linux.intel.com,
ggao@invensense.com, adi.reus@gmail.com, cmo@melexis.com,
mwelling@ieee.org
Subject: Re: [RFC PATCH 3/9] iio: imu: inv_mpu6050: Fix newlines to make code easier to read
Date: Sun, 21 Feb 2016 20:38:38 +0000 [thread overview]
Message-ID: <56CA204E.3060002@kernel.org> (raw)
In-Reply-To: <1455810794-3188-4-git-send-email-daniel.baluta@intel.com>
On 18/02/16 15:53, Daniel Baluta wrote:
> This fixes the following checkpatch.pl warnings:
> * WARNING: Missing a blank line after declarations
> * CHECK: Blank lines aren't necessary before a close brace '}'
>
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Applied.
> ---
> drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c | 2 +-
> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c
> index 0bcfa8d..231a7af 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c
> @@ -186,7 +186,6 @@ int inv_mpu_acpi_create_mux_client(struct i2c_client *client)
> st->mux_client = i2c_new_device(st->mux_adapter, &info);
> if (!st->mux_client)
> return -ENODEV;
> -
> }
>
> return 0;
> @@ -195,6 +194,7 @@ int inv_mpu_acpi_create_mux_client(struct i2c_client *client)
> void inv_mpu_acpi_delete_mux_client(struct i2c_client *client)
> {
> struct inv_mpu6050_state *st = iio_priv(dev_get_drvdata(&client->dev));
> +
> if (st->mux_client)
> i2c_unregister_device(st->mux_client);
> }
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index c550ebb..72cc478 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -365,6 +365,7 @@ static int inv_write_raw_get_fmt(struct iio_dev *indio_dev,
>
> return -EINVAL;
> }
> +
> static int inv_mpu6050_write_accel_scale(struct inv_mpu6050_state *st, int val)
> {
> int result, i;
>
next prev parent reply other threads:[~2016-02-21 20:38 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 15:53 [RFC PATCH 0/9] iio: Fix ABBA deadlock in inv-mpu6050 Daniel Baluta
2016-02-18 15:53 ` [RFC PATCH 1/9] iio: imu: inv_mpu6050: Fix multiline comments style Daniel Baluta
2016-02-21 20:36 ` Jonathan Cameron
2016-02-18 15:53 ` [RFC PATCH 2/9] iio: imu: inv_mpu6050: Fix Yoda conditions Daniel Baluta
[not found] ` <1455810794-3188-3-git-send-email-daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-19 9:09 ` Crt Mori
2016-02-19 9:09 ` Crt Mori
[not found] ` <CAKv63us92Epe0go9JGNScbeOepg3_j8RyW9w2qgN01Jvnj3sUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-21 20:38 ` Jonathan Cameron
2016-02-21 20:38 ` Jonathan Cameron
2016-03-01 21:23 ` Wolfram Sang
2016-03-01 21:23 ` Wolfram Sang
2016-02-18 15:53 ` [RFC PATCH 3/9] iio: imu: inv_mpu6050: Fix newlines to make code easier to read Daniel Baluta
2016-02-21 20:38 ` Jonathan Cameron [this message]
2016-02-18 15:53 ` [RFC PATCH 4/9] iio: imu: inv_mpu6050: Remove unnecessary parentheses Daniel Baluta
2016-02-21 20:39 ` Jonathan Cameron
2016-02-18 15:53 ` [RFC PATCH 5/9] iio: imu: inv_mpu6050: Delete space before comma Daniel Baluta
2016-02-18 15:53 ` [RFC PATCH 6/9] iio: imu: inv_mpu6050: Fix code indent for if statement Daniel Baluta
2016-02-21 20:40 ` Jonathan Cameron
2016-02-18 15:53 ` [RFC PATCH 7/9] iio: imu: inv_mpu6050: Fix alignment with open parenthesis Daniel Baluta
[not found] ` <1455810794-3188-8-git-send-email-daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-21 20:41 ` Jonathan Cameron
2016-02-21 20:41 ` Jonathan Cameron
[not found] ` <56CA2101.8050805-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-02-21 20:59 ` Joe Perches
2016-02-21 20:59 ` Joe Perches
[not found] ` <1456088384.31061.2.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-02-21 21:08 ` Jonathan Cameron
2016-02-21 21:08 ` Jonathan Cameron
2016-02-18 15:53 ` [RFC PATCH 8/9] i2c: i2c-mux: Allow for NULL select callback Daniel Baluta
2016-03-01 20:30 ` Wolfram Sang
2016-03-01 20:38 ` Daniel Baluta
2016-02-18 15:53 ` [RFC PATCH 9/9] iio: imu: inv_mpu6050: Fix deadlock between i2c adapter lock and mpu lock Daniel Baluta
2016-02-18 18:17 ` Srinivas Pandruvada
[not found] ` <1455819430.7375.192.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-02-19 20:17 ` Ge Gao
2016-02-19 20:17 ` Ge Gao
2016-02-19 20:17 ` Ge Gao
[not found] ` <1455810794-3188-10-git-send-email-daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-03-01 20:50 ` Wolfram Sang
2016-03-01 20:50 ` Wolfram Sang
2016-03-02 16:33 ` Daniel Baluta
[not found] ` <CAEnQRZAF-tAjDwJkUNEVQXYqWDt7RsH2bH81UBAMUhsoWEt73g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-02 17:06 ` Wolfram Sang
2016-03-02 17:06 ` Wolfram Sang
2016-02-21 23:17 ` [RFC PATCH 0/9] iio: Fix ABBA deadlock in inv-mpu6050 Wolfram Sang
2016-02-22 9:43 ` Daniel Baluta
2016-02-26 15:52 ` Daniel Baluta
2016-03-03 23:09 ` Peter Rosin
[not found] ` <1457046598-15367-1-git-send-email-peda-SamgB31n2u5IcsJQ0EH25Q@public.gmane.org>
2016-03-04 10:20 ` Daniel Baluta
2016-03-04 10:20 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CA204E.3060002@kernel.org \
--to=jic23@kernel.org \
--cc=adi.reus@gmail.com \
--cc=cmo@melexis.com \
--cc=daniel.baluta@intel.com \
--cc=ggao@invensense.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=mwelling@ieee.org \
--cc=pmeerw@pmeerw.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.