From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael Kerrisk (man-pages)" Subject: Re: richacl(7) man page review comments Date: Sun, 21 Feb 2016 22:01:25 +0100 Message-ID: <56CA25A5.2030100@gmail.com> References: <56B770B6.7040803@gmail.com> <56B77262.7090107@gmail.com> <56C0F23C.7030902@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andreas Gruenbacher Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, "J. Bruce Fields" , linux-ext4 , XFS Developers , lkml , linux-fsdevel , Linux NFS Mailing List , linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux API , Dave Chinner , Christoph Hellwig , Anna Schumaker , Trond Myklebust , Jeff Layton , Andreas Dilger List-Id: linux-api@vger.kernel.org On 02/20/2016 05:37 PM, Andreas Gruenbacher wrote: > Hi Michael, > > thanks again for all the feedback. I've followed all your suggestions; > again, please see the github repo for the latest version: > > https://github.com/andreas-gruenbacher/richacl > > On Sun, Feb 14, 2016 at 10:31 PM, Michael Kerrisk (man-pages) > wrote: >> Hi Andreas, >> >> Here's a few more comments on the current richacl(7) page >> that I fetched from the git repo. >> [...] >>> .HP >>> .BR dir_inherit "\ (" d ): >>> The entry is inheritable for directories. >> >> "When this flag appears in the ACL entry of a directory, then that entry is >> inherited by new subdirectories created in the directory." >> >> Is that text that I propose correct? > > It's not entirely wrong, but only a small part of the truth. Entries > are inherited such that the permissions in file_inherit entries become > effective for access checking for new files, and the permissions in > dir_inherit entries become effective for access checking for new > directories, recursively. > > Your feedback prompted me to look into the inheritance flag > computation more closely once again, and I found bugs. The steps of > the algorithm are explained in the section "Permissions at > file-creation time", by the way. Hmmm... writing and refining documentation helps find code bugs. Who knew? :-) Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com ([74.125.82.42]:33804 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751373AbcBUVBc (ORCPT ); Sun, 21 Feb 2016 16:01:32 -0500 Subject: Re: richacl(7) man page review comments To: Andreas Gruenbacher References: <56B770B6.7040803@gmail.com> <56B77262.7090107@gmail.com> <56C0F23C.7030902@gmail.com> Cc: mtk.manpages@gmail.com, "J. Bruce Fields" , linux-ext4 , XFS Developers , lkml , linux-fsdevel , Linux NFS Mailing List , linux-cifs@vger.kernel.org, Linux API , Dave Chinner , Christoph Hellwig , Anna Schumaker , Trond Myklebust , Jeff Layton , Andreas Dilger From: "Michael Kerrisk (man-pages)" Message-ID: <56CA25A5.2030100@gmail.com> Date: Sun, 21 Feb 2016 22:01:25 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 02/20/2016 05:37 PM, Andreas Gruenbacher wrote: > Hi Michael, > > thanks again for all the feedback. I've followed all your suggestions; > again, please see the github repo for the latest version: > > https://github.com/andreas-gruenbacher/richacl > > On Sun, Feb 14, 2016 at 10:31 PM, Michael Kerrisk (man-pages) > wrote: >> Hi Andreas, >> >> Here's a few more comments on the current richacl(7) page >> that I fetched from the git repo. >> [...] >>> .HP >>> .BR dir_inherit "\ (" d ): >>> The entry is inheritable for directories. >> >> "When this flag appears in the ACL entry of a directory, then that entry is >> inherited by new subdirectories created in the directory." >> >> Is that text that I propose correct? > > It's not entirely wrong, but only a small part of the truth. Entries > are inherited such that the permissions in file_inherit entries become > effective for access checking for new files, and the permissions in > dir_inherit entries become effective for access checking for new > directories, recursively. > > Your feedback prompted me to look into the inheritance flag > computation more closely once again, and I found bugs. The steps of > the algorithm are explained in the section "Permissions at > file-creation time", by the way. Hmmm... writing and refining documentation helps find code bugs. Who knew? :-) Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 4D9827CB9 for ; Sun, 21 Feb 2016 15:18:49 -0600 (CST) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id B300FAC00D for ; Sun, 21 Feb 2016 13:18:42 -0800 (PST) Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by cuda.sgi.com with ESMTP id IcDQh94Y2lk706VV (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Sun, 21 Feb 2016 13:01:31 -0800 (PST) Received: by mail-wm0-f53.google.com with SMTP id g62so133011673wme.0 for ; Sun, 21 Feb 2016 13:01:31 -0800 (PST) Subject: Re: richacl(7) man page review comments References: <56B770B6.7040803@gmail.com> <56B77262.7090107@gmail.com> <56C0F23C.7030902@gmail.com> From: "Michael Kerrisk (man-pages)" Message-ID: <56CA25A5.2030100@gmail.com> Date: Sun, 21 Feb 2016 22:01:25 +0100 MIME-Version: 1.0 In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Andreas Gruenbacher Cc: Andreas Dilger , linux-cifs@vger.kernel.org, Linux NFS Mailing List , Christoph Hellwig , Linux API , Trond Myklebust , lkml , XFS Developers , "J. Bruce Fields" , mtk.manpages@gmail.com, linux-fsdevel , Jeff Layton , linux-ext4 , Anna Schumaker On 02/20/2016 05:37 PM, Andreas Gruenbacher wrote: > Hi Michael, > > thanks again for all the feedback. I've followed all your suggestions; > again, please see the github repo for the latest version: > > https://github.com/andreas-gruenbacher/richacl > > On Sun, Feb 14, 2016 at 10:31 PM, Michael Kerrisk (man-pages) > wrote: >> Hi Andreas, >> >> Here's a few more comments on the current richacl(7) page >> that I fetched from the git repo. >> [...] >>> .HP >>> .BR dir_inherit "\ (" d ): >>> The entry is inheritable for directories. >> >> "When this flag appears in the ACL entry of a directory, then that entry is >> inherited by new subdirectories created in the directory." >> >> Is that text that I propose correct? > > It's not entirely wrong, but only a small part of the truth. Entries > are inherited such that the permissions in file_inherit entries become > effective for access checking for new files, and the permissions in > dir_inherit entries become effective for access checking for new > directories, recursively. > > Your feedback prompted me to look into the inheritance flag > computation more closely once again, and I found bugs. The steps of > the algorithm are explained in the section "Permissions at > file-creation time", by the way. Hmmm... writing and refining documentation helps find code bugs. Who knew? :-) Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs