From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753080AbcBVENF (ORCPT <rfc822;w@1wt.eu>);
	Sun, 21 Feb 2016 23:13:05 -0500
Received: from szxga03-in.huawei.com ([119.145.14.66]:33892 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752587AbcBVENE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 21 Feb 2016 23:13:04 -0500
Subject: Re: [PATCH 06/54] perf tools: Add API to config maps in bpf object
To: Arnaldo Carvalho de Melo <acme@kernel.org>
References: <20160215200211.GB17690@kernel.org>
CC: Alexei Starovoitov <ast@kernel.org>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        "Cody P Schafer" <dev@codyps.com>,
        "David S. Miller" <davem@davemloft.net>, He Kuang <hekuang@huawei.com>,
        =?UTF-8?Q?J=c3=a9r=c3=a9mie_Galarneau?= 
	<jeremie.galarneau@efficios.com>,
        Jiri Olsa <jolsa@kernel.org>, "Kirill Smelkov" <kirr@nexedi.com>,
        Li Zefan <lizefan@huawei.com>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Namhyung Kim <namhyung@kernel.org>,
        "Peter Zijlstra" <peterz@infradead.org>, <pi3orama@163.com>,
        <linux-kernel@vger.kernel.org>
From: "Wangnan (F)" <wangnan0@huawei.com>
Message-ID: <56CA8910.7000303@huawei.com>
Date: Mon, 22 Feb 2016 12:05:36 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <20160215200211.GB17690@kernel.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.111.66.109]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A090203.56CA8938.0005,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: d6b054c4a9edfd14c2bedbe9e1e024eb
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2016/2/19 21:53, Arnaldo Carvalho de Melo wrote:
> Sorry for the top post, but the message below didn't made it thru due to
> local problems as I recently switched notebooks, my postfix setup barfed
> this one :-\
>
> This is what I have in my tmp.perf/bpf_map:
>
> https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=tmp.perf/bpf_map&id=5c78fe3c5a944ba7f9a85f59548295211f3d252c
>
> Please take a look and see if you're ok with it,

I agree your change, but the commit you mentioned has a bug
which I have already fixed in Feb. 19 patch set:

At bpf_map__config_value:

+        if (!term->type_val == PARSE_EVENTS__TERM_TYPE_NUM) {
+                pr_debug("ERROR: wrong value type\n");
+                return -BPF_LOADER_ERRNO__OBJCONF_MAP_VALUE;
+        }

Should use

          if (term->type_val != PARSE_EVENTS__TERM_TYPE_NUM)

I'll switch 'maps' to 'map' as you did in my tree and send this
patch again. (still based on perf/core, so I can solve potential
conflicts in my side).

Thank you.