From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [Bug 111441] New: iscsi fails to attach to targets Date: Mon, 22 Feb 2016 08:08:20 +0100 Message-ID: <56CAB3E4.4030902@suse.de> References: <56AAC605.1080707@cs.wisc.edu> <9cf7d536fcc44d9d8f35d81503543497@XCH-ALN-006.cisco.com> <36266784-E570-406E-8C3A-56D0F728768B@cs.wisc.edu> <01C3BBA0-3D1A-461A-9EEF-512A57707325@cs.wisc.edu> <4c4653b259cd4f1887505dfc61d500a8@XCH-ALN-006.cisco.com> <56ABBCFF.9060003@cs.wisc.edu> <26376c0ade5645cfac5cc248a97528ba@XCH-ALN-006.cisco.com> <56ABF6A6.8070506@cs.wisc.edu> <8f6cc8ca33274ddaa9faf17f00caefdf@XCH-ALN-006.cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mx2.suse.de ([195.135.220.15]:46569 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751129AbcBVHIX (ORCPT ); Mon, 22 Feb 2016 02:08:23 -0500 In-Reply-To: <8f6cc8ca33274ddaa9faf17f00caefdf@XCH-ALN-006.cisco.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Serguei Bezverkhi (sbezverk)" , Mike Christie Cc: "bugzilla-daemon@bugzilla.kernel.org" , "linux-scsi@vger.kernel.org" , Christoph Hellwig On 02/22/2016 01:45 AM, Serguei Bezverkhi (sbezverk) wrote: > Hi Mike, >=20 > I just wanted to follow up with you to see if the patch got committed= to an upstream kernel if yes, please let me into which version it went= =2E >=20 > Thank you >=20 > Serguei >=20 >=20 > Serguei Bezverkhi, > TECHNICAL LEADER.SERVICES > Global SP Services > sbezverk@cisco.com > Phone: +1 416 306 7312 > Mobile: +1 514 234 7374 >=20 > CCIE (R&S,SP,Sec) - #9527 >=20 > Cisco.com >=20 >=20 >=20 > Think before you print. > This email may contain confidential and privileged material for the s= ole use of the intended recipient. Any review, use, distribution or dis= closure by others is strictly prohibited. If you are not the intended r= ecipient (or authorized to receive for the recipient), please contact t= he sender by reply email and delete all copies of this message. > Please click here for Company Registration Information. >=20 >=20 >=20 > -----Original Message----- > From: Mike Christie [mailto:michaelc@cs.wisc.edu]=20 > Sent: Friday, January 29, 2016 6:33 PM > To: Serguei Bezverkhi (sbezverk) > Cc: bugzilla-daemon@bugzilla.kernel.org; linux-scsi@vger.kernel.org; = Christoph Hellwig ; Hannes Reinecke > Subject: Re: [Bug 111441] New: iscsi fails to attach to targets >=20 > On 01/29/2016 04:21 PM, Serguei Bezverkhi (sbezverk) wrote: >> HI Mike, >> >> I tried your patch and it is has eliminated first traceback but I st= ill do not see my remote targets. >> >=20 > That is sort of expected. Your target is not setup for ALUA properly.= It says it supports ALUA, but when scsi_dh_alua asks about the ports i= t is reporting there are none. Ccing the people that made the patch tha= t added the issue and own the code. >=20 > Hey Christoph and Hannes, >=20 > The dh/alua changes that added this: >=20 > error =3D scsi_dh_add_device(sdev); > if (error) { > sdev_printk(KERN_INFO, sdev, > "failed to add device handler: %d\n",= error); > return error; > } >=20 > to scsi_sysfs_add_sdev are adding a regression. >=20 > 1. If that fails, then we forget to do device_del before doing the re= turn. My patch in this thread added that back, so we do not see the sys= fs oopses anymore. But..... >=20 > 2. It looks like in older kernels, we would allow misconfigured targe= ts like this one to still setup devices. Do we want that old behavior b= ack? > Should we just ignore the return value from scsi_dh_add_device above? > Note that in this case, it is LIO so it can be easily fixed on the ta= rget side by just setting it up properly. I do not think other targets = would hit this type of issue. >=20 >=20 This has been fixed up with my patchset to update the ALUA handler, mos= t notably the commit 'scsi: ignore errors from scsi_dh_add_device()' whic= h was included in 4.5. Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html