From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v2 21/21] drm/tilcdc: Initialize crtc->port Date: Mon, 22 Feb 2016 14:50:01 +0200 Message-ID: <56CB03F9.5090705@ti.com> References: <4acbb8ee93fba0b0bd29a347169134dc65cda617.1455632042.git.jsarha@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0058332141==" Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by gabe.freedesktop.org (Postfix) with ESMTPS id C592F6E18D for ; Mon, 22 Feb 2016 12:50:09 +0000 (UTC) In-Reply-To: <4acbb8ee93fba0b0bd29a347169134dc65cda617.1455632042.git.jsarha@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org --===============0058332141== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p6VnnpUOU3HeL3Cx7BHsQ4e1gbd8NI0vW" --p6VnnpUOU3HeL3Cx7BHsQ4e1gbd8NI0vW Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 16/02/16 16:18, Jyri Sarha wrote: > Initialize port device node pointer in the tilcdc crtc. Fixes "Falling > back to first CRTC" warning from tda998x driver. The description is rather short, and doesn't really explain what was wrong and why this fixes it. > Signed-off-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/til= cdc/tilcdc_crtc.c > index e886277..cfd3fd1 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > @@ -124,6 +124,7 @@ static void tilcdc_crtc_destroy(struct drm_crtc *cr= tc) > =20 > tilcdc_crtc_dpms(crtc, DRM_MODE_DPMS_OFF); > =20 > + of_node_put(crtc->port); > drm_crtc_cleanup(crtc); > drm_flip_work_cleanup(&tilcdc_crtc->unref_work); > =20 > @@ -768,6 +769,7 @@ void tilcdc_crtc_cancel_page_flip(struct drm_crtc *= crtc, struct drm_file *file) > =20 > struct drm_crtc *tilcdc_crtc_create(struct drm_device *dev) > { > + struct tilcdc_drm_private *priv =3D dev->dev_private; > struct tilcdc_crtc *tilcdc_crtc; > struct drm_crtc *crtc; > int ret; > @@ -794,6 +796,15 @@ struct drm_crtc *tilcdc_crtc_create(struct drm_dev= ice *dev) > =20 > drm_crtc_helper_add(crtc, &tilcdc_crtc_helper_funcs); > =20 > + if (priv->is_componentized) { > + crtc->port =3D > + of_get_child_by_name(dev->dev->of_node, "port"); > + if (!crtc->port) { > + dev_warn(dev->dev, "no port node found in %s\n", > + dev->dev->of_node->full_name); Isn't this an error? Can the driver proceed if there's no port node? Tomi --p6VnnpUOU3HeL3Cx7BHsQ4e1gbd8NI0vW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWywP5AAoJEPo9qoy8lh71cL4P/ArH4cP1nR7Sj09qIYzw91p6 FX8CHHYcBl02QhFCyslS56StsT71q96Oez417iSvgiO987RO+QHdSNLrS299EDMV 4stRjjtIWDEhQa8gj75vCmTDDxhrCxubyWFIXAlXgyL8+mduhY6Er+ngI/d9efUx ZM6X119fBCw64TeFOobpwwcof2+Tz78ATgMGMxuouurcN2AcZlhRNmTA54adicpL 0sRWPV32xDOj8yoZc3V5L9d33LXE6jsgyKsXbSrxhJUGCRB2Uy3HwMK6wur1d+Vo azNiQnAkHYMOfWXiCMHDLGhHczq0sF5hVF342dEXGZ59tG+m6SPq/MddUUOQgYie bh7Uuhsz/GC1Lv9NqgSllvHRemPcBl3dA5narTyuasXN4zYMDgao4Saw/YAit9hd sw1+4QxSHsVX8HXwpARLjmNyhuV8KJ3/vlkDdGr3w2hddT+ZNneSGPAVLL5vQbVk TpXTC24X9VIEa0dBDUMDfQqaLMxXFidUg1cGSmTizsm8657vNrhw8J0q0BzNoTFo jGoWPi1Uv0inQsuI3brdihqKMUpCAGIOcoFsQ0VO1JaRKm8DieU+My0mbTsbDX+k xGYxaymlq9fiFus8BuYCvjBlsxs5zPaIaETAtXnRxLExAmxxxnTra2wSEKGhTqih hf42QiWFEnd/2aJzyM0N =+RbP -----END PGP SIGNATURE----- --p6VnnpUOU3HeL3Cx7BHsQ4e1gbd8NI0vW-- --===============0058332141== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0058332141==--