From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v2 09/21] drm/tilcdc: Allocate register storage based on the actual number registers Date: Mon, 22 Feb 2016 14:51:57 +0200 Message-ID: <56CB046D.3010106@ti.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1768836982==" Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by gabe.freedesktop.org (Postfix) with ESMTPS id 23CD26E18E for ; Mon, 22 Feb 2016 12:52:02 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org --===============1768836982== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cUXogm8xv3OVRR5rcruIvso4G6UOdj4ho" --cUXogm8xv3OVRR5rcruIvso4G6UOdj4ho Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 16/02/16 16:18, Jyri Sarha wrote: > Allocate suspend/resume register storage based on the actual number > registers the driver is aware of. The static allocation for register > storage had falen behind badly. "fallen" >=20 > Reported-by: Michael Bode > Signed-off-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 21 ++++++++++++++++++++- > drivers/gpu/drm/tilcdc/tilcdc_drv.h | 2 +- > 2 files changed, 21 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilc= dc/tilcdc_drv.c > index 893ef18..ab1789b 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > @@ -141,11 +141,14 @@ static int tilcdc_unload(struct drm_device *dev) > =20 > pm_runtime_disable(dev->dev); > =20 > + kfree(priv->saved_register); > kfree(priv); > =20 > return 0; > } > =20 > +static size_t tilcdc_num_regs(void); > + > static int tilcdc_load(struct drm_device *dev, unsigned long flags) > { > struct platform_device *pdev =3D dev->platformdev; > @@ -157,7 +160,12 @@ static int tilcdc_load(struct drm_device *dev, uns= igned long flags) > int ret; > =20 > priv =3D kzalloc(sizeof(*priv), GFP_KERNEL); > - if (!priv) { > + if (priv) > + priv->saved_register =3D kcalloc(tilcdc_num_regs(), > + sizeof(*priv->saved_register), > + GFP_KERNEL); devm_kzalloc() would clean this up a bit. For both 'priv' and 'saved_registers'. Tomi --cUXogm8xv3OVRR5rcruIvso4G6UOdj4ho Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWywRtAAoJEPo9qoy8lh71w2IP/Atj4XmbrA+JwQDjQEW9RTDT ISIZt7FkSeDz7LmsG/+Z0g6acrdogYwU59OBdFIbbYzax5wh5lAdL3DnxKLqSaGO pkeHOXAsA30dqqHZlhwEe/i/MWm5BC5heduJ1X2OQQJte68JcQq6SEm6q5ClhO2C 2aYUQdn7Tg8RAz13AplFJRXio5V8hl20GSepXHSXgmS2JpRLHmoR27wjahAmyGP2 pBlZikPwkAPY4chyBPc26bZo9R3ZqaCe4ZBW9o025ua18ASyxxHz5IiNoOK3e2g8 +SzCVfcwvSNhP5nyQtNsP84HWyXS5uT0iP8JW8T3gqcr5XakNcO7yO/Qjr6b0eBU yS2Wf5uZy2CaF5n85DxyqfE0+InhM1V+BSwN9XaBZq8WTvQZbNAS6ogfsB53cPdT YXDZ0HpqL7WZB22G3kb7/qhIZFvELM1DcVaJ+g3xCZPST0HUha4kvpxWXeW8Sn90 BR8FHhOT9vxkkd2K3MULutSZBND88cXGjzhCm+Fa9J58pUM94jDQYBFdMdZHbyyH IqjLxkEE9WU/z5u/+1+sPMrBsp8nygecLOwKajUk0hk2qBgyPr2K3GtACCew25zF eJ21qQEGGJcFy1UfbK5NYFmQHGKSJLvs1TwoT8pXDYI23dQflLmwYAAF+umEq++J klW+eu//TDYLq74niNde =71G7 -----END PGP SIGNATURE----- --cUXogm8xv3OVRR5rcruIvso4G6UOdj4ho-- --===============1768836982== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1768836982==--