From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH v2 1/4] tools/configure: only require bcc/ld86/as86 when needed Date: Mon, 22 Feb 2016 08:37:31 -0600 Message-ID: <56CB1D2B.6070008@cardoe.com> References: <1455850625-9624-1-git-send-email-cardoe@cardoe.com> <20160219140036.GB31079@localhost.localdomain> <56C72649.4090905@cardoe.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9145923803217884010==" Return-path: In-Reply-To: <56C72649.4090905@cardoe.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Wei Liu , Stefano Stabellini , Ian Jackson , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============9145923803217884010== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xdLUK4fkMoc09u0vja6hrFnGVS9lIKxiC" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xdLUK4fkMoc09u0vja6hrFnGVS9lIKxiC Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2/19/16 8:27 AM, Doug Goldstein wrote: > On 2/19/16 8:00 AM, Konrad Rzeszutek Wilk wrote: >> On Thu, Feb 18, 2016 at 08:57:02PM -0600, Doug Goldstein wrote: >>> bcc/ld86/as86 are only necessary when we build rombios and not always= so >>> failing the build when they aren't available should not happen if the= >>> user isn't building rombios. >> >> That is quite the long sentence. Perhaps trim it down to: >> >> "are necessary when we build ROMBIOS. However if we do not build it=20 >> (not building qemu-trad) - the build requirements are overly strict >> and can lead to failures." ? >> >> Otherwise >> Reviewed-by: Konrad Rzeszutek Wilk >> >=20 > Agreed. That's better. Thank you for the review. >=20 >=20 Hoping to get some more reviews before I resend this with the wording update. 3/4 has no reviews. --=20 Doug Goldstein --xdLUK4fkMoc09u0vja6hrFnGVS9lIKxiC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWyx0sXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUUjMP/AzxV60R9E25vugSqrWgghlc 4Bsf31udroQ+h85eNgWlY1o/5N862zMli/fGaYQ1KffAOt7dX/4cj1abD0PrzCVF xpWUaJE0sDJMIVbRIDFZ3ZBjZ1OpUgRknmuMRyo+ZLbkZ+eKTHdUwwLmLGJbnqLa 1wKwsAByV3NtC9hwHofbMITx7csM+7q73cJgpbZ5IZx+wYQWS7u5ZoHQ0frnNjX5 byPt1in3/pnell2KrfffxB3BwARyfRPDnnxYxtGtMb6ovpTiJGdPQNcAGQXv5vtB Ky8tlouIclaH7fL2EufUfoa4D/qBWiSANyvlUbbRG4OaBMceqGc51IDSPD9JpGHw qdHVtVXFcXC7URi3cq5ukcRaW5Y0nKOIbuHBnloXqrdwp7hKsWp7/wKsr6Uk0e0z XzVC5q7czokglRIkPgVRMlKsmf0SsZeN16b00uGQhrtUnwcVOHUSqpN95Y7Mi/so B+uVSfIWtrZBLwANcnOJas/fQTGRrhiDQuQ50VBzyb2hoTFKRkyg2Srwn+mZ9HF0 +5TT8xsAv2ShGcD7qbk379MOSxi7we9TSGs1PB/aYnidmLahbVKDcMt97b9vQy4a uweAXFpdcdW9ZZMhoz3Ah9w/m7mfM43kjqWJvQhuKmmQFwdUsllI1/6RHzDPKFLo N7PQNaUjx+vcGEALSpit =2JqO -----END PGP SIGNATURE----- --xdLUK4fkMoc09u0vja6hrFnGVS9lIKxiC-- --===============9145923803217884010== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============9145923803217884010==--