All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sasha.levin@oracle.com>
To: "David S. Miller" <davem@davemloft.net>,
	ast@plumgrid.com, Daniel Borkmann <dborkman@redhat.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: bpf: net/core/filter.c:2115 suspicious rcu_dereference_protected() usage!
Date: Mon, 22 Feb 2016 10:31:33 -0500	[thread overview]
Message-ID: <56CB29D5.9090000@oracle.com> (raw)

Hi all,

I've hit the following warning while fuzzing with trinity inside a kvmtool guest
running the latest -next kernel:

[ 1343.104588] ===============================

[ 1343.104591] [ INFO: suspicious RCU usage. ]

[ 1343.104619] 4.5.0-rc4-next-20160219-sasha-00026-g7978205-dirty #2978 Not tainted

[ 1343.104624] -------------------------------

[ 1343.104635] net/core/filter.c:2115 suspicious rcu_dereference_protected() usage!

[ 1343.104641]

[ 1343.104641] other info that might help us debug this:

[ 1343.104641]

[ 1343.104650]

[ 1343.104650] rcu_scheduler_active = 1, debug_locks = 0

[ 1343.104660] 1 lock held by syz-executor/17916:

[ 1343.104784] #0: (rtnl_mutex){+.+.+.}, at: rtnl_lock (net/core/rtnetlink.c:71)
[ 1343.104789]

[ 1343.104789] stack backtrace:

[ 1343.104820] CPU: 1 PID: 17916 Comm: trinity-c8 Not tainted 4.5.0-rc4-next-20160219-sasha-00026-g7978205-dirty #2978

[ 1343.104868]  1ffff10036968f44 ffff8801b4b47aa8 ffffffffa23d9a9d ffffffff00000001

[ 1343.104891]  fffffbfff5c2a630 0000000041b58ab3 ffffffffadb3a8f2 ffffffffa23d9905

[ 1343.104914]  0000000000000000 ffff8801b5419b40 fffffbfff7596522 0000000000000001

[ 1343.104919] Call Trace:

[ 1343.104985] dump_stack (lib/dump_stack.c:53)
[ 1343.105060] lockdep_rcu_suspicious (kernel/locking/lockdep.c:4282)
[ 1343.105093] sk_detach_filter (net/core/filter.c:2114 (discriminator 5))
[ 1343.105193] tun_detach_filter (drivers/net/tun.c:1808 (discriminator 7))
[ 1343.105238] __tun_chr_ioctl (drivers/net/tun.c:2133)
[ 1343.105370] tun_chr_ioctl (drivers/net/tun.c:2161)
[ 1343.105407] do_vfs_ioctl (fs/ioctl.c:44 fs/ioctl.c:674)
[ 1343.105506] SyS_ioctl (fs/ioctl.c:689 fs/ioctl.c:680)
[ 1343.105542] entry_SYSCALL_64_fastpath (arch/x86/entry/entry_64.S:200)

             reply	other threads:[~2016-02-22 15:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-22 15:31 Sasha Levin [this message]
2016-03-29 12:58 ` bpf: net/core/filter.c:2115 suspicious rcu_dereference_protected() usage! Michal Kubecek
2016-03-29 13:55   ` Daniel Borkmann
2016-03-29 14:39     ` Daniel Borkmann
2016-03-30  9:42       ` Michal Kubecek
2016-03-30 11:33         ` Daniel Borkmann
2016-03-30 12:24           ` Michal Kubecek
2016-03-30 12:38             ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CB29D5.9090000@oracle.com \
    --to=sasha.levin@oracle.com \
    --cc=ast@plumgrid.com \
    --cc=davem@davemloft.net \
    --cc=dborkman@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.