All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Brabec <sbrabec@suse.cz>
To: Karel Zak <kzak@redhat.com>
Cc: Ruediger Meier <sweet_f_a@gmx.de>, util-linux@vger.kernel.org
Subject: Re: [PATCH] tests: add test for loop option in fstab
Date: Mon, 22 Feb 2016 17:36:25 +0100	[thread overview]
Message-ID: <56CB3909.4080808@suse.cz> (raw)
In-Reply-To: <20160222101233.imyhujomel6ydin3@ws.net.home>

On Feb 22, 2016 at 11:12 Karel Zak wrote:
> On Fri, Feb 19, 2016 at 07:27:07PM +0100, Stanislav Brabec wrote:
>> On Feb 16 2016 at 15:49 Karel Zak wrote:
>>> On Mon, Feb 15, 2016 at 12:42:10PM +0100, Ruediger Meier wrote:
>>>> On Thursday 11 February 2016, Stanislav Brabec wrote:
>>>>> Add a new fstab tests which check loop mount of the same source
>>>>> multiple times in multiple steps.
>>>>
>>>> This test still fails if /etc/mtab is a regular file.
>>>
>>> The problem should be fixed now. Thanks!
>>>
>> Well, not for btrfs. See the new testcase below (ready for inclusion to the
>> GIT).
>
> Do you mean when /etc/mtab is a regular file? For btrfs we need fs
> root and this information is nowhere in mtab (and maybe another
> information related to subvolumes which we have in mountinfo).

No, My new testcase fails on a system with mtab being a symlink:

# ls -al /etc/mtab
lrwxrwxrwx 1 root root 19 Jul  7  2015 /etc/mtab -> ../proc/self/mounts

Not tested with a file.

-- 
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o.                         e-mail: sbrabec@suse.com
Lihovarská 1060/12                            tel: +49 911 7405384547
190 00 Praha 9                                 fax:  +420 284 084 001
Czech Republic                                    http://www.suse.cz/
PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76

  parent reply	other threads:[~2016-02-22 16:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-11 19:45 [PATCH] tests: add test for loop option in fstab Stanislav Brabec
2016-02-12 10:10 ` Karel Zak
2016-02-12 15:28 ` Ruediger Meier
2016-02-12 15:55   ` Stanislav Brabec
2016-02-15 11:42 ` Ruediger Meier
2016-02-16 14:49   ` Karel Zak
2016-02-19 18:27     ` Stanislav Brabec
2016-02-22 10:12       ` Karel Zak
2016-02-22 10:29         ` Ruediger Meier
2016-02-22 10:53           ` Karel Zak
2016-02-22 16:36         ` Stanislav Brabec [this message]
2016-02-24 18:58           ` Stanislav Brabec
2016-02-24 21:33             ` [PATCH] tests: add test for loop option in fstab (my mistake, and two new bugs, one in kernel) Stanislav Brabec
2016-02-25 19:31               ` Stanislav Brabec
2016-03-01 15:26                 ` Stanislav Brabec
  -- strict thread matches above, loose matches on Subject: below --
2016-02-12 16:23 [PATCH] tests: add test for loop option in fstab Ruediger Meier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CB3909.4080808@suse.cz \
    --to=sbrabec@suse.cz \
    --cc=kzak@redhat.com \
    --cc=sweet_f_a@gmx.de \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.