Re: [Qemu-devel] [PATCH v2 10/17] qapi: Add burst length parameters to block_set_io_throttle

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2171 bytes --]

On 02/18/2016 03:27 AM, Alberto Garcia wrote:
> This patch adds the new bps_*_max_length and iops_*_max_length
> parameters to the block_set_io_throttle command.
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  blockdev.c           | 31 +++++++++++++++++++++++++++++++
>  hmp.c                | 12 ++++++++++++
>  qapi/block-core.json | 51 +++++++++++++++++++++++++++++++++++++++++++++------
>  qmp-commands.hx      | 25 ++++++++++++++++---------
>  4 files changed, 104 insertions(+), 15 deletions(-)
> 
> diff --git a/blockdev.c b/blockdev.c
> index e8871fc..a5523ec 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -2590,6 +2590,18 @@ void qmp_block_set_io_throttle(const char *device, int64_t bps, int64_t bps_rd,
>                                 int64_t iops_rd_max,
>                                 bool has_iops_wr_max,
>                                 int64_t iops_wr_max,
> +                               bool has_bps_max_length,
> +                               int64_t bps_max_length,
> +                               bool has_bps_rd_max_length,
> +                               int64_t bps_rd_max_length,
> +                               bool has_bps_wr_max_length,
> +                               int64_t bps_wr_max_length,
> +                               bool has_iops_max_length,
> +                               int64_t iops_max_length,
> +                               bool has_iops_rd_max_length,
> +                               int64_t iops_rd_max_length,
> +                               bool has_iops_wr_max_length,
> +                               int64_t iops_wr_max_length,
>                                 bool has_iops_size,
>                                 int64_t iops_size,
>                                 bool has_group,

Not a problem with this patch, but your argument list is getting
painfully long; so we really want to simplify this once my boxed
parameters for commands lands:
https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04394.html


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]