From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXuOY-0001gT-4A for qemu-devel@nongnu.org; Mon, 22 Feb 2016 12:35:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXuOS-00070D-Re for qemu-devel@nongnu.org; Mon, 22 Feb 2016 12:35:37 -0500 Received: from mx2.suse.de ([195.135.220.15]:58913) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXuOS-000709-LW for qemu-devel@nongnu.org; Mon, 22 Feb 2016 12:35:32 -0500 References: <1456160797-832-1-git-send-email-mjrosato@linux.vnet.ibm.com> <1456160797-832-4-git-send-email-mjrosato@linux.vnet.ibm.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <56CB46E3.8060907@suse.de> Date: Mon, 22 Feb 2016 18:35:31 +0100 MIME-Version: 1.0 In-Reply-To: <1456160797-832-4-git-send-email-mjrosato@linux.vnet.ibm.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 3/7] s390x/cpu: Move some CPU initialization into realize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Matthew Rosato , qemu-devel@nongnu.org Cc: dahi@linux.vnet.ibm.com, agraf@suse.de, borntraeger@de.ibm.com, imammedo@redhat.com, bharata@linux.vnet.ibm.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, rth@twiddle.net Am 22.02.2016 um 18:06 schrieb Matthew Rosato: > In preparation for hotplug, defer some CPU initialization > until the device is actually being realized. >=20 > Signed-off-by: Matthew Rosato > --- > target-s390x/cpu.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Looks reasonable on a brief sight, Reviewed-by: Andreas F=E4rber What is env->cpu_num used for? In particular, have you thought about linux-user creating multiple CPUs and possibly destroying them again? Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=FC= rnberg)