From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46958)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aXvte-0005Tx-9v
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 14:11:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aXvtb-0006HJ-3P
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 14:11:50 -0500
Received: from mail-qg0-x230.google.com ([2607:f8b0:400d:c04::230]:36699)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aXvtT-0006Dc-Eq
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 14:11:47 -0500
Received: by mail-qg0-x230.google.com with SMTP id y9so120499278qgd.3
	for <qemu-devel@nongnu.org>; Mon, 22 Feb 2016 11:11:39 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1453832250-766-1-git-send-email-peter.maydell@linaro.org>
	<1453832250-766-16-git-send-email-peter.maydell@linaro.org>
	<56B5439C.6000309@twiddle.net>
	<CAFEAcA8TRQy1Q+qzCr=8Vapg4=4a5pUrSaunrkyD_ZRei3QNPg@mail.gmail.com>
	<CAFEAcA-hW-9qu-q-88VxhM0Xm4oVp9maGxzhDMz83+1EMkSjUQ@mail.gmail.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <56CB5D61.4040203@twiddle.net>
Date: Mon, 22 Feb 2016 11:11:29 -0800
MIME-Version: 1.0
In-Reply-To: <CAFEAcA-hW-9qu-q-88VxhM0Xm4oVp9maGxzhDMz83+1EMkSjUQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 15/37] tcg: Clean up includes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Patch Tracking <patches@linaro.org>

On 02/19/2016 10:24 AM, Peter Maydell wrote:
> On 6 February 2016 at 13:43, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 6 February 2016 at 00:51, Richard Henderson <rth@twiddle.net> wrote:
>>> On 01/27/2016 05:17 AM, Peter Maydell wrote:
>>>> diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
>>>> index 9187d34..d90636c 100644
>>>> --- a/tcg/i386/tcg-target.c
>>>> +++ b/tcg/i386/tcg-target.c
>>>> @@ -22,6 +22,7 @@
>>>>    * THE SOFTWARE.
>>>>    */
>>>>
>>>> +#include "qemu/osdep.h"
>>>>   #include "tcg-be-ldst.h"
>>>>
>>>>   #ifndef NDEBUG
>>>
>>>
>>> Nack to these, and the others like them.
>>> These files are not standalone, they are
>>> included into tcg.c, so we ought not be
>>> re-including qemu/osdep.h here.
>>
>> Mmm, but I preferred to retain the invariant that "all .c
>> files include osdep.h first" rather than special casing
>> these; the re-include is harmless.
>>
>> Alternatively we could rename these tcg-target.c
>> files to some other extension that makes it clearer that
>> they're not standalone source files.
> 
> How do you feel about renaming the tcg-target.c files to
> tcg-target.inc.c ? Then I can make clean-includes know that
> *.inc.c are not to have the cleaning rules applied to them.

I suppose.  Though is the pattern "*.inc.c" really any better than "tcg-target.c"?


r~