From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37275)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aXwlp-000589-1W
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 15:07:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aXwll-0004ib-SB
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 15:07:48 -0500
Received: from mail-qg0-x234.google.com ([2607:f8b0:400d:c04::234]:35798)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aXwll-0004iG-Ng
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 15:07:45 -0500
Received: by mail-qg0-x234.google.com with SMTP id y89so120297193qge.2
	for <qemu-devel@nongnu.org>; Mon, 22 Feb 2016 12:07:45 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1453832250-766-1-git-send-email-peter.maydell@linaro.org>
	<1453832250-766-16-git-send-email-peter.maydell@linaro.org>
	<56B5439C.6000309@twiddle.net>
	<CAFEAcA8TRQy1Q+qzCr=8Vapg4=4a5pUrSaunrkyD_ZRei3QNPg@mail.gmail.com>
	<CAFEAcA-hW-9qu-q-88VxhM0Xm4oVp9maGxzhDMz83+1EMkSjUQ@mail.gmail.com>
	<56CB5D61.4040203@twiddle.net>
	<CAFEAcA9qCpfzh7X3xcpM4jmKg7cm2EY6StvXdozgHMC7WO4ZvA@mail.gmail.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <56CB6A8D.6020003@twiddle.net>
Date: Mon, 22 Feb 2016 12:07:41 -0800
MIME-Version: 1.0
In-Reply-To: <CAFEAcA9qCpfzh7X3xcpM4jmKg7cm2EY6StvXdozgHMC7WO4ZvA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 15/37] tcg: Clean up includes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Patch Tracking <patches@linaro.org>

On 02/22/2016 11:24 AM, Peter Maydell wrote:
> On 22 February 2016 at 19:11, Richard Henderson <rth@twiddle.net> wrote:
>> On 02/19/2016 10:24 AM, Peter Maydell wrote:
>>> How do you feel about renaming the tcg-target.c files to
>>> tcg-target.inc.c ? Then I can make clean-includes know that
>>> *.inc.c are not to have the cleaning rules applied to them.
>>
>> I suppose.  Though is the pattern "*.inc.c" really any better
>> than "tcg-target.c"?
> 
> I think it's kind of confusing that tcg-target.c isn't a
> standalone C file, so giving it a clearer name is nicer
> for humans too.

No objection then.


r~