From: Matthew Rosato <mjrosato@linux.vnet.ibm.com>
To: "Andreas Färber" <afaerber@suse.de>, qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, agraf@suse.de, dahi@linux.vnet.ibm.com,
pbonzini@redhat.com, bharata@linux.vnet.ibm.com,
cornelia.huck@de.ibm.com, imammedo@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v6 3/7] s390x/cpu: Move some CPU initialization into realize
Date: Mon, 22 Feb 2016 15:41:43 -0500 [thread overview]
Message-ID: <56CB7287.3020100@linux.vnet.ibm.com> (raw)
In-Reply-To: <56CB46E3.8060907@suse.de>
On 02/22/2016 12:35 PM, Andreas Färber wrote:
> Am 22.02.2016 um 18:06 schrieb Matthew Rosato:
>> In preparation for hotplug, defer some CPU initialization
>> until the device is actually being realized.
>>
>> Signed-off-by: Matthew Rosato <mjrosato@linux.vnet.ibm.com>
>> ---
>> target-s390x/cpu.c | 9 ++++++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> Looks reasonable on a brief sight,
>
> Reviewed-by: Andreas Färber <afaerber@suse.de>
>
> What is env->cpu_num used for? In particular, have you thought about
> linux-user creating multiple CPUs and possibly destroying them again?
>
env->cpu_num is intended to map to the s390x architecture concept of a
cpu address, which is a numeric ID used to differentiate between CPUs
when a targeted event occurs (like an unsolicited interrupt that must be
handled on behalf of a particular CPU). s390x architecture currently
cannot tolerate CPU destruction.
Matt
next prev parent reply other threads:[~2016-02-22 20:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 17:06 [Qemu-devel] [PATCH v6 0/7] Allow hotplug of s390 CPUs Matthew Rosato
2016-02-22 17:06 ` [Qemu-devel] [PATCH v6 1/7] s390x/cpu: Cleanup init in preparation for hotplug Matthew Rosato
2016-02-22 17:46 ` Andreas Färber
2016-02-22 20:30 ` Matthew Rosato
2016-02-22 17:06 ` [Qemu-devel] [PATCH v6 2/7] s390x/cpu: Set initial CPU state in common routine Matthew Rosato
2016-02-22 17:06 ` [Qemu-devel] [PATCH v6 3/7] s390x/cpu: Move some CPU initialization into realize Matthew Rosato
2016-02-22 17:35 ` Andreas Färber
2016-02-22 20:41 ` Matthew Rosato [this message]
2016-02-22 17:06 ` [Qemu-devel] [PATCH v6 4/7] s390x/cpu: Add CPU property links Matthew Rosato
2016-02-22 17:06 ` [Qemu-devel] [PATCH v6 5/7] s390/virtio-ccw: Add hotplug handler Matthew Rosato
2016-02-22 17:06 ` [Qemu-devel] [PATCH v6 6/7] cpu: Add a last_cpu macro Matthew Rosato
2016-02-22 17:30 ` Andreas Färber
2016-02-22 17:06 ` [Qemu-devel] [PATCH v6 7/7] s390x/cpu: Allow hotplug of CPUs Matthew Rosato
2016-02-22 17:22 ` Andreas Färber
2016-02-22 20:54 ` Matthew Rosato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CB7287.3020100@linux.vnet.ibm.com \
--to=mjrosato@linux.vnet.ibm.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=bharata@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.