From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] owfs: new package
Date: Tue, 23 Feb 2016 00:08:28 +0100 [thread overview]
Message-ID: <56CB94EC.6030705@mind.be> (raw)
In-Reply-To: <20160222233719.55228a26@free-electrons.com>
On 02/22/16 23:37, Thomas Petazzoni wrote:
> Arnout,
>
> On Mon, 22 Feb 2016 21:36:59 +0100, Arnout Vandecappelle
> (Essensium/Mind) wrote:
>
> > diff --git a/package/owfs/0001-configure.ac-check-for-localtime_r.patch
> b/package/owfs/0001-configure.ac-check-for-localtime_r.patch
> > new file mode 100644
> > index 0000000..bdaab4f
> > --- /dev/null
> > +++ b/package/owfs/0001-configure.ac-check-for-localtime_r.patch
> > @@ -0,0 +1,48 @@
> > +From dd7c906a7e548ccb7b9c101221531d6b203f701f Mon Sep 17 00:00:00 2001
> > +From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
> > +Date: Sun, 21 Feb 2016 17:02:06 +0100
> > +Subject: [PATCH] configure.ac: check for localtime_r
> > +
> > +HAVE_LOCALTIME_R is used in module/owftpd/src/c/file_list.c, so it
> > +should be checked for.
> > +
> > +Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> > +---
> > + configure.ac | 2 +-
> > + module/swig/python/setup.py.in | 7 -------
> > + 2 files changed, 1 insertion(+), 8 deletions(-)
>
> Your description explains perfectly well the change in configure.ac,
> but does not explain the change done in setup.py.in. Shouldn't it be
> part of a separate patch, with a proper description ?
Oops, that's a leftover from my failed attempt to get python3 to work.
Regards,
Arnout
>
> The rest of the patch looks good.
>
> Thanks!
>
> Thomas
>
--
Arnout Vandecappelle arnout dot vandecappelle at essensium dot com
Senior Embedded Software Architect . . . . . . +32-478-010353 (mobile)
Essensium, Mind division . . . . . . . . . . . . . . http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium . . . . . BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
prev parent reply other threads:[~2016-02-22 23:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 20:36 [Buildroot] [PATCH] owfs: new package Arnout Vandecappelle
2016-02-22 22:37 ` Thomas Petazzoni
2016-02-22 23:08 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CB94EC.6030705@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.