From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 3/3] ARM: EXYNOS: cleanup header files inclusion Date: Tue, 23 Feb 2016 09:09:17 +0900 Message-ID: <56CBA32D.4020905@samsung.com> References: <1456135396-17767-1-git-send-email-pankaj.dubey@samsung.com> <1456135396-17767-4-git-send-email-pankaj.dubey@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:20230 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752159AbcBWAJZ (ORCPT ); Mon, 22 Feb 2016 19:09:25 -0500 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O2Z0033G4FMWH20@mailout2.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Tue, 23 Feb 2016 00:09:22 +0000 (GMT) In-reply-to: <1456135396-17767-4-git-send-email-pankaj.dubey@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Pankaj Dubey , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: kgene.kim@samsung.com, b.zolnierkie@samsung.com, daniel.lezcano@linaro.org, thomas.ab@samsung.com, linux@arm.linux.org.uk On 22.02.2016 19:03, Pankaj Dubey wrote: > This includes trivial cleanup in exynos files such as > - remove unused header files inclusion from exynos.c, s5p-dev-mfc.c, > firmware.c, pm.c. > - move inclusion of of.h from common.h to pm.c where it is really > required > > Signed-off-by: Pankaj Dubey > --- > arch/arm/mach-exynos/common.h | 1 - > arch/arm/mach-exynos/exynos.c | 5 ----- > arch/arm/mach-exynos/firmware.c | 2 -- > arch/arm/mach-exynos/platsmp.c | 1 - > arch/arm/mach-exynos/pm.c | 4 +--- > arch/arm/mach-exynos/s5p-dev-mfc.c | 1 - > 6 files changed, 1 insertion(+), 13 deletions(-) > > diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h > index e349a03..5365bf1 100644 > --- a/arch/arm/mach-exynos/common.h > +++ b/arch/arm/mach-exynos/common.h > @@ -12,7 +12,6 @@ > #ifndef __ARCH_ARM_MACH_EXYNOS_COMMON_H > #define __ARCH_ARM_MACH_EXYNOS_COMMON_H > > -#include > #include > > #define EXYNOS3250_SOC_ID 0xE3472000 > diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c > index 99947ad..54262a1 100644 > --- a/arch/arm/mach-exynos/exynos.c > +++ b/arch/arm/mach-exynos/exynos.c > @@ -11,14 +11,10 @@ > > #include > #include > -#include > -#include > #include > #include > #include > #include > -#include platform_device is actually used in that file. It looks unused because it is pulled by of_platform, but it makes sense to include it here. Rest looks good. BR, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Tue, 23 Feb 2016 09:09:17 +0900 Subject: [PATCH 3/3] ARM: EXYNOS: cleanup header files inclusion In-Reply-To: <1456135396-17767-4-git-send-email-pankaj.dubey@samsung.com> References: <1456135396-17767-1-git-send-email-pankaj.dubey@samsung.com> <1456135396-17767-4-git-send-email-pankaj.dubey@samsung.com> Message-ID: <56CBA32D.4020905@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 22.02.2016 19:03, Pankaj Dubey wrote: > This includes trivial cleanup in exynos files such as > - remove unused header files inclusion from exynos.c, s5p-dev-mfc.c, > firmware.c, pm.c. > - move inclusion of of.h from common.h to pm.c where it is really > required > > Signed-off-by: Pankaj Dubey > --- > arch/arm/mach-exynos/common.h | 1 - > arch/arm/mach-exynos/exynos.c | 5 ----- > arch/arm/mach-exynos/firmware.c | 2 -- > arch/arm/mach-exynos/platsmp.c | 1 - > arch/arm/mach-exynos/pm.c | 4 +--- > arch/arm/mach-exynos/s5p-dev-mfc.c | 1 - > 6 files changed, 1 insertion(+), 13 deletions(-) > > diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h > index e349a03..5365bf1 100644 > --- a/arch/arm/mach-exynos/common.h > +++ b/arch/arm/mach-exynos/common.h > @@ -12,7 +12,6 @@ > #ifndef __ARCH_ARM_MACH_EXYNOS_COMMON_H > #define __ARCH_ARM_MACH_EXYNOS_COMMON_H > > -#include > #include > > #define EXYNOS3250_SOC_ID 0xE3472000 > diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c > index 99947ad..54262a1 100644 > --- a/arch/arm/mach-exynos/exynos.c > +++ b/arch/arm/mach-exynos/exynos.c > @@ -11,14 +11,10 @@ > > #include > #include > -#include > -#include > #include > #include > #include > #include > -#include platform_device is actually used in that file. It looks unused because it is pulled by of_platform, but it makes sense to include it here. Rest looks good. BR, Krzysztof