Re: [Qemu-devel] [PATCH V3 1/2] net/filter-mirror:Add filter-mirror

[Jason Wang <jasowang@redhat.com>]

On 02/17/2016 11:53 AM, Zhang Chen wrote:
>
>
> On 02/15/2016 03:06 PM, Zhang Chen wrote:
>>
>>
>> On 02/15/2016 01:23 PM, Jason Wang wrote:
>>>
>>> On 02/04/2016 05:00 PM, Zhang Chen wrote:
>>>>
>>>> On 02/04/2016 03:43 PM, Zhang Chen wrote:
>>>>> From: ZhangChen <zhangchen.fnst@cn.fujitsu.com>
>>>>>
>>>>> Filter-mirror is a netfilter plugin.
>>>>> It gives qemu the ability to copy and mirror guest's
>>>>> net packet. we output packet to chardev.
>>> To make it compact, how about "It gives qemu the ability to mirror
>>> packets to a chardev."?
>>
>> OK, will fix it in next version.
>>
>>>>> usage:
>>>>>
>>>>> -netdev tap,id=hn0
>>>>> -chardev socket,id=mirror0,host=ip_primary,port=X,server,nowait
>>>>> -filter-mirror,id=m0,netdev=hn0,queue=tx/rx/all,outdev=mirror0
>>> An issue with mirror (and dump) is that it can not work correctly with
>>> the netdev that has a vnet header. Need to fix this, a possible
>>> solution
>>> is to checksum the buffer and strip the header before passing it to a
>>> chardev.
>>>
>>
>> Thanks, I don't consider about vnet, we will fix it in next version.
>>
>
> We have discussed for vnet in our team.  we think filter-mirror no
> need to
> do some analysis packet job, just do mirror job. and other job put it on
> other plugin like filter-writer and filter-compare. If we have two guest
> that both have vnet header, mirror one guest's packet to anther one.
> strip the header then mirror packet will result in errors. so let's strip
> vnet header in other plugin. keep filter-mirror simple.the
> filter-redirector
> is same as filter-mirror. 

Ok, I'm also fine with this.