From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH v2 3/4] m4/python: fix checks for Python library support Date: Mon, 22 Feb 2016 20:25:27 -0600 Message-ID: <56CBC317.60708@cardoe.com> References: <1455850625-9624-1-git-send-email-cardoe@cardoe.com> <1455850625-9624-3-git-send-email-cardoe@cardoe.com> <22219.13751.865220.68830@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7148867748432334265==" Return-path: In-Reply-To: <22219.13751.865220.68830@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Stefano Stabellini , Wei Liu , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============7148867748432334265== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0qfEji2Ei9DHMxIOR75wb0sR1Hrg66HBT" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0qfEji2Ei9DHMxIOR75wb0sR1Hrg66HBT Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2/22/16 10:22 AM, Ian Jackson wrote: > Doug Goldstein writes ("[PATCH v2 3/4] m4/python: fix checks for Python= library support"): >> AC_CHECK_LIB() was running gcc -Llib -lm -lutils conftest.c which on >> platforms that do as needed operations by default will result in >> underlinking. Instead AC_CHECK_LIB() suggests supplying the extra >> libraries necessary in a 5th argument. >=20 > I'm afraid I don't quite follow why the code in the patch has the > effect you desire. Why does setting LDFLAGS not work ? Forgive me if > I'm being dense - I'm afraid I have a cold. >=20 > Regards, > Ian. >=20 In fact this pattern is repeated all over the code base in makefiles: libxenctrl.so.$(MAJOR).$(MINOR): $(CTRL_PIC_OBJS) $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxenctrl.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(LDLIBS_libxentoollog) $(LDLIBS_libxenevtchn) $(LDLIBS_libxengnttab) $(LDLIBS_libxengntshr) $(LDLIBS_libxencall) $(LDLIBS_libxenforeignmemory) $(PTHREAD_LIBS) $(APPEND_LDFLAGS) COMPILER CFLAGS/LDFLAGS -o TARGET SOURCE LIBS --=20 Doug Goldstein --0qfEji2Ei9DHMxIOR75wb0sR1Hrg66HBT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWy8MbXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUd3gQAJefjofejmipcJS1r2XjJyps CfSlo5Ubcy6F2FEQalvP+696DsBcQ7KDPPo9ELHuzgb8DGHap+R/8HDLuhwgLwUb E91Mk6ZsyXrhnzacqbg9vrPkfkngJJAFeq+Mz+196/v46QROL8rf+tbPhf5RYIxY g2Ub9GXYauZT1otncrDdVwKJIm65LT0eU5y4eQ1eyh//CDRkE9cQIKxYsM97mGvM J4WRZFeV7KZrhXMDQtlXIIwUqYtVDmMdXqcQlsck2eRa58ix5JYq7dLoE377u538 M16pJKJarVIFZ9+F4kIWUf8Ubhn5Hxo39XkRZkOiBOxH87Zdm6+2nlKwEibpGjQF 0PcULkAfjAoTnnE2wyAybeDQgjFLaXYkCHCp9QIPDJr2r3ND7bWxCmR9fWLkQ72H 1+Z1hQfWmoUiHBGfa8a+hyClHUK3Udob5Ged1OjHhB7mSLDtF4upfmpP3G4FBWX/ n/u5n3BxcSE6QPdDHk8kWeZqwG2JVWu8N0de6YD7B57HIFJ0DftZYpK03dXMh00H 6FSCbFoSQc5URWe6hegevjj7Z/vA7mQNrlDI6sZoUkBpXUoB2SKkd0Av0qPkPs0P 6ZGNeBySEhxuVSxufCV7rGPKb+4QpWYKzFeEGEKoZibDL7j+15C6tsXH72G8f5DA jU3mRegar8m4wzjmTK0M =v9O9 -----END PGP SIGNATURE----- --0qfEji2Ei9DHMxIOR75wb0sR1Hrg66HBT-- --===============7148867748432334265== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7148867748432334265==--