From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32949)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1aY5xO-0000mj-Ht
	for qemu-devel@nongnu.org; Tue, 23 Feb 2016 00:56:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1aY5xL-00014d-BT
	for qemu-devel@nongnu.org; Tue, 23 Feb 2016 00:56:22 -0500
Received: from [59.151.112.132] (port=40876 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1aY5xK-0000vr-FG
	for qemu-devel@nongnu.org; Tue, 23 Feb 2016 00:56:19 -0500
Message-ID: <56CBF4CF.6030401@cn.fujitsu.com>
Date: Tue, 23 Feb 2016 13:57:35 +0800
From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1456134637-421-1-git-send-email-xiecl.fnst@cn.fujitsu.com>
	<1456134637-421-2-git-send-email-xiecl.fnst@cn.fujitsu.com>
	<w51egc4erws.fsf@maestria.local.igalia.com>
In-Reply-To: <w51egc4erws.fsf@maestria.local.igalia.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/1] quorum: modify vote rules for flush
	operation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>, qemu devel <qemu-devel@nongnu.org>, Eric Blake <eblake@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

On 02/22/2016 10:33 PM, Alberto Garcia wrote:
> On Mon 22 Feb 2016 10:50:37 AM CET, Changlong Xie wrote:
>> -    winner = quorum_get_vote_winner(&error_votes);
>> -    result = winner->value.l;
>> -
>> +    if (success_count >= s->threshold)
>> +        result = 0;
>> +    else {
>> +        winner = quorum_get_vote_winner(&error_votes);
>> +        result = winner->value.l;
>> +    }
>
> Please use braces in both branches of the if. scripts/checkpatch.pl
> should report that.

Surely.

>
> Other than that I think the patch is correct, but I still wonder if we
> should emit QUORUM_REPORT_BAD (or a new event) for the operations that

To me QUORUM_REPORT_BAD is not a good choice.

> fail. Or why wouldn't the user want to be notified of a flush failure?
>

I'll introduce a new event in next series.

Thanks
	-Xie

> Berto
>
>
> .
>