From: Gregor Boirie <gregor.boirie@parrot.com>
To: Harald Geyer <harald@ccbib.org>
Cc: <linux-iio@vger.kernel.org>, Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Daniel Baluta <daniel.baluta@intel.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Matt Ranostay <mranostay@gmail.com>,
Irina Tirdea <irina.tirdea@intel.com>,
Darshana Padmadas <darshanapadmadas@gmail.com>,
Martin Fuzzey <mfuzzey@parkeon.com>,
Octavian Purdila <octavian.purdila@intel.com>,
Vladimir Barinov <vladimir.barinov@cogentembedded.com>,
Crt Mori <cmo@melexis.com>, Masanari Iida <standby24x7@gmail.com>
Subject: Re: [PATCH v3 1/1] iio:core: timestamping clock selection support
Date: Tue, 23 Feb 2016 09:36:37 +0100 [thread overview]
Message-ID: <56CC1A15.6020704@parrot.com> (raw)
In-Reply-To: <E1aXvw9-0000bL-Gj@stardust.g4.wien.funkfeuer.at>
On 02/22/2016 08:14 PM, Harald Geyer wrote:
> Hi Gregor!
Hi Harald,
[snip]
> drivers/iio/humidity/dht11.c | 16 +-
> The dht11 driver only uses timestamps internally. AFAICT they are not
> exported to user space, so there is little point in making the clock
> selectable.
Ok. It seems no timestamping channel / events is exposed anyway: I
suppose it
makes no sense to use the timestamping clock API in this case.
>
> What's more important: The timestamps are used to decide the validity
> of cached values. I think your change introduces a bug where the driver
> could report outdated (or even uninitialized) values to user space.
>
> (Actually we switched the driver to monotonic time just recently to fix
> this.)
I guess I should leave the dht11 driver completly untouched in my patch
then.
Thanks for the quick feedback :)
[snip]
Regards,
Grégor.
prev parent reply other threads:[~2016-02-23 8:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 15:17 [PATCH v3 0/1] iio:core: introduce timestamping clock selection Gregor Boirie
2016-02-22 15:17 ` [PATCH v3 1/1] iio:core: timestamping clock selection support Gregor Boirie
2016-02-22 19:14 ` Harald Geyer
2016-02-23 8:36 ` Gregor Boirie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC1A15.6020704@parrot.com \
--to=gregor.boirie@parrot.com \
--cc=cmo@melexis.com \
--cc=daniel.baluta@intel.com \
--cc=darshanapadmadas@gmail.com \
--cc=hamohammed.sa@gmail.com \
--cc=harald@ccbib.org \
--cc=irina.tirdea@intel.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mfuzzey@parkeon.com \
--cc=mranostay@gmail.com \
--cc=octavian.purdila@intel.com \
--cc=pmeerw@pmeerw.net \
--cc=standby24x7@gmail.com \
--cc=vladimir.barinov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.