From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH RESEND] infiniband:core:Fix error handling in the function cm_lap_handler Date: Tue, 23 Feb 2016 10:54:23 +0200 Message-ID: <56CC1E3F.9070500@mellanox.com> References: <1456167558-10123-1-git-send-email-xerofoify@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1456167558-10123-1-git-send-email-xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Nicholas Krause Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org, yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org, erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, david.ahern-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 2/22/2016 8:59 PM, Nicholas Krause wrote: > This fixes error handling in the function cm_lap_handler to properly > check if the internal call to the function cm_init_av_for_response > has failed by returning a error code and if so exit immediately from > this particular function by freeing all previously allocated > resources before returning the error code to this function's caller > in order to allow the caller to handle the error properly in it's > > Signed-off-by: Nicholas Krause I think this is the longest sentence I have ever read in English, and it even doesn't have a end... please break it and tell us the (hopefully) happy end. Use IB/core: prefix and point to the commit you are fixing Fixes: xxx ('yyy') where xxx is the 12 digit abbrev-iated git short log and yyy the commit title -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752268AbcBWK3R (ORCPT ); Tue, 23 Feb 2016 05:29:17 -0500 Received: from mail-db3on0069.outbound.protection.outlook.com ([157.55.234.69]:11552 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751430AbcBWK3J (ORCPT ); Tue, 23 Feb 2016 05:29:09 -0500 X-Greylist: delayed 5649 seconds by postgrey-1.27 at vger.kernel.org; Tue, 23 Feb 2016 05:29:08 EST Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=pass action=none header.from=mellanox.com; Subject: Re: [PATCH RESEND] infiniband:core:Fix error handling in the function cm_lap_handler To: Nicholas Krause References: <1456167558-10123-1-git-send-email-xerofoify@gmail.com> CC: , , , , , , , , , , , From: Or Gerlitz Message-ID: <56CC1E3F.9070500@mellanox.com> Date: Tue, 23 Feb 2016 10:54:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1456167558-10123-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.12.129.35] X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11FD036;1:MEkZ/NYHW7TFGFGF323wvCbcqnJ7VNtlzYbBDPFMTYpy0hV70V5PxOdjd8OBcMiUULrTmQeQf0PgDJQly/lwEZa1qFTnTv5QmKmAMxE7IprRC38qSoGoQB8zWOcMvLg8xBhjU0fW+CCftJFbePZU03VvCcCjB9QT1AqLe2BfbZPi4CdWMHofh15B1a8Y0hw3LFjAeQr2nnDLNeR+A9FL0ACNQ/OmY6+dAxYPzRzs66KHaiokIfO4ht8H5sn2a8Eg/MOLpfkIr7VyMLH7TspXGeURDACNfJU9+wKpYYha1/c/2SJbJ+ayTzwY481bpNi+6++0PsD+hLBUS1diG7TMojR7LxjEh4M83RubUE8eXVo+HGUNt4O36H/r7DHyjEa/6fge8vX4qQM8Nym6lGSCS9Fdux4QTxHlq4moM6kqQOD2pBrLCrmckqlysUCkC3i1sPI+ykwjQWu0Viuqkws0zQ== X-Forefront-Antispam-Report: CIP:193.47.165.134;CTRY:IL;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(24454002)(199003)(479174004)(189002)(377454003)(87936001)(3846002)(50986999)(6806005)(65816999)(76176999)(54356999)(23746002)(87266999)(189998001)(110136002)(36756003)(5008740100001)(5004730100002)(47776003)(65806001)(1096002)(230700001)(1220700001)(65956001)(4326007)(586003)(59896002)(2906002)(6116002)(1411001)(83506001)(92566002)(2950100001)(86362001)(64126003)(33656002)(106466001)(19580405001)(77096005)(19580395003)(80316001)(3940600001)(21314002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR05MB560;H:mtlcas13.mtl.com;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DB4PR05MB560;2:NU4Le4hUHFP5FBQNY3J5MdJBbyYGE9eQ1MDM8pvTOVRz/hoYxfBvrbCNJKY+v+xyhvjdtdd54SSVc8jOEgdlUnkLzGb0F+ZLSrfWZklud815ZodI381ILwyIja6jbt02ztumyQQPyqipWd+OHihdOg==;3:ux85YxLAuCaraNPS10OEtS0/LioRHjqwvoQu7Zk/RFX1F8WDzdcEFcz4Y52HgzLnQre8c4aIqxTSGue2bq5xGTnlcqaz04gaFR1ClDUBKGFtB/c49bKOY7TdnfW6YoffodTLpzzq2E64rMTrrAgA6yvbqorHdEuTdze7tzCEXwJqFQ7oHdaCe/M4P9VNFdsKmitfJfTFepuhla8zNs29FliQIasuY5TmaxQeuY3+SGd4IZ5cNbBf2rpgpDG4/z+SytHBKMLFaEc9eHeU9TONsw==;25:yiEl04HjuPDLlvcFoEn1GXKGfq1d2VTWkOn0aRnWJqF3WtRx/kJqKR+5j6VVzkcRDZ66EjbA1l0oyJ1W+th1s1aGBwvZ0Ngnp012VA4Dh/iJHGfMZ2qWuVW5PQ0Chc+oWN40qFIEzEXtt57zQQTIOOogY1Dab+ReJ8DXD+CiBg7aAYPChInhquTbZITPXpawP7QHqqSc8r/fg2RIchCkDT90tUCfUbyn/Yq2CLcYgR9a3MDfztOLjET43YO4ulyY5FDUvRoXoHz2Cuk5r+I1fuZ2np1B7617Z+tknMNf0j2nNQ9CAXyNhrboHNMcOgS5cR/HrXypD6KJhw+IgbwLJve5A4l7VnkzdKe19E1ASb4= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:DB4PR05MB560; X-MS-Office365-Filtering-Correlation-Id: d5e74cd8-4e3d-42b5-c4f4-08d33c2f008e X-Microsoft-Exchange-Diagnostics: 1;DB4PR05MB560;20:4xGInfZCgC5kmlMabWKVPJqjFkFqUp+rJGgRTZibu2FAKYuE+EFCLnnRpcdIyZAJPUwEVDb+vWpKsc1wed+hrPgdp8QGOvrBo1HCkQq/PJ18MbWjbfmAJlrQyZzdpp8lt1wlpslcA3pbxywyWn6lQupusNRjPDSiURzIut+W1TyXdvVnqNSbmLvvLtzscGQ6E9imvEJsJE58cLKaDMYjfi4kPAO+Pj9vuK3pkO4+SogA1WSy93c905uXsEIMiriqHfuky6ogRPcy/a642Nyqvx9s56hO0yWo2JWVB40bW5iqTpLEDUsHGAH4ppc9OdN8RiE9lyk329It8xqu20T23gA/B8XI6vnt8E6hNzavVPfB5bUfRmJzi4aCTN8uLRefCTEwTXhdD98HI/VBzajC7rwpPuRf9bIuV0HgHeW2TRzFZ6s8gmEPEKBRNk4f5yu0macwEDGkFsO/u6RAvfp6Ia8i7IsXRDws/VCIkKCiFpwgOl73h/bMKG2c4EARgmWC X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(13015025)(13023025)(13024025)(13017025)(13018025)(5005006)(10201501046)(3002001);SRVR:DB4PR05MB560;BCL:0;PCL:0;RULEID:;SRVR:DB4PR05MB560; X-Microsoft-Exchange-Diagnostics: 1;DB4PR05MB560;4:B9Dkt6qr9FVhTXXa7PmaouoZ1HEGH5WtwTqq6pnQdh+lbcpx+bzRRZLkZ6O71uVFo1Dnd3dPmr5mX9lRgzHQknNy7qmn1hF5BXtbj+LGB1rMK1SjY+mc2fhyGutNSsWbXFxpKqB+B1aPHXM7zIrlodz0fl+HPsLPXm7mkLl8qe/n799IPzk+ND2IvsGxdVSYLg/mdNwjU2LgW6C/aZLODYzypeN++yhR1oNPwtHJMyZA0masmpUSDqVkWMeqMWmxoQKFZ3ccjIUdLRt7adE4qoPLA9MZW1TPNmAIoW0qzNrTRw7sNiyS76rjsNJ2+GkOhLIRsQcjONqFJp/mC36n91Nq311nGa5OUms4dXLbFQdijkgOAd+7xxc+23sIMR0uaPwmPaIj+heMhBa+DXPBxbyQGAlyB3rTegE2fQJIEjF9sEsNy6YskFGUCI+40ybsaQqVL2X7fqr3CBHFlOPmMw== X-Forefront-PRVS: 08617F610C X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB4PR05MB560;23:juSiS+7OmTRDNmz9T0L4QOaopbR2TV1vPdDyVO?= =?Windows-1252?Q?MTDJsgCgAYSNUPDXdemi24vA2Xvq/UDuN+I0sXfXwR8D82cFJoJqAZun?= =?Windows-1252?Q?4gemI1HnOg+eRd13HLLxzO++magCF1t+qTZ9cMvxKgv5NKEeLInyyQP1?= =?Windows-1252?Q?j6kywrnrMXcGIUy5NOOjg7S0fVFe68ZBZs7f8hqO8d5YDsnB0Yb+g7Vv?= =?Windows-1252?Q?KS7j0guQ7ndyeeO4j38tgShaD00n8XInMkGksVqqcCpyb92kDcx4LPJ/?= =?Windows-1252?Q?vsPp3Lrr1rs4ZVrVGKi5BgZZdhUFjtYOPWQ5N1NNPfLbYIVNHYDNcgIX?= =?Windows-1252?Q?ABbES8X5m2KyLWllR+5WWjMuE4WgLCtw6vNc3CGSqRT+OwTwwNzsjjY7?= =?Windows-1252?Q?Tw9IeuAB7eQ7ZJ/IpH2P0nzAT4oI+WUGwEt3y+jdUMsoomoVBGczc23x?= =?Windows-1252?Q?YdfvMs6q1wSW6oD9Zn45ZyAvmbdKsGOpN1XUXFDAfZlknVu15rfbgF+7?= =?Windows-1252?Q?6A3wDcOV8oDdybzyY+KxMIsDWXNw4/+GiEJQcOOuXjVN0qzi0abwQRIx?= =?Windows-1252?Q?qjiQ9bLrGAx2zntkF6Eq/PTplt+jBrc15GZc1CA49U054vpyf5ps/EZz?= =?Windows-1252?Q?WDOCFmFmErgf4mhnhhI3k2V9wG1MAG1jNjl6diXIc09l6T1GrouGZgpi?= =?Windows-1252?Q?nMdycZbOaAqjtodZX/45L6mgKf+WqBAIAJBcGT0jySWH1QAU/97W7QRg?= =?Windows-1252?Q?cNkexfBtLGgjJkWMTSC5pImHPmxfkEFbeGsOKOCSaO+ZWlDwMhxRl2NO?= =?Windows-1252?Q?n0RnB/NaNx3yOdiFPf8jWMdlivXu/kqPA7cUnQX4opaas4u1IQLGzC1H?= =?Windows-1252?Q?ETCOBu5CHudEjHdOzLpamf/Kp9/ts4XmZG4MExKO5XUAIpVzvHegNrwV?= =?Windows-1252?Q?YHpHvOAa5QTSXDqpOpCJuaU1IlwEfVvos4+YfRZazHQxppFVuBHZs5dJ?= =?Windows-1252?Q?b96L6Zg/xlCUd/yEF0CLsHmhlgUovBs3ESASWMPzZX6jRhOt8rwprsoM?= =?Windows-1252?Q?2mtHI6abV5w7f4xY5RIzKeBsn6Y4qBCTIY/HGvo7NBIZ1GSasq6IusxN?= =?Windows-1252?Q?NX+P0QcOmE2/X6yYAptlHioWUiln35gOuWbQKThVoSVmtalc8JGspPxF?= =?Windows-1252?Q?tADUNLYQnivh70kV7ilBV/tWthDj7vP5C3wfk0mUqeEQOCBydV9mo9cv?= =?Windows-1252?Q?jZ64pnbbHxzfbdJLiXWx+Pbn5h3GCXfTtfiKU=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB4PR05MB560;5:8SWi0oHFxWseiUYF6LqbVCKUoK3IkeuTGPBvRZt1dYccwdzwPYNWgyi56bv9BVnTnSAx9XJf0jwdFXjPaSS7GNQV7vhwkRZvwwkFdywlnYYjP3eK9sZwC54X00YmyP8kxQYlobHlOHIKMj9wkxFvuA==;24:gv67kFzgPxn+YTs1UPb5Zxvlmr49ckymktrRBBxR4RCH64JqipBxQ8wUfhJOzFXNr8ZTiQm9XFAGngRpSNNqFhTmlanPs4jhZCtI4L3konE= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2016 08:54:55.7673 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR05MB560 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/22/2016 8:59 PM, Nicholas Krause wrote: > This fixes error handling in the function cm_lap_handler to properly > check if the internal call to the function cm_init_av_for_response > has failed by returning a error code and if so exit immediately from > this particular function by freeing all previously allocated > resources before returning the error code to this function's caller > in order to allow the caller to handle the error properly in it's > > Signed-off-by: Nicholas Krause I think this is the longest sentence I have ever read in English, and it even doesn't have a end... please break it and tell us the (hopefully) happy end. Use IB/core: prefix and point to the commit you are fixing Fixes: xxx ('yyy') where xxx is the 12 digit abbrev-iated git short log and yyy the commit title