From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752724AbcBWLHV (ORCPT ); Tue, 23 Feb 2016 06:07:21 -0500 Received: from smtp121.iad3a.emailsrvr.com ([173.203.187.121]:38577 "EHLO smtp121.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752482AbcBWLHT (ORCPT ); Tue, 23 Feb 2016 06:07:19 -0500 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH] Staging: comedi: mite: added spaces around | and * To: Joe Perches , Philippe Loctaux , gregkh@linuxfoundation.org References: <1456184291-30665-1-git-send-email-phil@philippeloctaux.com> <1456187828.4139.3.camel@perches.com> Cc: hsweeten@visionengravers.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <56CC3D63.60706@mev.co.uk> Date: Tue, 23 Feb 2016 11:07:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1456187828.4139.3.camel@perches.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/02/16 00:37, Joe Perches wrote: > On Tue, 2016-02-23 at 00:38 +0100, Philippe Loctaux wrote: >> Added spaces around | and *, fixing 2 checkpatch checks. > [] >> diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c > [] >> @@ -51,7 +51,7 @@ >> >> #include "mite.h" >> >> -#define TOP_OF_PAGE(x) ((x)|(~(PAGE_MASK))) >> +#define TOP_OF_PAGE(x) ((x) | (~(PAGE_MASK))) > > It'd be nice to remove superfluous parentheses here too > > +#define TOP_OF_PAGE(x) ((x) | ~PAGE_MASK) > Even better: just remove the macro, as it isn't used. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-