From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulpanit Subject: Re: [PATCH V4 0/6] perf/amd/iommu: Enable multi-IOMMU support Date: Tue, 23 Feb 2016 18:39:04 +0700 Message-ID: <56CC44D8.4080604@amd.com> References: <1455182127-17551-1-git-send-email-Suravee.Suthikulpanit@amd.com> <20160223110406.GA22747@8bytes.org> <56CC422E.7050905@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56CC422E.7050905-5C7GfCeVMHo@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, andihartmann-KuiJ5kEpwI6ELgA04lAiVw@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org List-Id: iommu@lists.linux-foundation.org On 02/23/2016 06:27 PM, Suravee Suthikulpanit wrote: > Hi, > > On 02/23/2016 06:04 PM, Joerg Roedel wrote: >> Hi Suravee, >> >> On Thu, Feb 11, 2016 at 04:15:21PM +0700, Suthikulpanit, Suravee wrote: >>> From: Suravee Suthikulpanit >>> >>> This patch series modifies the existing perf_event_amd_iommu driver >>> to support systems with multiple IOMMUs. It introduces new AMD IOMMU >>> APIs, >>> which are used by the AMD IOMMU Perf driver to access performance >>> counters in multiple IOMMUs. >>> >>> In addition, this series should also fix current AMD IOMMU PMU driver >>> initialization issue in some existing KV and CZ platform, where it fails >>> to write to IOMMU perf counter as reported by Andreas Hartmann here >>> (http://comments.gmane.org/gmane.linux.kernel.pci/49147). >> >> Since that problem also affects older kernels, we need a stand-alone >> fix for this initialization issue. We can't backport new features to fix >> bugs in old kernels. >> >> >> Joerg >> > > OK, I am spliting V5 into two part. First would be just to fix the > issue. Then the second part would be to add the multiple IOMMU support. > > Suravee Actually, my V5 is rebased from tips which has moved several files. I think we might need to create a separate patch series to fix this issue in older kernels. Which branch should I rebase my changes for the older kernel? Suravee From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751526AbcBWLj3 (ORCPT ); Tue, 23 Feb 2016 06:39:29 -0500 Received: from mail-bn1bon0064.outbound.protection.outlook.com ([157.56.111.64]:19753 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750832AbcBWLj0 (ORCPT ); Tue, 23 Feb 2016 06:39:26 -0500 Authentication-Results: lists.linux-foundation.org; dkim=none (message not signed) header.d=none;lists.linux-foundation.org; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH V4 0/6] perf/amd/iommu: Enable multi-IOMMU support To: Joerg Roedel References: <1455182127-17551-1-git-send-email-Suravee.Suthikulpanit@amd.com> <20160223110406.GA22747@8bytes.org> <56CC422E.7050905@amd.com> CC: , , , , , , From: Suravee Suthikulpanit Message-ID: <56CC44D8.4080604@amd.com> Date: Tue, 23 Feb 2016 18:39:04 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56CC422E.7050905@amd.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [124.121.8.20] X-ClientProxiedBy: SIXPR04CA0014.apcprd04.prod.outlook.com (10.141.119.14) To SN1PR12MB0446.namprd12.prod.outlook.com (25.162.105.14) X-MS-Office365-Filtering-Correlation-Id: e1742a0d-7ee1-469e-b211-08d33c45fa62 X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0446;2:XiemM/XhiIZCj0a3zTGieqOwxyWSFrTmXTrhL/GqYP7jNCmBXtdU4uooJlQCi4Wu+WDOkYCRiBM78bAwb7l9Lr5zRazBNJnszm0BOOXYy/tizNk3ZKKA05yD2R8xR9i53igZ2vhPMnzrUhJG1OWplx1n9xsMnwfsIL+bg3+v7xD710hllJ7KrkLL4Ishd4WD;3:wjBptG959kwySbTlnJaeT0iVN0Gel8AwLIaTp7KI4KRrjJIvEIIj5zuMxX5mviMCLj9KfS5ELgjTY9R03cFiCu2VJFODNQ8CZ7p0/OBJ5dXP2CDonx8DRUb3vWCy74Qg;25:cwnSEsdz1BHkDCFN7P6IudMKD91xRrplkyR/lVFNAL5gmz/FI0LNyD1cfA5uy9Pz9wqa/p5iYt60QSGJW+hHicRfzmZNlGmVHFbS45UBFQzTWdgOcGpT83PfX0XlTFG2KrjlCfcllJ0rCdvCODsvJ29IT+TJPfg78Se5MbN9Syvwaeafbp+rMY8rDU1AQS/91CiOdU3WvClvUhn4BUBIApcG7kzPKCOKVBvIhFd3lWCYUnkq2AyvqG+goCazFqW3QmZoGCJrIb3uYzcNDkQIuovCwzg2Nb2cQc84GMBPSC2qFWFf0LXj6HrMd/CcJLnF/fsQOfnK4Bdae15op38Nh0QJy2vKVbMMknkVwbYHDCk= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0446; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0446;20:lHVjIqoJNCLGkoB2NBb5vFdI+S/4qz8z4Yb961LcYBNHzuyTtkeCpuMGvOFzN9OsyVF1u0TKJHc34Y/DmH1d272PNZKkVHaaDtlJDk88iKNORrXVCfc7cHukpWyvyBgdeH8bwr6NrJrCdjG/rILuBFCD5kfP3L91yqJcKp4XMbLSpVQ3KNoc9LPqQ9GxDzIRQXfQA2QwgOe1/xKaaLJSzo8DmAFxyQm1BuZI3gpJUrjOtLNXkfaUt5H9sXvMEzkX2BPT8l5ZEsCR7NvOIOW/MrrnHh8S0LDQZ7xw9c48qmt+zkF5myNaZGPVZMhOKYVRQpvFDr3JlMFeieWIFQm1g1qDWpBrldWsOccAP79Za7PTAPBgjNWrCxsP7p81ZSyiWUMp1P4VRapUmIPUGlhtaGM3+Z0W1H0187tKWEVsPH7z2rcO8OImfjWsLLG3tl6OQcJClnU+PvP3F1xFXT1L5Va6+OgatA3wtdKBBqCxXMxPEkOi2YkUle35tczN0fTI;4:uhuxfaO2PUiRarVNQV1uJaQezXqwcezsctGSNqJQOZzuQdlM00ntJFJmzd6wqc/9HWPmYThOkS2Y9vtrKVcwZhoyEBdlWAU9tNt9mIn5RQWOxAmLVSBRexqdGZDKPpdR0TZBYFl/FUcvWDh9N3yCYvK9wh8/iXOaub3ldUfjzSuCmfZqvqdjulAGtuxkigUmdH3PUbAubTkidu4c1LcZryQMQaYX7Tz/nL0uHZR9M+xOOv1KuEq1m7chk0VgwcLcXs2vivJV7TJOcTlRbA8HRfWcUiZDkv8g93LEaAbasC8fg8U5kUahZqNiZGcDroLghDsS9/AX+RicGcCOfjGHUrqR2ygyOWryt7jNtQwTRC1B3/IJaLYfa84vYzClMcxoRd+okSzxzO5koGsEPuPw7AxYkf71oNDGWj5H+J1VNMI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:SN1PR12MB0446;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0446; X-Forefront-PRVS: 08617F610C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(24454002)(479174004)(377454003)(42186005)(87976001)(3846002)(50986999)(76176999)(54356999)(87266999)(65816999)(110136002)(5001960100002)(23746002)(189998001)(36756003)(65956001)(86362001)(66066001)(59896002)(5004730100002)(47776003)(117156001)(230700001)(4326007)(1096002)(586003)(5008740100001)(2906002)(6116002)(15975445007)(50466002)(92566002)(83506001)(2950100001)(64126003)(33656002)(122386002)(65806001)(19580405001)(77096005)(19580395003)(80316001)(4001350100001)(40100003);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0446;H:[192.168.0.19];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;SN1PR12MB0446;23:GUlxEcAQSjwKEXWBd89pX+bS0ZhM8cSUMkpkz?= =?Windows-1252?Q?vb35Z2le6PeGZNBEsN7rV8UTQOALUIZTK71vAOtDy/9qcpdrhLvkJstA?= =?Windows-1252?Q?z1STgAMq/zSI0SinG86HdouFRqtHCTHT7WzKkb+9dIi678zV605atyHG?= =?Windows-1252?Q?73H572Ol1jhe8hkK+L0SC+ynYADz44FApPwyszO41GXFPQz9ByheOyBy?= =?Windows-1252?Q?G7JOWPIPUOCnPg8AvkqhF7tcarSjrO1UAP0EPRndXTyxIBPyJaVoTXNG?= =?Windows-1252?Q?GUUJY/inKUDjYneIF8FWUsghGdHo2kwkynYiMzMJo75fo+cwmf5j9zd7?= =?Windows-1252?Q?ocnqR7aJZl/oEtuTsesdMyXz3D9gBMUwPCTKORP0qKz8s8qaZeDTw/KP?= =?Windows-1252?Q?jkkrOkjojh0CGOTiVooKGVU83y1T5dNbajScG7TdNiK0fOj0Rv4LHyYl?= =?Windows-1252?Q?avwBaz/DEoUNYxmmKPZ5aYrPOWXvIQRA2yJTU5/4yjiV92ih1xZw9ivb?= =?Windows-1252?Q?QiknBYB7degXmO9R6KAS/r1N88VOym5jgweqtwIq6l8kORrrcR5J9soZ?= =?Windows-1252?Q?F1GhdOVviBuQYl+DcnZF6KXLFKUM0HwRdRxzvsbZI9unrP2a6xlyIYrp?= =?Windows-1252?Q?MzOOS7aOkLdSaaVmOIsRuncdz36Z/puWvDsx7O6odPi6kCmfCuS9HmzL?= =?Windows-1252?Q?AUM7F52zATCeQ7LnmWjpDAvDcNGTtKpP5m7CwLzDueb9khgpXJKvCPTQ?= =?Windows-1252?Q?RUGRVqsYXalhgVno1P5XfzXRrfZR6ysaGLMoCL9xLmMwSYWmwTWWIaNs?= =?Windows-1252?Q?XT+uFb/t6WWF8NlGRt+PEbg1g/8P9ABaOptYeJ/8Jp1yo+gqIdLX9uCl?= =?Windows-1252?Q?w5ViADytm/Y+lFn9KDBpK3Xghp3brKvu17fLik/qAbbzUnB40tcFgG16?= =?Windows-1252?Q?qucygB20pRzwZc+BneLfut2QEtgwayP6rccpl/Px/m81OsPCjOlcwNKi?= =?Windows-1252?Q?Rf6WOK2ia5N+E7rt3cjskqM9spGJzbSQZLYeP+/z7f86wueuZng75RyI?= =?Windows-1252?Q?B8q1uHFwGKtltDPKWXVZAqXxZSYvdHi2VC+IJySV0ITV4xFtBcUEjEX6?= =?Windows-1252?Q?Vo7s+H3jLTzsYMOPpVmv1C4k33mI+69fg0mJu9DP1V1MOlh9EnUHpP0C?= =?Windows-1252?Q?JNCo7Imztxi9HLWyJN5pZoYQfRKX/XkOl7NFQ2GSRyei8Yxf3HuYDeA+?= =?Windows-1252?Q?Af653LtzBf0Wd06Et8Z1gIGQ+QEuwRnnH/KQQ7SRjwd7GgQY3irMFddJ?= =?Windows-1252?Q?AXw9a9N9+MWiE/D48VuHQNs0AV4N9rWOaKyXXJtBfLODqU=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0446;5:EcFGKq4V2oPqg7lbGCEma4ffKvhWyjSknyW5DLj0JAhyMiGHMbakRYcZXvjuywDhDgMGHuhFo/zxhvdu46ghppAKa8MHJvpBF5GoJ7hUmUWgGXcdufv3C+YEs+QkABT0aTHcLSgVDKeWb5aqtD9zBA==;24:niw7oYxmD4R3MHFcMfltaVne4zkSPCyUGcPI6s8/vOeV7/cPNJ2keFTCZTDLvrPetIFXya3HB1pcHkmKWcdZknGTnyhMZjRxcII+0MSjeyo=;20:qFKyPSq/H6Gdcxggvhbx9fycWniAQabMmxwKpPKkgY/1+aR94JOtxlSe4OqT32cJHzE+3cZ3aBjkvQ+80gxREj3HX4f05RHRTHv/3UWsS3tNJPBRDeVz8VhnGpi1ANfz3K9Bt+HQ0oIM/MvzC8aCEw+Llr5l4Qbh4fI4RvR7F4QvcTTfZDWh9/cbAm67uNTPlnFJktyMyF323Ac9T9/wx275OwMxG+nninE/wOgYb4OPes4kfqj9a69llZnv+MBK SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2016 11:39:21.5240 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0446 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/23/2016 06:27 PM, Suravee Suthikulpanit wrote: > Hi, > > On 02/23/2016 06:04 PM, Joerg Roedel wrote: >> Hi Suravee, >> >> On Thu, Feb 11, 2016 at 04:15:21PM +0700, Suthikulpanit, Suravee wrote: >>> From: Suravee Suthikulpanit >>> >>> This patch series modifies the existing perf_event_amd_iommu driver >>> to support systems with multiple IOMMUs. It introduces new AMD IOMMU >>> APIs, >>> which are used by the AMD IOMMU Perf driver to access performance >>> counters in multiple IOMMUs. >>> >>> In addition, this series should also fix current AMD IOMMU PMU driver >>> initialization issue in some existing KV and CZ platform, where it fails >>> to write to IOMMU perf counter as reported by Andreas Hartmann here >>> (http://comments.gmane.org/gmane.linux.kernel.pci/49147). >> >> Since that problem also affects older kernels, we need a stand-alone >> fix for this initialization issue. We can't backport new features to fix >> bugs in old kernels. >> >> >> Joerg >> > > OK, I am spliting V5 into two part. First would be just to fix the > issue. Then the second part would be to add the multiple IOMMU support. > > Suravee Actually, my V5 is rebased from tips which has moved several files. I think we might need to create a separate patch series to fix this issue in older kernels. Which branch should I rebase my changes for the older kernel? Suravee