From: Remy Horton <remy.horton@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH v1 0/3] Add missing ethdev driver support
Date: Tue, 23 Feb 2016 12:19:13 +0000 [thread overview]
Message-ID: <56CC4E41.4040109@intel.com> (raw)
In-Reply-To: <20160216105452.0b1da99f@xeon-e3>
On 16/02/2016 18:54, Stephen Hemminger wrote:
> On Thu, 28 Jan 2016 08:48:12 +0000
> Remy Horton <remy.horton@intel.com> wrote:
>
>> Several rte_eth_dev_* functions are currently only supported
>> by the ixgbe NIC driver. This patchset adds driver support
>> for some of these functions to the i40e, virtio, and vmxnet3
>> drivers.
>
> It is good to make drivers more complete and compatible, but unless
> the virtual driver has some useful data I can't see the point of providing
> these functions in this case. The base infrastructure (rte_ethdev) should
> deal with by returning not supported error (or all zeros); rather than
> creating more code in other drivers for no real gain.
Come to the same conclusion regarding the Rx/Tx queue info functions, as
working out how to derive the figures I could return was also baking in
some implicit assumptions. Plan to exclude those ones from the v2.
..Remy
next prev parent reply other threads:[~2016-02-23 12:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 8:48 [PATCH v1 0/3] Add missing ethdev driver support Remy Horton
2016-01-28 8:48 ` [PATCH v1 1/3] drivers/net/i40e: Add ethdev functions Remy Horton
2016-02-23 2:06 ` Zhang, Helin
2016-02-24 10:32 ` Remy Horton
2016-02-24 10:43 ` Ananyev, Konstantin
2016-01-28 8:48 ` [PATCH v1 2/3] drivers/net/virtio: " Remy Horton
2016-01-28 8:48 ` [PATCH v1 3/3] drivers/net/vmxnet3: " Remy Horton
2016-02-16 23:42 ` Yong Wang
2016-02-16 12:02 ` [PATCH v1 0/3] Add missing ethdev driver support Bruce Richardson
2016-02-16 18:54 ` Stephen Hemminger
2016-02-23 12:19 ` Remy Horton [this message]
2016-03-04 15:25 ` [PATCH v2 0/2] " Remy Horton
2016-03-04 15:25 ` [PATCH v2 1/2] drivers/net/i40e: add ethdev functions Remy Horton
2016-03-04 15:25 ` [PATCH v2 2/2] drivers/net/vmxnet3: " Remy Horton
2016-03-04 19:12 ` Yong Wang
2016-03-04 20:34 ` Stephen Hemminger
2016-03-07 12:26 ` Remy Horton
2016-03-07 16:07 ` Stephen Hemminger
2016-03-07 17:06 ` Remy Horton
2016-03-07 19:19 ` Stephen Hemminger
2016-03-09 13:29 ` [PATCH v3 0/1] Add missing ethdev driver support Remy Horton
2016-03-09 13:29 ` [PATCH v3 1/1] drivers/net/i40e: add ethdev functions Remy Horton
2016-03-10 12:25 ` Mcnamara, John
2016-03-14 10:22 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC4E41.4040109@intel.com \
--to=remy.horton@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.