From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYDHm-0005lq-Ll for qemu-devel@nongnu.org; Tue, 23 Feb 2016 08:45:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYDHj-0007Zj-FD for qemu-devel@nongnu.org; Tue, 23 Feb 2016 08:45:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37394) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYDHj-0007ZZ-9U for qemu-devel@nongnu.org; Tue, 23 Feb 2016 08:45:51 -0500 References: <1456218099-386-1-git-send-email-xiecl.fnst@cn.fujitsu.com> <1456218099-386-2-git-send-email-xiecl.fnst@cn.fujitsu.com> <56CC5BE3.9090503@redhat.com> From: Eric Blake Message-ID: <56CC628D.7040909@redhat.com> Date: Tue, 23 Feb 2016 06:45:49 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XTCuWqK4Qld8aImmtLuMSMCsn7g9kPg0F" Subject: Re: [Qemu-devel] [PATCH v4 1/2] qmp event: Add QUORUM_FLUSH_ERROR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , Changlong Xie , qemu devel , Kevin Wolf , Max Reitz Cc: "Dr. David Alan Gilbert" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XTCuWqK4Qld8aImmtLuMSMCsn7g9kPg0F Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/23/2016 06:24 AM, Alberto Garcia wrote: > On Tue 23 Feb 2016 02:17:23 PM CET, Eric Blake wrote: >=20 >> Commit message should say why we need a third event, rather than >> reusing either of the other two (my guess: because you don't have a >> location, and don't want to modify the existing two to report a >> location - but why not just use 'sector-num':0, 'sectors-count':> of file> to report the entire file as the location?) >=20 > I would also be fine with that solution. I would also be fine if we added an optional enum member to the existing event that said which operation failed ('read', 'write', 'flush') - adding optional output members is safe, while converting existing mandatory output members to optional may confuse existing clients. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --XTCuWqK4Qld8aImmtLuMSMCsn7g9kPg0F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWzGKNAAoJEKeha0olJ0Nq5YcH/RP3/5xcQPY7aHkZnaYSWV+e MW5mojT2Pys5aFlqE8ixpnumCeGd17EARiKJgJj0qnZhxWkWxCvu9EhlBKeA3EcT CDmPRDKwzs0UrVHuH0B2im3wdiM6J9pMlDmQip98m4/7NgXkZHAHGH4dU1hNm2by bdqKF26EobMq1CI2n3AcC8RgBZoBo+7kg5zo5vKU1HlIY9gg2DVN3g3R+wTbe5A2 JfC9H7GD3Yaew7ar7vy+gmtLojhYmdnI3E2GXspe+WllT1m7ThTYVxKTjjmcgI21 fVkFhnYQ8Iq6u1tZz+AscXCP4Iq91lYS2WSftckK2ARNbd365NVNqp6tixxU/MQ= =58yT -----END PGP SIGNATURE----- --XTCuWqK4Qld8aImmtLuMSMCsn7g9kPg0F--